From e025a04a602768fc5e6905ec2f9c74c2f8bda32e Mon Sep 17 00:00:00 2001 From: cfallows-amd Date: Mon, 12 May 2025 23:02:47 -0400 Subject: [PATCH] Fix setting roofline-data-type option in both profile and analyze modes (#702) Signed-off-by: Carrie Fallows [ROCm/rocprofiler-compute commit: d527d773378d2563226aef250f0ba1a40553851f] --- .../src/rocprof_compute_analyze/analysis_webui.py | 3 +-- projects/rocprofiler-compute/src/roofline.py | 6 +----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_webui.py b/projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_webui.py index 2f9f567d31..2bc7c7c33b 100644 --- a/projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_webui.py +++ b/projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_webui.py @@ -61,8 +61,7 @@ class webui_analysis(OmniAnalyze_Base): # define any elements which will have full width self.__full_width_elements = {1801} - if hasattr(args, "roofline_data_type") and args.roofline_data_type != ["FP32"]: - self.__roofline_data_type = args.roofline_data_type + self.__roofline_data_type = args.roofline_data_type @demarcate def build_layout(self, input_filters, arch_configs): diff --git a/projects/rocprofiler-compute/src/roofline.py b/projects/rocprofiler-compute/src/roofline.py index 3293e870d1..c9a179987e 100644 --- a/projects/rocprofiler-compute/src/roofline.py +++ b/projects/rocprofiler-compute/src/roofline.py @@ -60,7 +60,6 @@ class Roofline: "mem_level": "ALL", "include_kernel_names": False, "is_standalone": False, - "roofline_data_type": ["FP32"], } ) self.__ai_data = None @@ -77,10 +76,7 @@ class Roofline: self.__run_parameters["mem_level"] = self.__args.mem_level if hasattr(self.__args, "sort") and self.__args.sort != "ALL": self.__run_parameters["sort_type"] = self.__args.sort - if hasattr( - self.__args, "roofline_data_type" - ) and self.__args.roofline_data_type != ["FP32"]: - self.__run_parameters["roofline_data_type"] = self.__args.roofline_data_type + self.__run_parameters["roofline_data_type"] = self.__args.roofline_data_type self.validate_parameters() def validate_parameters(self):