SWDEV-1 - Fix warnings and update disabled test list (#163)

- Fix warnings in some test cases due to unused variables or signed/unsigned comparison.
- Disabled vulkan tests on MI200.

[ROCm/hip-tests commit: 88fbbd666b]
This commit is contained in:
Maneesh Gupta
2023-02-09 18:52:27 +05:30
committed by GitHub
parent aa1a82b9f0
commit e19e50052d
6 changed files with 24 additions and 9 deletions
@@ -21,7 +21,9 @@ THE SOFTWARE.
#include "vulkan_test.hh"
#if HT_AMD && 0
constexpr bool enable_validation = false;
#endif
TEST_CASE("Unit_hipDestroyExternalMemory_Vulkan_Negative_Parameters") {
SECTION("extMem == nullptr") {
@@ -42,4 +44,4 @@ TEST_CASE("Unit_hipDestroyExternalMemory_Vulkan_Negative_Parameters") {
HIP_CHECK_ERROR(hipDestroyExternalMemory(ext_memory), hipErrorInvalidValue);
}
#endif
}
}
@@ -112,7 +112,9 @@ TEST_CASE("Unit_hipExternalMemoryGetMappedBuffer_Vulkan_Negative_Parameters") {
hipExternalMemoryBufferDesc external_mem_buffer_desc = {};
external_mem_buffer_desc.size = vk_storage.size;
#if HT_NVIDIA
void* hip_dev_ptr = nullptr;
#endif
// Disabled on AMD due to defect - EXSWHTEC-176
#if HT_NVIDIA
@@ -150,4 +152,4 @@ TEST_CASE("Unit_hipExternalMemoryGetMappedBuffer_Vulkan_Negative_Parameters") {
hipErrorInvalidValue);
}
#endif
}
}
@@ -25,9 +25,11 @@ constexpr bool enable_validation = false;
TEST_CASE("Unit_hipImportExternalMemory_Vulkan_Negative_Parameters") {
VulkanTest vkt(enable_validation);
#if HT_NVIDIA
const auto storage = vkt.CreateMappedStorage<int>(1, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true);
auto desc = vkt.BuildMemoryDescriptor(storage.memory, sizeof(*storage.host_ptr));
hipExternalMemory_t ext_memory;
#endif
// Disabled due to defect - EXSWHTEC-182
#if HT_NVIDIA
@@ -73,4 +75,4 @@ TEST_CASE("Unit_hipImportExternalMemory_Vulkan_Negative_Parameters") {
HIP_CHECK_ERROR(hipImportExternalMemory(&ext_memory, &desc), hipErrorInvalidValue);
}
#endif
}
}