SWDEV-306939 - Fix vdi errors/warnings by CppCheck

Change-Id: I56d910f8363787f1050d5d7e8064ed553c5827fd

rocclr/compiler/lib/utils/options.cpp

@@ -1093,7 +1093,7 @@ parseAllOptions(std::string& options, Options& Opts, bool linkOptsOnly, bool isL
         bool isPrefix_mno = false;
         bool isPrefix_option = false;
 
-        std::string name, value;
+        std::string value;
         size_t sPos  = pos;
         int option_ndx
             = getOptionDesc(options, sPos, isShortName, OFA_NORMAL, pos, value);

rocclr/compiler/lib/utils/options.hpp

@@ -258,7 +258,6 @@ public:
         int r = option_ndx/32;
         int c = option_ndx%32;
         const uint32_t *p = &flags[r];
-        uint32_t b = (1 << c);
         return 1 & ((*p) >> c);
     }
 
@@ -266,7 +265,7 @@ public:
         return (getFlag(option_ndx) == FLAG_SEEN);
     }
 
-    int    getLLVMArgc() { return llvmargc; }
+    int    getLLVMArgc() const { return llvmargc; }
     char** getLLVMArgv() { return llvmargv; }
     void   setLLVMArgs (int argc, char** argv) {
         llvmargc = argc;
@@ -290,7 +289,7 @@ public:
     bool isCStrOptionsEqual(const char *cs1, const char* cs2) const;
 
 
-    bool useDefaultWGS() { return UseDefaultWGS; }
+    bool useDefaultWGS() const { return UseDefaultWGS; }
     void setDefaultWGS(bool V) { UseDefaultWGS = V; }
 
     std::string& optionsLog() { return OptionsLog; }
@@ -328,7 +327,7 @@ private:
 
     bool UseDefaultWGS;
 
-    bool dumpEncrypt(DumpFlags f) {
+    bool dumpEncrypt(DumpFlags f) const {
         return ((encryptCode == 0) ||   // return true if not encrypted
                 (f & DUMP_ENCRYPT));
     }