From e27d53043cd76734ca570a642a8f7fb841c0541f Mon Sep 17 00:00:00 2001 From: Aryan Salmanpour Date: Fri, 10 Jul 2020 12:07:50 -0400 Subject: [PATCH] Add missing stream null check for some hipStreamCreate APIs Change-Id: I716d71e4ec59b0bd7922869bfa0ed908c22c289e --- hipamd/rocclr/hip_stream.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hipamd/rocclr/hip_stream.cpp b/hipamd/rocclr/hip_stream.cpp index 8d3d3e4340..9da673f023 100755 --- a/hipamd/rocclr/hip_stream.cpp +++ b/hipamd/rocclr/hip_stream.cpp @@ -202,6 +202,10 @@ static hipError_t ihipStreamCreate(hipStream_t* stream, hipError_t hipStreamCreateWithFlags(hipStream_t *stream, unsigned int flags) { HIP_INIT_API(hipStreamCreateWithFlags, stream, flags); + if (stream == nullptr) { + HIP_RETURN(hipErrorInvalidValue); + } + HIP_RETURN(ihipStreamCreate(stream, flags, hip::Stream::Priority::Normal), *stream); } @@ -209,6 +213,10 @@ hipError_t hipStreamCreateWithFlags(hipStream_t *stream, unsigned int flags) { hipError_t hipStreamCreate(hipStream_t *stream) { HIP_INIT_API(hipStreamCreate, stream); + if (stream == nullptr) { + HIP_RETURN(hipErrorInvalidValue); + } + HIP_RETURN(ihipStreamCreate(stream, hipStreamDefault, hip::Stream::Priority::Normal), *stream); } @@ -216,6 +224,10 @@ hipError_t hipStreamCreate(hipStream_t *stream) { hipError_t hipStreamCreateWithPriority(hipStream_t* stream, unsigned int flags, int priority) { HIP_INIT_API(hipStreamCreateWithPriority, stream, flags, priority); + if (stream == nullptr) { + HIP_RETURN(hipErrorInvalidValue); + } + hip::Stream::Priority streamPriority; if (priority <= hip::Stream::Priority::High) { streamPriority = hip::Stream::Priority::High;