adding pandas and pytest to rquirements.txt (#748)

* adding pandas and pytest to rquirements.txt

* setting up requrements.txt

* Update requirements

- formatting packages
- remove packages not directly used by rocprofiler-sdk

* Update cmake formatting, linting, and options

- if BUILD_CI -> force BUILD_DEVELOPER and BUILD_WERROR
- support python installed clang-format and python installed clang-tidy

* Update build.sh

- split into install-deps.sh and install-apt-deps.sh

* Improve code coverage

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

source/lib/rocprofiler-sdk-tool/CMakeLists.txt

@@ -20,11 +20,6 @@ target_link_libraries(
             rocprofiler::rocprofiler-build-flags rocprofiler::rocprofiler-memcheck
             rocprofiler::rocprofiler-common-library)
 
-if(ROCPROFILER_BUILD_CODECOV)
-    target_compile_definitions(rocprofiler-sdk-tool PRIVATE ROCPROFILER_CODECOV=1)
-    target_link_libraries(rocprofiler-sdk-tool PRIVATE gcov)
-endif()
-
 set_target_properties(
     rocprofiler-sdk-tool
     PROPERTIES LIBRARY_OUTPUT_DIRECTORY

source/lib/rocprofiler-sdk-tool/tool.cpp

@@ -56,7 +56,7 @@
 #include <unordered_set>
 #include <vector>
 
-#if defined(ROCPROFILER_CODECOV) && ROCPROFILER_CODECOV > 0
+#if defined(CODECOV) && CODECOV > 0
 extern "C" {
 extern void
 __gcov_dump(void);
@@ -1731,7 +1731,7 @@ generate_output(buffer_type_t buffer_type)
 }  // namespace
 
 void
-tool_fini(void* tool_data)
+tool_fini(void* /*tool_data*/)
 {
     client_identifier = nullptr;
     client_finalizer  = nullptr;
@@ -1802,8 +1802,7 @@ tool_fini(void* tool_data)
         destructors = nullptr;
     }
 
-    (void) (tool_data);
-#if defined(ROCPROFILER_CODECOV) && ROCPROFILER_CODECOV > 0
+#if defined(CODECOV) && CODECOV > 0
     __gcov_dump();
 #endif
 }

source/lib/rocprofiler-sdk/registration.cpp

@@ -73,6 +73,11 @@ extern "C" {
 
 extern rocprofiler_tool_configure_result_t*
 rocprofiler_configure(uint32_t, const char*, uint32_t, rocprofiler_client_id_t*);
+
+#if defined(CODECOV) && CODECOV > 0
+extern void
+__gcov_dump(void);
+#endif
 }
 
 namespace rocprofiler
@@ -569,6 +574,10 @@ initialize()
 void
 finalize()
 {
+#if defined(CODECOV) && CODECOV > 0
+    if(get_fini_status() > 0) __gcov_dump();
+#endif
+
     if(get_fini_status() != 0)
     {
         ROCP_INFO << "ignoring finalization request (value=" << get_fini_status() << ")";
@@ -599,6 +608,10 @@ finalize()
         internal_threading::finalize();
         set_fini_status(1);
     });
+
+#if defined(CODECOV) && CODECOV > 0
+    __gcov_dump();
+#endif
 }
 }  // namespace registration
 }  // namespace rocprofiler