From e3a3ea56a3c8ccaf51d84ae68bd0adc1b1d7af2d Mon Sep 17 00:00:00 2001 From: Mirza Halilcevic Date: Wed, 28 Jun 2023 06:24:12 +0000 Subject: [PATCH] EXSWHTEC-138 - Implement tests for hipGraphicsSubResourceGetMappedArray (#66) Change-Id: Ic5e4c90d2e60c5d09556be8d797aaa811f950ecc --- catch/unit/gl_interop/CMakeLists.txt | 1 + .../hipGraphicsSubResourceGetMappedArray.cc | 131 ++++++++++++++++++ 2 files changed, 132 insertions(+) create mode 100644 catch/unit/gl_interop/hipGraphicsSubResourceGetMappedArray.cc diff --git a/catch/unit/gl_interop/CMakeLists.txt b/catch/unit/gl_interop/CMakeLists.txt index a54485e3dd..5cc7a10fba 100644 --- a/catch/unit/gl_interop/CMakeLists.txt +++ b/catch/unit/gl_interop/CMakeLists.txt @@ -3,6 +3,7 @@ set(TEST_SRC hipGraphicsGLRegisterBuffer.cc hipGraphicsGLRegisterImage.cc hipGraphicsMapResources.cc + hipGraphicsSubResourceGetMappedArray.cc ) hip_add_exe_to_target(NAME GLInteropTest diff --git a/catch/unit/gl_interop/hipGraphicsSubResourceGetMappedArray.cc b/catch/unit/gl_interop/hipGraphicsSubResourceGetMappedArray.cc new file mode 100644 index 0000000000..c5c5136034 --- /dev/null +++ b/catch/unit/gl_interop/hipGraphicsSubResourceGetMappedArray.cc @@ -0,0 +1,131 @@ +/* +Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved. + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in +all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN +THE SOFTWARE. +*/ + +#include +#include + +#include "gl_interop_common.hh" + +TEST_CASE("Unit_hipGraphicsSubResourceGetMappedArray_Positive_Basic") { + GLContextScopeGuard gl_context; + + GLImageObject tex; + + hipGraphicsResource* tex_resource; + + HIP_CHECK( + hipGraphicsGLRegisterImage(&tex_resource, tex, GL_TEXTURE_2D, hipGraphicsRegisterFlagsNone)); + + HIP_CHECK(hipGraphicsMapResources(1, &tex_resource, 0)); + + hipArray* image_devptr = nullptr; + HIP_CHECK(hipGraphicsSubResourceGetMappedArray(&image_devptr, tex_resource, 0, 0)); + + REQUIRE(image_devptr != nullptr); + + HIP_CHECK(hipGraphicsUnmapResources(1, &tex_resource, 0)); + + HIP_CHECK(hipGraphicsUnregisterResource(tex_resource)); +} + +TEST_CASE("Unit_hipGraphicsSubResourceGetMappedArray_Negative_Parameters") { + GLContextScopeGuard gl_context; + + GLImageObject tex; + + hipGraphicsResource* tex_resource; + + HIP_CHECK( + hipGraphicsGLRegisterImage(&tex_resource, tex, GL_TEXTURE_2D, hipGraphicsRegisterFlagsNone)); + + HIP_CHECK(hipGraphicsMapResources(1, &tex_resource, 0)); + + hipArray* image_devptr = nullptr; + + SECTION("array == nullptr") { + HIP_CHECK(hipGraphicsSubResourceGetMappedArray(nullptr, tex_resource, 0, 0)); + } + + SECTION("non-texture resource") { + GLBufferObject vbo; + hipGraphicsResource* vbo_resource; + + HIP_CHECK(hipGraphicsGLRegisterBuffer(&vbo_resource, vbo, hipGraphicsRegisterFlagsNone)); + HIP_CHECK(hipGraphicsMapResources(1, &vbo_resource, 0)); + + HIP_CHECK_ERROR(hipGraphicsSubResourceGetMappedArray(&image_devptr, vbo_resource, 0, 0), + hipErrorNotMappedAsArray); + + HIP_CHECK(hipGraphicsUnmapResources(1, &vbo_resource, 0)); + HIP_CHECK(hipGraphicsUnregisterResource(vbo_resource)); + } + + SECTION("unregistered resource") { + hipGraphicsResource* unregistered_resource; + HIP_CHECK(hipGraphicsGLRegisterImage(&unregistered_resource, tex, GL_TEXTURE_2D, + hipGraphicsRegisterFlagsNone)); + HIP_CHECK(hipGraphicsUnregisterResource(unregistered_resource)); + HIP_CHECK_ERROR( + hipGraphicsSubResourceGetMappedArray(&image_devptr, unregistered_resource, 0, 0), + hipErrorContextIsDestroyed); + } + + SECTION("not mapped resource") { + hipGraphicsResource* not_mapped_resource; + HIP_CHECK(hipGraphicsGLRegisterImage(¬_mapped_resource, tex, GL_TEXTURE_2D, + hipGraphicsRegisterFlagsNone)); + HIP_CHECK_ERROR(hipGraphicsSubResourceGetMappedArray(&image_devptr, not_mapped_resource, 0, 0), + hipErrorNotMapped); + HIP_CHECK(hipGraphicsUnregisterResource(not_mapped_resource)); + } + + SECTION("unmapped resource") { + hipGraphicsResource* unmapped_resource; + + HIP_CHECK(hipGraphicsGLRegisterImage(&unmapped_resource, tex, GL_TEXTURE_2D, + hipGraphicsRegisterFlagsNone)); + + HIP_CHECK(hipGraphicsMapResources(1, &unmapped_resource, 0)); + HIP_CHECK(hipGraphicsUnmapResources(1, &unmapped_resource, 0)); + + HIP_CHECK_ERROR(hipGraphicsSubResourceGetMappedArray(&image_devptr, unmapped_resource, 0, 0), + hipErrorNotMapped); + + HIP_CHECK(hipGraphicsUnregisterResource(unmapped_resource)); + } + + SECTION("invalid arrayIndex") { + HIP_CHECK_ERROR(hipGraphicsSubResourceGetMappedArray(&image_devptr, tex_resource, + std::numeric_limits::max(), 0), + hipErrorInvalidValue); + } + + SECTION("invalid mipLevel") { + HIP_CHECK_ERROR(hipGraphicsSubResourceGetMappedArray(&image_devptr, tex_resource, 0, + std::numeric_limits::max()), + hipErrorInvalidValue); + } + + HIP_CHECK(hipGraphicsUnmapResources(1, &tex_resource, 0)); + + HIP_CHECK(hipGraphicsUnregisterResource(tex_resource)); +} \ No newline at end of file