From e4077f827cdb83e2a89573caf25337c56e01be17 Mon Sep 17 00:00:00 2001 From: Ioannis Assiouras Date: Thu, 18 Jul 2024 15:14:43 +0100 Subject: [PATCH] SWDEV-474345 - Address potential segmentation fault in Print_Out_Attributes test Change-Id: Ie507d3da66d9644eea56a510e76564af1970e2c0 --- catch/hipTestMain/config/config_amd_linux | 1 - catch/unit/device/hipGetDeviceAttribute.cc | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/catch/hipTestMain/config/config_amd_linux b/catch/hipTestMain/config/config_amd_linux index 9f829a2ddc..4ed6a38bbd 100644 --- a/catch/hipTestMain/config/config_amd_linux +++ b/catch/hipTestMain/config/config_amd_linux @@ -761,7 +761,6 @@ "=== SWDEV-432554:Below test failed in stress test on 10/11/23 ===", "Unit_hipMemcpy3DAsync_Positive_Basic", "Unit_hipDrvMemcpy3DAsync_Positive_Basic", - "Print_Out_Attributes", "Unit_hipExtGetLinkTypeAndHopCount_Positive_Basic", "Unit_hipClock64_Positive_Basic", "Unit_hipClock_Positive_Basic", diff --git a/catch/unit/device/hipGetDeviceAttribute.cc b/catch/unit/device/hipGetDeviceAttribute.cc index 2fd3a425da..e99fb1ee7f 100644 --- a/catch/unit/device/hipGetDeviceAttribute.cc +++ b/catch/unit/device/hipGetDeviceAttribute.cc @@ -452,10 +452,11 @@ constexpr int kW = 60; } // anonymous namespace template void printAttributes(const AttributeToStringMap& attributes, const int device) { - int attribute_value; hipError_t ret_val; for (const auto& attribute : attributes) { - ret_val = hipDeviceGetAttribute(&attribute_value, attribute.first, device); + int64_t attribute_value = 0; + ret_val = hipDeviceGetAttribute(reinterpret_cast(&attribute_value), + attribute.first, device); std::cout << std::setw(kW) << std::string(attribute.second).append(": "); if (ret_val == hipSuccess) std::cout << attribute_value << "\n";