all_reduce LL/LL128 and Ring/Tree multi-node tuning for MI300 (#1627)

* Enabling LL128 by default on MI300

* Add missing CUDACHECK

* Adjust BW correction factors to fix the Tree->Ring switching point

* Refactor and add ll128 AR logarithmic factor to tuning models

* Move RCCL tuning changes to a separate file 

* Use enum for tunable indexing

* Use explicit indexing in tuning models to avoid mismatch issues

* Place rcclGetSizePerRank in a function

* Remove HIP ifdef for rccl-only call

---------

Co-authored-by: Mustafa Abduljabbar <mustafa.abduljabbar@amd.com>

src/include/comm.h

@@ -19,6 +19,7 @@
 #include "graph.h"
 #include "nvmlwrap.h"
 #include "profiler.h"
+#include "rccl_common.h"
 
 #if defined(__HIP_PLATFORM_AMD__) || defined(__HIPCC__)
 #define HIPRT_CB
@@ -517,7 +518,7 @@ struct ncclComm {
   float bandwidths[NCCL_NUM_FUNCTIONS][NCCL_NUM_ALGORITHMS][NCCL_NUM_PROTOCOLS];
   float ringbdw[NCCL_NUM_FUNCTIONS][NCCL_NUM_PROTOCOLS];
   int maxThreads[NCCL_NUM_ALGORITHMS][NCCL_NUM_PROTOCOLS];
-  uint64_t minMaxLLRange[NCCL_NUM_FUNCTIONS][NCCL_NUM_PROTOCOLS - 1][2];
+  uint64_t minMaxLLRange[RCCL_TUNABLE_COLLS][NCCL_NUM_PROTOCOLS - 1][RCCL_PROTOCOL_ENTRY_SIZE];
 
   /* This attribute can indicate the states of communicators and return code of
   * asynchronous NCCL operations. */
@@ -710,7 +711,7 @@ inline ncclResult_t ncclCommPollEventCallbacks(struct ncclComm *comm) {
     }
   }
 finish:
-  cudaThreadExchangeStreamCaptureMode(&mode);
+  CUDACHECK(cudaThreadExchangeStreamCaptureMode(&mode));
   return ncclSuccess;
 }
 

src/include/rccl_common.h

@@ -0,0 +1,64 @@
+/*
+Copyright (c) 2025 Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#ifndef RCCL_COMMON_H_
+#define RCCL_COMMON_H_
+#include "nccl_common.h"
+
+typedef enum RcclTunableColls {
+  RCCL_UNSUPPORTED_TUNABLE = -1,
+  RCCL_RS_TUNABLE = 0,    // reduce_scatter index
+  RCCL_AG_TUNABLE = 1,    // all_gather index
+  RCCL_AR_TUNABLE = 2,    // all_reduce index
+  RCCL_RE_TUNABLE = 3,    // reduce index
+  RCCL_TUNABLE_COLLS = 4  // LL/LL64/LL128 tunable collectives count
+} rcclTunableIndex_t;
+
+#define RCCL_LL_LIMITS_UNDEFINED 0
+#define RCCL_PROTOCOL_ENTRY_SIZE 3
+#define RCCL_PROTOCOL_MIN_IDX 0
+#define RCCL_PROTOCOL_MAX_IDX 1
+#define RCCL_PROTOCOL_FACTOR_IDX 2
+
+inline rcclTunableIndex_t rcclGetTunableIndex(ncclFunc_t const& func) {
+  switch (func) {
+    case ncclFuncReduceScatter:
+      return RCCL_RS_TUNABLE;
+    case ncclFuncAllGather:
+      return RCCL_AG_TUNABLE;
+    case ncclFuncAllReduce:
+      return RCCL_AR_TUNABLE;
+    case ncclFuncReduce:
+      return RCCL_RE_TUNABLE;
+    default:
+      return RCCL_UNSUPPORTED_TUNABLE; // Invalid or unsupported function
+  }
+}
+
+inline size_t rcclGetSizePerRank(ncclFunc_t const& func, size_t const& nBytes, int const& nRanks) {
+  // Normalize the comparison to sizePerRank as this is essentially what matters in determining protocol choice for the impacted collectives
+  // For AG, this is the send size per rank
+  // For RS, this is the recv size per rank
+  // For AR, this is the send/recv size per rank
+  return (func == ncclFuncReduceScatter || func == ncclFuncAllGather) ? nBytes / nRanks : nBytes;
+}
+void rcclUpdateCollectiveProtocol(struct ncclComm* comm, size_t const& nBytes, struct ncclTaskColl* info);
+#endif