From e4ef99f52a9bca5ef7217f60d9580ddd750a856f Mon Sep 17 00:00:00 2001 From: ROCm CI Service Account <66695075+rocm-ci@users.noreply.github.com> Date: Mon, 6 Mar 2023 19:34:49 +0530 Subject: [PATCH] SWDEV-364620 - fix Unit_hipGraphAddHostNode_ClonedGraphwithHostNode by adding dependencies for cloned graph correctly (#186) Change-Id: I87bbf2536ccf5aa896478bfdca0d7d76fd5b4a74 --- catch/unit/graph/hipGraphAddHostNode.cc | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/catch/unit/graph/hipGraphAddHostNode.cc b/catch/unit/graph/hipGraphAddHostNode.cc index f66e813352..9da6e3b223 100644 --- a/catch/unit/graph/hipGraphAddHostNode.cc +++ b/catch/unit/graph/hipGraphAddHostNode.cc @@ -136,6 +136,8 @@ TEST_CASE("Unit_hipGraphAddHostNode_ClonedGraphwithHostNode") { HIP_CHECK(hipGraphCreate(&graph, 0)); hipGraphNode_t memcpyH2D_A, memcpyH2D_C, memcpyD2H_AC; + hipGraphNode_t cloned_memcpyH2D_A, cloned_memcpyH2D_C, + cloned_memcpyD2H_AC; hipStream_t streamForGraph; HIP_CHECK(hipStreamCreate(&streamForGraph)); HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpyH2D_A, graph, nullptr, @@ -151,6 +153,13 @@ TEST_CASE("Unit_hipGraphAddHostNode_ClonedGraphwithHostNode") { hipGraph_t clonedgraph; HIP_CHECK(hipGraphClone(&clonedgraph, graph)); + HIP_CHECK(hipGraphNodeFindInClone(&cloned_memcpyH2D_A, memcpyH2D_A, + clonedgraph)); + HIP_CHECK(hipGraphNodeFindInClone(&cloned_memcpyH2D_C, memcpyH2D_C, + clonedgraph)); + HIP_CHECK(hipGraphNodeFindInClone(&cloned_memcpyD2H_AC, memcpyD2H_AC, + clonedgraph)); + hipGraphNode_t hostNode; hipHostNodeParams hostParams = {0, 0}; hostParams.fn = callbackfunc; @@ -159,10 +168,12 @@ TEST_CASE("Unit_hipGraphAddHostNode_ClonedGraphwithHostNode") { nullptr, 0, &hostParams)); - HIP_CHECK(hipGraphAddDependencies(graph, &memcpyH2D_A, - &memcpyD2H_AC, 1)); - HIP_CHECK(hipGraphAddDependencies(graph, &memcpyH2D_C, - &memcpyD2H_AC, 1)); + HIP_CHECK(hipGraphAddDependencies(clonedgraph, &cloned_memcpyH2D_A, + &cloned_memcpyD2H_AC, 1)); + HIP_CHECK(hipGraphAddDependencies(clonedgraph, &cloned_memcpyH2D_C, + &cloned_memcpyD2H_AC, 1)); + HIP_CHECK(hipGraphAddDependencies(clonedgraph, &cloned_memcpyD2H_AC, + &hostNode, 1)); // Instantiate and launch the cloned graph HIP_CHECK(hipGraphInstantiate(&graphExec, clonedgraph, nullptr, nullptr, 0));