AI/rocm-systems
2
0
Fork 0
程式碼 問題 合併請求 Actions 套件 專案 版本發布 Wiki 動態

Evaluation portion for metrics (#123)

瀏覽代碼 
* EvaluateAST and validation of RawAST

* Adding MetricDimension class and concepts

* set_dimensions() and improved ValidateRawAST()

* source formatting (clang-format v11) (#124)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Addressing 1st round of review comments

* Modified the parser production rules to support the right syntax for REDUCE and SELECT derived metric expressions

* changes to raw_ast.hpp and fmt::format()

* Parser tests updated to support corrected REDUCE and SELECT syntax

* changes to EvaluateAST::set_dimensions() and other dimension related code changes

* Added a test for EvaluateAST::evaluate() to test basic arithmetic on EvaluateAST

* Format source code (via clang-format v11) on sauverma/evaluate-ast (#146)

* source formatting (clang-format v11)

* Add dimension information to counter record

Restructures counter records to have the following design:

rocprofiler_record_id_t which is an int64_t that encodes
both the counter id and dimension information for the
record. The first 16 bits are reserved for the counter id while
the last 48 are split among the dimensions specified in
rocprofiler_dimension_t (currently 8 bits per dimension).
Each of the 8 bits for the dimension stores the dimension
value for that dimension for this record (i.e. a value of 8
on dimension XCC would denote XCC[8] for the counter). The
split among the dimensions will automatically adjust as
dimensions are added or removed.

The record also contains a union of {int64_t hw_counter, double
derived_counter} to specify the value of the record at
rocprofiler_record_id_t. int64_t denotes a physical hardware
counter that has integer types while the double is used for derived
counters (which type this counters values are needs to be queried
separately).

* Integration of new id type + other fixes

---------

Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>

* Fixed sissues with reduce() implementation and added a test for reduce()

* Updated parser syntax for reduce() and updated the parser test. Disabled the test for select()

* Build warning fixes

* Modifications to support fetching xcc/etc info from agent

* Initial plumbing working for single counters, cleanup+tests still needed

* Remove string comparison from reduce ops

* source formatting (clang-format v11) (#163)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* cmake formatting (cmake-format) (#164)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* source formatting (clang-format v11) (#171)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Merged with master

* source formatting (clang-format v11) (#172)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* source formatting (clang-format v11) (#173)

Co-authored-by: bwelton <bwelton@users.noreply.github.com>

* Test fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: 63775f241a]
此提交包含在：
Saurabh Verma
2023-11-03 23:10:40 -05:00
提交者 GitHub
父節點 370a86830b
當前提交 e8fa4d3873
共有 30 個檔案被更改，包括 1960 行新增 和 973 行删除
下載 Patch 檔 下載差異檔 展開所有檔案 折疊所有檔案
projects/rocprofiler-sdk/source/lib/rocprofiler/counters/parser/parser.y
+28 -28
查看文件
@@ -33,6 +33,7 @@ void yyerror(rocprofiler::counters::RawAST**, const char *s) { LOG(ERROR) << s;
/*declare data types*/
%union {
RawAST* a; /* For ast node */
LinkedList* ll; /* For linked list node */
int64_t d;
char* s;
}
@@ -43,6 +44,7 @@ void yyerror(rocprofiler::counters::RawAST**, const char *s) { LOG(ERROR) << s;
%type <a> exp /* set data type for expressions */
%type <s> NAME
%type <d> NUMBER
%type <ll> reduce_dim_args select_dim_args
%nonassoc LOWER_THAN_ELSE
%nonassoc ELSE
@@ -54,14 +56,6 @@ void yyerror(rocprofiler::counters::RawAST**, const char *s) { LOG(ERROR) << s;
top:
exp { *result = $1;};
// line: /* nothing */
// | line exp EOL {
// // TODO
// //printf("= %g\n", eval($2)); //evaluate and print the AST
// //printf("> ");
// }
// | line EOL { printf("> "); } /* blank line or a comment */
// ;
exp: NUMBER { $$ = new RawAST(NUMBER_NODE, $1); }
| exp ADD exp { $$ = new RawAST(ADDITION_NODE, {$1, $3}); }
@@ -69,35 +63,41 @@ exp: NUMBER { $$ = new RawAST(NUMBER_NODE, $1); }
| exp MUL exp { $$ = new RawAST(MULTIPLY_NODE, {$1, $3}); }
| exp DIV exp { $$ = new RawAST(DIVIDE_NODE, {$1, $3}); }
| OP exp CP { $$ = $2; }
| O_SQ exp COLON exp C_SQ { $$ = new RawAST(RANGE_NODE, {$2, $4}); }
| NAME { $$ = new RawAST(REFERENCE_NODE, $1);
free($1);
}
| NAME EQUALS exp { $$ = new RawAST(REFERENCE_SET, $1, $3);
free($1);
}
| NAME EQUALS exp CM exp { $$ = new RawAST(REFERENCE_SET, $1, $3, $5);
free($1);
}
| REDUCE OP exp CM NAME CP { $$ = new RawAST(REDUCE_NODE, $3, $5);
| REDUCE OP exp CM NAME CP {
$$ = new RawAST(REDUCE_NODE, $3, $5, NULL);
free($5);
}
| REDUCE OP exp CM NAME CM exp CP { $$ = new RawAST(REDUCE_NODE, $3, $5, $7);
| REDUCE OP exp CM NAME CM O_SQ reduce_dim_args C_SQ CP {
$$ = new RawAST(REDUCE_NODE, $3, $5, $8);
free($5);
}
| SELECT OP exp CM NAME CP { $$ = new RawAST(SELECT_NODE, $3, $5);
free($5);
| SELECT OP exp CM O_SQ select_dim_args C_SQ CP {
$$ = new RawAST(SELECT_NODE, $3, $6);
}
| SELECT OP exp CM NAME CM exp CP { $$ = new RawAST(SELECT_NODE, $3, $5, $7);
free($5);
}
// | NAME O_SQ POS_INTEGER C_SQ { $$ = create_index_access_node($1, $3); }
;
%%
// void yyerror(char const *s)
// {
// fprintf(stderr, "check error saurabh: %s\n", s);
// }
reduce_dim_args: NAME { $$ = new LinkedList($1, NULL);
free($1);
}
| NAME CM reduce_dim_args { $$ = new LinkedList($1, $3);
free($1);
}
;
select_dim_args: NAME EQUALS NUMBER { $$ = new LinkedList($1, $3, NULL);
free($1);
}
| NAME EQUALS NUMBER CM select_dim_args { $$ = new LinkedList($1, $3, $5);
free($1);
}
;
%%