From 13301398d8d521a7e2fadae78d187d231a5d1b8d Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu" <yaxun.liu@amd.com>
Date: Fri, 19 Jul 2019 11:38:32 -0400
Subject: [PATCH 1/3] Temporarily disable maxTexture1D in hipDeviceProp_t for
 VDI (#1237)

---
 hipamd/include/hip/hip_runtime_api.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hipamd/include/hip/hip_runtime_api.h b/hipamd/include/hip/hip_runtime_api.h
index e6cdfdd304..637de712b3 100644
--- a/hipamd/include/hip/hip_runtime_api.h
+++ b/hipamd/include/hip/hip_runtime_api.h
@@ -117,9 +117,11 @@ typedef struct hipDeviceProp_t {
     int integrated;            ///< APU vs dGPU
     int cooperativeLaunch;            ///< HIP device supports cooperative launch
     int cooperativeMultiDeviceLaunch; ///< HIP device supports cooperative launch on multiple devices
+#if !__HIP_VDI__ // Temporarily disable the following three new fields for HIP/VDI runtime
     int maxTexture1D;          ///< Maximum number of elements in 1D images
     int maxTexture2D[2];       ///< Maximum dimensions (width, height) of 2D images, in image elements
     int maxTexture3D[3];       ///< Maximum dimensions (width, height, depth) of 3D images, in image elements
+#endif
 } hipDeviceProp_t;
 
 

From 14aad50e07571608c02d868142b52aa87d945876 Mon Sep 17 00:00:00 2001
From: Evgeny Mankov <evgeny.mankov@gmail.com>
Date: Fri, 19 Jul 2019 20:23:17 +0300
Subject: [PATCH 2/3] [HIPIFY][#941][fix] Workaround for an assert on forbidden
 option "--"

+ Fixes the following assert in debug version:
Assertion failed: (S.empty() || S[0] != '-') && "Option can't start with '-", file C:\GIT\LLVM\trunk-for-submits\llvm-project\llvm\lib\Support\CommandLine.cpp, line 440
+ DashDash option left declared in order to be listed in help.
---
 hipamd/hipify-clang/src/ArgParse.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hipamd/hipify-clang/src/ArgParse.cpp b/hipamd/hipify-clang/src/ArgParse.cpp
index 60b0dd390b..8a5a5b6e6c 100644
--- a/hipamd/hipify-clang/src/ArgParse.cpp
+++ b/hipamd/hipify-clang/src/ArgParse.cpp
@@ -34,12 +34,12 @@ cl::opt<std::string> OutputDir("o-dir",
   cl::value_desc("directory"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt <bool> GeneratePerl("perl",
+cl::opt<bool> GeneratePerl("perl",
   cl::desc("Generate hipify-perl"),
   cl::value_desc("perl"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt <bool> GeneratePython("python",
+cl::opt<bool> GeneratePython("python",
   cl::desc("Generate hipify-python"),
   cl::value_desc("python"),
   cl::cat(ToolTemplateCategory));
@@ -69,17 +69,17 @@ cl::opt<std::string> CudaPath("cuda-path",
   cl::value_desc("directory"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt <bool> SaveTemps("save-temps",
+cl::opt<bool> SaveTemps("save-temps",
   cl::desc("Save temporary files"),
   cl::value_desc("save-temps"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt <bool> Verbose("v",
+cl::opt<bool> Verbose("v",
   cl::desc("Show commands to run and use verbose output"),
   cl::value_desc("v"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt <bool> TranslateToRoc("roc",
+cl::opt<bool> TranslateToRoc("roc",
   cl::desc("Translate to roc instead of hip where it is possible"),
   cl::value_desc("roc"),
   cl::cat(ToolTemplateCategory));
@@ -119,9 +119,9 @@ cl::opt<bool> Examine("examine",
   cl::value_desc("examine"),
   cl::cat(ToolTemplateCategory));
 
-cl::opt<bool> DashDash("-",
+cl::opt<bool> DashDash("  ",
   cl::desc("Separator between hipify-clang and clang options;\ndon't specify if there are no clang options"),
-  cl::value_desc("--"),
+  cl::ValueDisallowed,
   cl::cat(ToolTemplateCategory));
 
 cl::list<std::string> IncludeDirs("I",

From 6d61e02acbd33f1492416c524df642b4745abb05 Mon Sep 17 00:00:00 2001
From: Evgeny Mankov <evgeny.mankov@gmail.com>
Date: Mon, 22 Jul 2019 22:13:54 +0300
Subject: [PATCH 3/3] [HIPIFY][#1239] Fix an assert

---
 hipamd/hipify-clang/src/HipifyAction.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hipamd/hipify-clang/src/HipifyAction.cpp b/hipamd/hipify-clang/src/HipifyAction.cpp
index 241ca7ecae..d6fe9b88e5 100644
--- a/hipamd/hipify-clang/src/HipifyAction.cpp
+++ b/hipamd/hipify-clang/src/HipifyAction.cpp
@@ -267,11 +267,12 @@ void HipifyAction::PragmaDirective(clang::SourceLocation Loc, clang::PragmaIntro
     return;
   }
   clang::Preprocessor& PP = getCompilerInstance().getPreprocessor();
-  const clang::Token tok = PP.LookAhead(0);
+  clang::Token tok;
+  PP.Lex(tok);
   StringRef Text(SM.getCharacterData(tok.getLocation()), tok.getLength());
   if (Text == "once") {
     pragmaOnce = true;
-    pragmaOnceLoc = PP.LookAhead(1).getLocation();
+    pragmaOnceLoc = tok.getEndLoc();
   }
 }