From ec9f4720bca16a4cfd26d2f0d599b8c8aeaeb227 Mon Sep 17 00:00:00 2001 From: Julia Jiang Date: Thu, 1 Apr 2021 18:40:43 -0400 Subject: [PATCH] SWDEV-270961 - update HIP documents Change-Id: I5168d83a124e9c7d856fb7a46d9960d9f99143c6 [ROCm/hip commit: d8f123eed7f9044439f463522bf0af0e2ae85916] --- projects/hip/INSTALL.md | 12 ++++++------ projects/hip/docs/markdown/hip_kernel_language.md | 2 +- projects/hip/samples/0_Intro/square/Makefile | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/projects/hip/INSTALL.md b/projects/hip/INSTALL.md index 17f3c553f2..5136004918 100644 --- a/projects/hip/INSTALL.md +++ b/projects/hip/INSTALL.md @@ -35,7 +35,7 @@ HIP-Clang is the compiler for compiling HIP programs on AMD platform. HIP-Clang can be built manually: ``` -git clone -b rocm-4.2.x https://github.com/RadeonOpenCompute/llvm-project.git +git clone -b rocm-4.3.x https://github.com/RadeonOpenCompute/llvm-project.git cd llvm-project mkdir -p build && cd build cmake -DCMAKE_INSTALL_PREFIX=/opt/rocm/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=1 -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86" -DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt" ../llvm @@ -46,7 +46,7 @@ sudo make install Rocm device library can be manually built as following, ``` export PATH=/opt/rocm/llvm/bin:$PATH -git clone -b rocm-4.2.x https://github.com/RadeonOpenCompute/ROCm-Device-Libs.git +git clone -b rocm-4.3.x https://github.com/RadeonOpenCompute/ROCm-Device-Libs.git cd ROCm-Device-Libs mkdir -p build && cd build CC=clang CXX=clang++ cmake -DLLVM_DIR=/opt/rocm/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_WERROR=1 -DLLVM_ENABLE_ASSERTIONS=1 -DCMAKE_INSTALL_PREFIX=/opt/rocm .. @@ -77,9 +77,9 @@ ROCclr is defined on AMD platform that HIP use Radeon Open Compute Common Langua See https://github.com/ROCm-Developer-Tools/ROCclr ``` -git clone -b rocm-4.2.x https://github.com/ROCm-Developer-Tools/ROCclr.git +git clone -b rocm-4.3.x https://github.com/ROCm-Developer-Tools/ROCclr.git export ROCclr_DIR="$(readlink -f ROCclr)" -git clone -b rocm-4.2.x https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime.git +git clone -b rocm-4.3.x https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime.git export OPENCL_DIR="$(readlink -f ROCm-OpenCL-Runtime)" cd "$ROCclr_DIR" mkdir -p build;cd build @@ -91,7 +91,7 @@ sudo make install ## Build HIP ``` -git clone -b rocm-4.2.x https://github.com/ROCm-Developer-Tools/HIP.git +git clone -b rocm-4.3.x https://github.com/ROCm-Developer-Tools/HIP.git export HIP_DIR="$(readlink -f HIP)" cd "$HIP_DIR" mkdir -p build; cd build @@ -120,5 +120,5 @@ Run hipconfig (instructions below assume default installation path) : ``` -Compile and run the [square sample](https://github.com/ROCm-Developer-Tools/HIP/tree/master/samples/0_Intro/square). +Compile and run the [square sample](https://github.com/ROCm-Developer-Tools/HIP/tree/main/samples/0_Intro/square). diff --git a/projects/hip/docs/markdown/hip_kernel_language.md b/projects/hip/docs/markdown/hip_kernel_language.md index 761f0d48c0..f721ca068f 100644 --- a/projects/hip/docs/markdown/hip_kernel_language.md +++ b/projects/hip/docs/markdown/hip_kernel_language.md @@ -493,7 +493,7 @@ Following is the list of supported floating-point intrinsics. Note that intrinsi | double __dsqrt_rn ( double x )
Compute `√x` in round-to-nearest-even mode. | ## Texture Functions -Texture functions are not supported. +The supported Texture functions are listed in header files "texture_functions.h"(https://github.com/ROCm-Developer-Tools/HIP/blob/main/include/hip/hcc_detail/texture_functions.h) and"texture_indirect_functions.h" (https://github.com/ROCm-Developer-Tools/HIP/blob/main/include/hip/hcc_detail/texture_indirect_functions.h). ## Surface Functions Surface functions are not supported. diff --git a/projects/hip/samples/0_Intro/square/Makefile b/projects/hip/samples/0_Intro/square/Makefile index 77d2882bed..cd395bc2a0 100644 --- a/projects/hip/samples/0_Intro/square/Makefile +++ b/projects/hip/samples/0_Intro/square/Makefile @@ -25,7 +25,7 @@ endif HIP_PLATFORM=$(shell $(HIP_PATH)/bin/hipconfig --platform) HIPCC=$(HIP_PATH)/bin/hipcc -ifeq (${HIP_PLATFORM}, nvcc) +ifeq (${HIP_PLATFORM}, nvidia) SOURCES=square.cu else SOURCES=square.cpp