Add rocmtools support

This commit adds integration with ROCmTools

Additional changes:
- Fix DEB and RPM installation issue when systemd is not present
- Fix typos in rdc.h
- Wrap negative values in parentheses in rdc.h
- CMAKE: Improve rocm_smi searching
- README: Improve formatting, add info about ROCmTools

Metrics added: 700-714
Metrics can be listed with `rdci dmon --list-all`
Majority of the metrics are only supported by Instict (MI) series GPUs
700 RDC_FI_PROF_ELAPSED_CYCLES should be available on most devices
See README for more information

Change-Id: I907d3eacdc92fc5588ca6c76c2fa1ce0ad900770
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 861a843ed7]

projects/rdc/include/rdc_lib/impl/RdcModuleMgrImpl.h

@@ -23,21 +23,24 @@ THE SOFTWARE.
 #define INCLUDE_RDC_LIB_IMPL_RDCMODULEMGRIMPL_H_
 
 #include <memory>
-#include "rdc_lib/RdcModuleMgr.h"
+
 #include "rdc_lib/RdcMetricFetcher.h"
+#include "rdc_lib/RdcModuleMgr.h"
 #include "rdc_lib/RdcTelemetry.h"
 #include "rdc_lib/impl/RdcRasLib.h"
-#include "rdc_lib/impl/RdcSmiLib.h"
+#include "rdc_lib/impl/RdcRocpLib.h"
 #include "rdc_lib/impl/RdcRocrLib.h"
+#include "rdc_lib/impl/RdcSmiLib.h"
 
 namespace amd {
 namespace rdc {
 
-class RdcModuleMgrImpl: public RdcModuleMgr {
+class RdcModuleMgrImpl : public RdcModuleMgr {
  public:
     RdcTelemetryPtr get_telemetry_module() override;
     RdcDiagnosticPtr get_diagnostic_module() override;
     explicit RdcModuleMgrImpl(const RdcMetricFetcherPtr& fetcher);
+
  private:
     //  Function module
     RdcTelemetryPtr rdc_telemetry_module_;
@@ -48,10 +51,10 @@ class RdcModuleMgrImpl: public RdcModuleMgr {
     RdcSmiLibPtr smi_lib_;
     RdcMetricFetcherPtr fetcher_;
     RdcRocrLibPtr rocr_lib_;
+    RdcRocpLibPtr rocp_lib_;
 };
 
 }  // namespace rdc
 }  // namespace amd
 
-
 #endif  // INCLUDE_RDC_LIB_IMPL_RDCMODULEMGRIMPL_H_

projects/rdc/include/rdc_lib/impl/RdcRocpLib.h

@@ -0,0 +1,92 @@
+/*
+Copyright (c) 2022 - present Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#ifndef INCLUDE_RDC_LIB_IMPL_RDCROCPLIB_H_
+#define INCLUDE_RDC_LIB_IMPL_RDCROCPLIB_H_
+
+#include <cstdint>
+#include <memory>
+#include <vector>
+
+#include "rdc_lib/RdcLibraryLoader.h"
+#include "rdc_lib/RdcTelemetry.h"
+
+namespace amd {
+namespace rdc {
+
+class RdcRocpLib : public RdcTelemetry {
+ public:
+    /* Telemetry */
+
+    // get support field ids
+    rdc_status_t rdc_telemetry_fields_query(
+        uint32_t field_ids[MAX_NUM_FIELDS],
+        uint32_t* field_count) override;
+
+    // Fetch
+    rdc_status_t rdc_telemetry_fields_value_get(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count,
+        rdc_field_value_f callback,
+        void* user_data) override;
+
+    rdc_status_t rdc_telemetry_fields_watch(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count) override;
+
+    rdc_status_t rdc_telemetry_fields_unwatch(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count) override;
+
+    uint64_t get_profiler_version();
+
+    explicit RdcRocpLib(const char* lib_name);
+
+    ~RdcRocpLib();
+
+ private:
+    RdcLibraryLoader lib_loader_;
+
+    rdc_status_t (*telemetry_fields_query_)(
+        uint32_t field_ids[MAX_NUM_FIELDS],
+        uint32_t* field_count);
+
+    rdc_status_t (*telemetry_fields_value_get_)(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count,
+        rdc_field_value_f callback,
+        void* user_data);
+
+    rdc_status_t (*telemetry_fields_watch_)(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count);
+
+    rdc_status_t (*telemetry_fields_unwatch_)(
+        rdc_gpu_field_t* fields,
+        uint32_t fields_count);
+};
+
+using RdcRocpLibPtr = std::shared_ptr<RdcRocpLib>;
+
+}  // namespace rdc
+}  // namespace amd
+
+#endif  // INCLUDE_RDC_LIB_IMPL_RDCROCPLIB_H_

projects/rdc/include/rdc_lib/impl/RdcTelemetryModule.h

@@ -29,6 +29,7 @@ THE SOFTWARE.
 #include "rdc_lib/RdcTelemetry.h"
 #include "rdc_lib/impl/RdcRasLib.h"
 #include "rdc_lib/impl/RdcSmiLib.h"
+#include "rdc_lib/impl/RdcRocpLib.h"
 #include "rdc_lib/RdcMetricFetcher.h"
 
 namespace amd {
@@ -50,7 +51,8 @@ class RdcTelemetryModule : public RdcTelemetry {
             uint32_t fields_count);
 
     RdcTelemetryModule(const RdcSmiLibPtr& smi_lib,
-            const RdcRasLibPtr& ras_module);
+            const RdcRasLibPtr& ras_module,
+            const RdcRocpLibPtr& rocp_module);
 
  private:
     //< Helper function to dispatch fields to module