diff --git a/projects/rocprofiler-compute/src/omniperf_analyze/analysis_webui.py b/projects/rocprofiler-compute/src/omniperf_analyze/analysis_webui.py index 723bf415eb..f776f80580 100644 --- a/projects/rocprofiler-compute/src/omniperf_analyze/analysis_webui.py +++ b/projects/rocprofiler-compute/src/omniperf_analyze/analysis_webui.py @@ -105,16 +105,16 @@ class webui_analysis(OmniAnalyze_Base): def generate_from_filter( disp_filt, kernel_filter, gcd_filter, norm_filt, top_n_filt, div_children ): - logging.debug("[analysis] gui normalization is ", norm_filt) + logging.debug("[analysis] gui normalization is %s" % norm_filt) base_data = self.initalize_runs() # Re-initalizes everything panel_configs = copy.deepcopy(arch_configs.panel_configs) # Generate original raw df base_data[base_run].raw_pmc = file_io.create_df_pmc(self.dest_dir, self.get_args().verbose) - logging.debug("[analysis] gui dispatch filter is ", disp_filt) - logging.debug("[analysis] gui kernel filter is ", kernel_filter) - logging.debug("[analysis] gui gpu filter is ", gcd_filter) - logging.debug("[analysis] gui top-n filter is ", top_n_filt) + logging.debug("[analysis] gui dispatch filter is %s" % disp_filt) + logging.debug("[analysis] gui kernel filter is %s" % kernel_filter) + logging.debug("[analysis] gui gpu filter is %s" % gcd_filter) + logging.debug("[analysis] gui top-n filter is %s" % top_n_filt) base_data[base_run].filter_kernel_ids = kernel_filter base_data[base_run].filter_gpu_ids = gcd_filter base_data[base_run].filter_dispatch_ids = disp_filt diff --git a/projects/rocprofiler-compute/src/roofline.py b/projects/rocprofiler-compute/src/roofline.py index 51ec17f654..051bf51ed9 100644 --- a/projects/rocprofiler-compute/src/roofline.py +++ b/projects/rocprofiler-compute/src/roofline.py @@ -60,7 +60,7 @@ class Roofline: if hasattr(self.__args, 'mem_level') and self.__args.mem_level != "ALL": self.__run_parameters['mem_level'] = self.__args.mem_level if hasattr(self.__args, 'sort') and self.__args.sort != "ALL": - self.__run_parameters['sort_type'] = self.__args.mem_level + self.__run_parameters['sort_type'] = self.__args.sort self.validate_parameters() @@ -84,12 +84,12 @@ class Roofline: """Generate a set of empirical roofline plots given a directory containing required profiling and benchmarking data """ # Create arithmetic intensity data that will populate the roofline model - logging.debug("[roofline] Path: ", self.__run_parameters['path_to_dir']) + logging.debug("[roofline] Path: %s" % self.__run_parameters['path_to_dir']) self.__ai_data = calc_ai(self.__run_parameters['sort_type'], ret_df) logging.debug("[roofline] AI at each mem level:") for i in self.__ai_data: - logging.debug(i, "->", self.__ai_data[i]) + logging.debug("%s -> %s" % (i, self.__ai_data[i])) logging.debug("\n") # Generate a roofline figure for each data type @@ -188,7 +188,7 @@ class Roofline: roofline_parameters=self.__run_parameters, dtype=dtype, ) - logging.debug("[roofline] Ceiling data:\n", self.__ceiling_data) + logging.debug("[roofline] Ceiling data:\n%s" % self.__ceiling_data) ####################### # Plot ceilings diff --git a/projects/rocprofiler-compute/src/utils/roofline_calc.py b/projects/rocprofiler-compute/src/utils/roofline_calc.py index d32c99cf2b..620621def9 100644 --- a/projects/rocprofiler-compute/src/utils/roofline_calc.py +++ b/projects/rocprofiler-compute/src/utils/roofline_calc.py @@ -116,7 +116,7 @@ def calc_ceilings(roofline_parameters, dtype, benchmark_data): ) for i in range(0, len(cacheHierarchy)): # Plot BW line - logging.debug("[roofline] Current cache level is ", cacheHierarchy[i]) + logging.debug("[roofline] Current cache level is %s" % cacheHierarchy[i]) curr_bw = cacheHierarchy[i] + "Bw" peakBw = float(benchmark_data[curr_bw][roofline_parameters['device_id']]) diff --git a/projects/rocprofiler-compute/src/utils/utils.py b/projects/rocprofiler-compute/src/utils/utils.py index d032736ece..c657e1f1c4 100644 --- a/projects/rocprofiler-compute/src/utils/utils.py +++ b/projects/rocprofiler-compute/src/utils/utils.py @@ -193,7 +193,7 @@ def run_prof(fname, profiler_options, target, workload_dir): fbase = os.path.splitext(os.path.basename(fname))[0] m_specs = specs.get_machine_specs(0) - logging.debug("pmc file:", os.path.basename(fname)) + logging.debug("pmc file: %s" % str(os.path.basename(fname))) # standard rocprof options default_options = [