From eed1597e3932572bdb7dfc0b7ba78475e13f2a41 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault@amd.com>
Date: Fri, 23 Jun 2023 09:05:51 -0400
Subject: [PATCH] SWDEV-1 - Fix -Wfinal-dtor-non-final-class

rocclr/platform/external_memory.hpp:93:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
   93 |     virtual ~ExternalImage() final {}

Change-Id: I56d760fa6c08544100e3bc03d35129bd16d8a428


[ROCm/clr commit: e9750de2156bc26c16c558928ed7c7b64a4d2f93]
---
 projects/clr/rocclr/platform/external_memory.hpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/projects/clr/rocclr/platform/external_memory.hpp b/projects/clr/rocclr/platform/external_memory.hpp
index b4e57a1ebf..6bb17f24ce 100644
--- a/projects/clr/rocclr/platform/external_memory.hpp
+++ b/projects/clr/rocclr/platform/external_memory.hpp
@@ -52,7 +52,7 @@ namespace amd
     ExternalMemory::HandleType handle_type_;
   };
 
-  class ExternalBuffer : public Buffer, public ExternalMemory
+  class ExternalBuffer final : public Buffer, public ExternalMemory
   {
   protected:
     // Initializes device memory array, which is located after ExternalBuffer object in memory
@@ -69,11 +69,11 @@ namespace amd
       setInteropObj(this);
     }
 
-    virtual ~ExternalBuffer() final {}
+    virtual ~ExternalBuffer() {}
   };
 
   // to be modified once image requirments are known, for now, implement like buffer
-  class ExternalImage : public Buffer, public ExternalMemory
+  class ExternalImage final : public Buffer, public ExternalMemory
   {
   protected:
     // Initializes device memory array, which is located after ExternalImage object in memory
@@ -90,6 +90,6 @@ namespace amd
       setInteropObj(this);
     }
 
-    virtual ~ExternalImage() final {}
+    virtual ~ExternalImage() {}
   };
 }