AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-466601 - Fix invalid mem acccess in kernarg readback path

Browse Source 
Change-Id: I4654ae592adc8cf9c687136d45eb1b28d99c7ae1


[ROCm/clr commit: 055e05a12a]
This commit is contained in:
Ioannis Assiouras
2024-06-08 02:56:54 +01:00
parent 30c4d5805e
commit efba3545ca
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/hipamd/src/hip_graph_internal.cpp
+2 -2
View File
@@ -438,11 +438,11 @@ hipError_t GraphExec::CaptureAQLPackets() {
} else if (kernArgImpl == KernelArgImpl::DeviceKernelArgsReadback && } else if (kernArgImpl == KernelArgImpl::DeviceKernelArgsReadback &&
kernarg_pool_size_graph_ != 0) { kernarg_pool_size_graph_ != 0) {
address dev_ptr = kernarg_pool_graph_ + kernarg_pool_size_graph_; address dev_ptr = kernarg_pool_graph_ + kernarg_pool_size_graph_;
auto kSentinel = *reinterpret_cast<volatile int*>(dev_ptr); auto kSentinel = *reinterpret_cast<volatile address>(dev_ptr - 1);
_mm_sfence(); _mm_sfence();
*(dev_ptr - 1) = kSentinel; *(dev_ptr - 1) = kSentinel;
_mm_mfence(); _mm_mfence();
kSentinel = *reinterpret_cast<volatile int*>(dev_ptr - 1); kSentinel = *reinterpret_cast<volatile address>(dev_ptr - 1);
} }
} }
} }
projects/clr/rocclr/device/rocm/rocvirtual.cpp
+1 -1
View File
@@ -3246,7 +3246,7 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes,
_mm_sfence(); _mm_sfence();
*(argBuffer + argSize - 1) = *(parameters + argSize - 1); *(argBuffer + argSize - 1) = *(parameters + argSize - 1);
_mm_mfence(); _mm_mfence();
auto kSentinel = *reinterpret_cast<volatile address*>(argBuffer + argSize - 1); auto kSentinel = *reinterpret_cast<volatile address>(argBuffer + argSize - 1);
} }
} }
} }