diff --git a/projects/hip/include/hcc_detail/hcc_acc.h b/projects/hip/include/hcc_detail/hcc_acc.h index d0d605d1c9..371a0a23a4 100644 --- a/projects/hip/include/hcc_detail/hcc_acc.h +++ b/projects/hip/include/hcc_detail/hcc_acc.h @@ -7,11 +7,15 @@ #include /** * @brief Return hc::accelerator associated with the specified deviceId + * @return #hipSuccess, #hipErrorInvalidDevice */ hipError_t hipHccGetAccelerator(int deviceId, hc::accelerator *acc); /** * @brief Return hc::accelerator_view associated with the specified stream + * + * If stream is 0, the accelerator_view for the default stream is returned. + * @return #hipSuccess */ hipError_t hipHccGetAcceleratorView(hipStream_t stream, hc::accelerator_view **av); #endif diff --git a/projects/hip/src/hip_hcc.cpp b/projects/hip/src/hip_hcc.cpp index 0f0b03d115..f14b4612b8 100644 --- a/projects/hip/src/hip_hcc.cpp +++ b/projects/hip/src/hip_hcc.cpp @@ -1973,9 +1973,6 @@ void ihipStream_t::copyAsync(void* dst, const void* src, size_t sizeBytes, unsig //------------------------------------------------------------------------------------------------- // HCC-specific accessor functions: -/** - * @return #hipSuccess, #hipErrorInvalidDevice - */ //--- hipError_t hipHccGetAccelerator(int deviceId, hc::accelerator *acc) { @@ -1993,9 +1990,6 @@ hipError_t hipHccGetAccelerator(int deviceId, hc::accelerator *acc) } -/** - * @return #hipSuccess - */ //--- hipError_t hipHccGetAcceleratorView(hipStream_t stream, hc::accelerator_view **av) { diff --git a/projects/hip/src/hip_memory.cpp b/projects/hip/src/hip_memory.cpp index 0cc53f7754..668852bbfe 100644 --- a/projects/hip/src/hip_memory.cpp +++ b/projects/hip/src/hip_memory.cpp @@ -613,6 +613,7 @@ hipError_t hipMemcpyDtoHAsync(void* dst, hipDeviceptr_t src, size_t sizeBytes, h return ihipLogStatus(e); } +// TODO - review and optimize hipError_t hipMemcpy2D(void* dst, size_t dpitch, const void* src, size_t spitch, size_t width, size_t height, hipMemcpyKind kind) {