diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/ioctl/ioctl_adapter.cpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/ioctl/ioctl_adapter.cpp index 29ac12b3d1..580833d6ed 100644 --- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/ioctl/ioctl_adapter.cpp +++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/ioctl/ioctl_adapter.cpp @@ -168,9 +168,9 @@ ioctl_query_pc_sampling_capabilities(uint32_t kfd_gpu_id, } *size = args.num_sample_info; - return (ret == -ENOSPC) ? ROCPROFILER_IOCTL_STATUS_BUFFER_TOO_SMALL - : (ret != 0) ? ROCPROFILER_IOCTL_STATUS_ERROR - : ROCPROFILER_IOCTL_STATUS_SUCCESS; + if(ret == -ENOSPC) return ROCPROFILER_IOCTL_STATUS_BUFFER_TOO_SMALL; + + return ret != 0 ? ROCPROFILER_IOCTL_STATUS_ERROR : ROCPROFILER_IOCTL_STATUS_SUCCESS; } rocprofiler_status_t diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/utils.hpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/utils.hpp index baabebb33c..4cfd40f9d3 100644 --- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/utils.hpp +++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/pc_sampling/utils.hpp @@ -41,14 +41,14 @@ get_matching_hsa_pcs_method(rocprofiler_pc_sampling_method_t method); hsa_ven_amd_pcs_units_t get_matching_hsa_pcs_units(rocprofiler_pc_sampling_unit_t unit); -inline constexpr size_t +constexpr size_t get_hsa_pcs_latency() { // TODO: Check with David about the default value in the hsa-runtime return 1000; } -inline constexpr size_t +constexpr size_t get_hsa_pcs_buffer_size() { // TODO: Find the minimum size of all buffers and use that.