AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding pthread_join / pthread_detach to clean up pthreads to avoid leaks (#322)

Browse Source
This commit is contained in:
gilbertlee-amd
2021-02-26 16:29:55 -07:00
committed by GitHub
parent 7191d0959b
commit f4a9b9acba
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bootstrap.cc
+4 -1
View File
@@ -194,6 +194,7 @@ ncclResult_t bootstrapCreateRoot(ncclUniqueId* id, bool idFromEnv) {
rootStruct->hash = djb2Hash(id->internal);
rootStruct->listenFd = listenFd;
pthread_create(&thread, NULL, bootstrapRoot, (void *)rootStruct);
pthread_detach(thread); // [RCCL] Adding detach to properly clean up bootstrapRoot thread
// [/RCCL]
return ncclSuccess;
@@ -533,7 +534,9 @@ ncclResult_t bootstrapClose(void* commState) {
state->allocState->stop = 1;
// Join the allocThread so we catch resource leaks as being hung here
// pthread_join(state->allocThread, nullptr);
// [RCCL] Uncommenting this join to clean up the allocThread
pthread_join(state->allocThread, nullptr);
// [/RCCL]
free(state->peerCommAddresses);
free(state->peerAllocAddresses);