From f611dbd49a5d8cf17d42c4b1ef24ba4191bb7aae Mon Sep 17 00:00:00 2001 From: Grant Pinkert Date: Fri, 25 Apr 2025 06:05:21 -1000 Subject: [PATCH] Fix message size logging (#115) Previously, the logger was logging the number of expected bytes a node was to recieve. This differs from the stdout logging, where the reported message size is the total size of a message. Signed-off-by: Grant Pinkert --- src/common.cu | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common.cu b/src/common.cu index 5db78ea886..1ae2a788d4 100644 --- a/src/common.cu +++ b/src/common.cu @@ -760,12 +760,12 @@ testResult_t BenchTime(struct threadArgs* args, ncclDataType_t type, ncclRedOp_t PRINT(" %7s %6.2f %6.2f %5s", timeStr, algBw, busBw, "N/A"); } + auto largestMessageSize = std::max(args->sendBytes, args->expectedBytes); if (args->reporter) { if (args->reportErrors) { - args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, args->expectedBytes, in_place, timeUsec, algBw, busBw, wrongElts); - } - else { - args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, args->expectedBytes, in_place, timeUsec, algBw, busBw); + args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, largestMessageSize, in_place, timeUsec, algBw, busBw, wrongElts); + } else { + args->reporter->addResult((args->nThreads * args->nGpus), args->nProcs, args->totalProcs, largestMessageSize, in_place, timeUsec, algBw, busBw); } }