AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SWDEV-509876] Remove buffer requirement from device counting service (#132)

Browse Source 
* [SWDEV-509876] Remove buffer requirement from device counting service

No longer require a buffer to be given when setting up device counting
service. This is to reduce performance overhead in cases where immediate
return of counting samples is being used (synchronous mode).

* Missed file

* Update source/include/rocprofiler-sdk/device_counting_service.h

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk/counters/controller.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk/counters/device_counting.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Fixes for build

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: 0c4a56c6bb]
This commit is contained in:
Welton, Benjamin
2025-02-04 04:06:03 -08:00
committed by GitHub
parent 4282aa31d9
commit f615e85f71
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/controller.cpp
+2 -1
View File
@@ -82,7 +82,8 @@ CounterController::configure_agent_collection(rocprofiler_context_id_t context_i
// cannot coexist in the same context for now.
if(ctx.pc_sampler) return ROCPROFILER_STATUS_ERROR_CONTEXT_CONFLICT;
if(!rocprofiler::buffer::get_buffer(buffer_id.handle))
if(!rocprofiler::buffer::get_buffer(buffer_id) &&
buffer_id != rocprofiler_buffer_id_t{.handle = 0})
{
return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
}
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/device_counting.cpp
+4 -3
View File
@@ -132,7 +132,7 @@ agent_async_handler(hsa_signal_value_t /*signal_v*/, void* data)
*prof_config->agent, prof_config->required_special_counters, decoded_pkt);
auto* buf = buffer::get_buffer(callback_data.buffer.handle);
if(!buf)
if(!buf && callback_data.buffer != rocprofiler_buffer_id_t{.handle = 0})
{
ROCP_FATAL << fmt::format("Buffer {} destroyed before record was written",
callback_data.buffer.handle);
@@ -160,8 +160,9 @@ agent_async_handler(hsa_signal_value_t /*signal_v*/, void* data)
{
callback_data.cached_counters->push_back(val);
}
buf->emplace(
ROCPROFILER_BUFFER_CATEGORY_COUNTERS, ROCPROFILER_COUNTER_RECORD_VALUE, val);
if(buf)
buf->emplace(
ROCPROFILER_BUFFER_CATEGORY_COUNTERS, ROCPROFILER_COUNTER_RECORD_VALUE, val);
}
}