User api updates (#32)

* Update invoke.hpp

* Update OMNITRACE_FUNCTION

* Update library debug messages

* ptl verbosity

* Update timemory submodule

* mpi_gotcha calls omnitrace_finalize_hidden

* omnitrace_{push,pop}_region returns error code

* omnitrace-user updates

- doxygen documentation
- omnitrace_get_user_callbacks
- omnitrace_user_error_string
- omnitrace-user functions return error codes

* Update user-api example

* Tweak to workflows and tests

* Fix for OMNITRACE_FUNCTION

- conditional impl if __GNUC__ < 9

* focal-external-rocm workflow update

.github/workflows/ubuntu-bionic.yml

@@ -83,7 +83,7 @@ jobs:
       timeout-minutes: 30
       run:
         cd build &&
-        ctest -V --output-log build/omnitrace-ctest-ubuntu-bionic.log
+        ctest -V --output-log build/omnitrace-ctest-ubuntu-bionic.log --stop-on-failure
 
     - name: Test Install
       timeout-minutes: 10

.github/workflows/ubuntu-focal-dyninst-package.yml

@@ -88,7 +88,7 @@ jobs:
       run:
         ldd ./omnitrace &&
         ./omnitrace --help &&
-        ctest -V --output-log ${{ github.workspace }}/build/omnitrace-ctest-ubuntu-focal-dyninst-package.log
+        ctest -V --output-log ${{ github.workspace }}/build/omnitrace-ctest-ubuntu-focal-dyninst-package.log --stop-on-failure
 
     - name: Test Install
       timeout-minutes: 10

.github/workflows/ubuntu-focal-external-rocm.yml

@@ -8,10 +8,11 @@ on:
 
 env:
   BUILD_TYPE: Release
-  ELFUTILS_DOWNLOAD_VERSION: 0.183
   OMNITRACE_DEBUG_FINALIZE: ON
   OMNITRACE_VERBOSE: 1
   OMNITRACE_CI: ON
+  OMNITRACE_OUTPUT_PATH: omnitrace-tests-output
+  OMNITRACE_OUTPUT_PREFIX: "%argt%/"
 
 jobs:
   ubuntu-focal-external-rocm:
@@ -80,7 +81,8 @@ jobs:
       run:
         cd build &&
         ldd ./omnitrace &&
-        ./omnitrace --help
+        ./omnitrace --help &&
+        ctest -V --output-log omnitrace-ctest-ubuntu-focal-external-rocm.log --stop-on-failure
 
     - name: Test Install
       timeout-minutes: 10
@@ -97,9 +99,22 @@ jobs:
         ldd $(which omnitrace)
         omnitrace --help
         omnitrace -e -v 1 -o ls.inst --simulate -- ls
-        for i in omnitrace-ls.inst-output/*; do echo -e "\n\n --> ${i} \n\n"; cat ${i}; done
         omnitrace -e -v 1 -o ls.inst -- ls
         ./ls.inst
         omnitrace -e -v 1 --simulate -- ls
-        for i in omnitrace-ls-output/*; do echo -e "\n\n --> ${i} \n\n"; cat ${i}; done
         omnitrace -e -v 1 -- ls
+
+    - name: CTest Artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: ctest-log
+        path: |
+          build/*.log
+
+    - name: Data Artifacts
+      uses: actions/upload-artifact@v2
+      with:
+        name: data-files
+        path: |
+          omnitrace-tests-output/**/*.txt
+          build/omnitrace-tests-output/**/*.txt

.github/workflows/ubuntu-focal-external.yml

@@ -71,7 +71,7 @@ jobs:
         cd build &&
         ldd ./omnitrace &&
         ./omnitrace --help &&
-        ctest -V --output-log build/omnitrace-ctest-ubuntu-focal-external.log
+        ctest -V --output-log build/omnitrace-ctest-ubuntu-focal-external.log --stop-on-failure
 
     - name: Test Install
       timeout-minutes: 10

.github/workflows/ubuntu-focal.yml

@@ -71,7 +71,7 @@ jobs:
       timeout-minutes: 30
       working-directory: ${{ github.workspace }}/build
       run:
-        ctest -V --output-log ${{ github.workspace }}/build/omnitrace-ctest-ubuntu-focal.log
+        ctest -V --output-log ${{ github.workspace }}/build/omnitrace-ctest-ubuntu-focal.log --stop-on-failure
 
     - name: Test Install
       timeout-minutes: 10