AI/rocm-systems
2
0
Vork 0
Code Kwesties Pull-aanvragen Actions Paketten Projecten Publicaties Wiki Activiteit

SWDEV-470698 - fix formatting, add format check workflow (#657)

Bladeren bron
This commit is contained in:
Danylo Lytovchenko
2025-08-20 16:28:06 +02:00
gecommit door GitHub
bovenliggende 5840940caa
commit f7338717ae
1574 gewijzigde bestanden met toevoegingen van 162972 en 199346 verwijderingen
Download Patch-bestand Download Diff-bestand Expand all files Collapse all files
projects/hip-tests/catch/unit/graph/hipGraphDebugDotPrint.cc
+97 -114
Bestand weergeven
@@ -18,18 +18,18 @@ THE SOFTWARE.
*/
/**
* @addtogroup hipGraphDebugDotPrint hipGraphDebugDotPrint
* @{
* @ingroup GraphTest
* `hipGraphDebugDotPrint(hipGraph_t graph, const char* path, unsigned int flags)` -
* Write a DOT file describing graph structure.
*/
* @addtogroup hipGraphDebugDotPrint hipGraphDebugDotPrint
* @{
* @ingroup GraphTest
* `hipGraphDebugDotPrint(hipGraph_t graph, const char* path, unsigned int flags)` -
* Write a DOT file describing graph structure.
*/
#include <hip_test_common.hh>
#include <hip_test_checkers.hh>
#include <hip_test_kernels.hh>
#define N 1024
#define N 1024
#ifdef __linux__
#include <unistd.h>
@@ -40,25 +40,22 @@ THE SOFTWARE.
__device__ int globalIn[N];
static void callbackfunc(void *A_h) {
int *A = reinterpret_cast<int *>(A_h);
std::iota(A, A+N, 0);
static void callbackfunc(void* A_h) {
int* A = reinterpret_cast<int*>(A_h);
std::iota(A, A + N, 0);
}
static void deleteFile(const char* fName) {
if ( remove(fName) != 0 ) {
if (remove(fName) != 0) {
INFO("Error in deleting file -" << fName);
} else {
INFO("Successfully deleted file -" << fName);
}
}
static bool checkFileExists(const char* fName) {
return (access(fName, F_OK) != -1);
}
static bool checkFileExists(const char* fName) { return (access(fName, F_OK) != -1); }
static unsigned countSubstr(const std::string &input_str,
const std::string &substr) {
static unsigned countSubstr(const std::string& input_str, const std::string& substr) {
unsigned count = 0;
std::string::size_type srch_pos = 0, cur_pos = 0;
while ((cur_pos = input_str.find(substr, srch_pos)) != std::string::npos) {
@@ -68,8 +65,7 @@ static unsigned countSubstr(const std::string &input_str,
return count;
}
static bool validateDotFile(const char* fName,
const std::map<std::string, unsigned> &graphData) {
static bool validateDotFile(const char* fName, const std::map<std::string, unsigned>& graphData) {
std::ifstream infile(fName);
std::stringstream buffer;
buffer << infile.rdbuf();
@@ -77,8 +73,8 @@ static bool validateDotFile(const char* fName,
for (auto it = graphData.begin(); it != graphData.end(); it++) {
unsigned count = countSubstr(buffer_str, it->first);
if (it->second != count) {
INFO("validateDotFile: Failed for key :: " << it->first <<
" : " << count << " Expected : " << it->second);
INFO("validateDotFile: Failed for key :: " << it->first << " : " << count
<< " Expected : " << it->second);
return false;
}
}
@@ -86,34 +82,33 @@ static bool validateDotFile(const char* fName,
}
/**
* Test Description
* ------------------------
*  - Functional Test for API - hipGraphDebugDotPrint
* Call hipGraphDebugDotPrint and provice path where to write the DOT file.
* Verify that DOT file get created or not for each flag passed.
* 1) Add MemcpyNode node to graph & validate its DebugDotPrint descriptions
* 2) Add kernel node to graph & validate its DebugDotPrint descriptions
* 3) Add memset node to graph & validate its DebugDotPrint descriptions
* 4) Add emptyNode to graph & validate its DebugDotPrint descriptions
* 5) Add childGraphNode to graph & validate its DebugDotPrint descriptions
* 6) Add eventRecord to graph & validate its DebugDotPrint descriptions
* 7) Add eventWait to graph & validate its DebugDotPrint descriptions
* 8) Add hostNode to graph & validate its DebugDotPrint descriptions
* 9) Add mecpyNode1D to graph & validate its DebugDotPrint descriptions
* 10) Add mecpyNode3D to graph & validate its DebugDotPrint descriptions
* 11) Add MemcpyNodeToSymbol to graph & validate its DebugDotPrint descriptions
* 12) Add MemcpyNodeFromSymbol to graph & validate its DebugDotPrint descriptions
* 13) Add Dependencies to graph & validate its DebugDotPrint descriptions
* Test source
* ------------------------
*  - /unit/graph/hipGraphDebugDotPrint.cc
* Test requirements
* ------------------------
*  - HIP_VERSION >= 5.6
*/
* Test Description
* ------------------------
*  - Functional Test for API - hipGraphDebugDotPrint
* Call hipGraphDebugDotPrint and provice path where to write the DOT file.
* Verify that DOT file get created or not for each flag passed.
* 1) Add MemcpyNode node to graph & validate its DebugDotPrint descriptions
* 2) Add kernel node to graph & validate its DebugDotPrint descriptions
* 3) Add memset node to graph & validate its DebugDotPrint descriptions
* 4) Add emptyNode to graph & validate its DebugDotPrint descriptions
* 5) Add childGraphNode to graph & validate its DebugDotPrint descriptions
* 6) Add eventRecord to graph & validate its DebugDotPrint descriptions
* 7) Add eventWait to graph & validate its DebugDotPrint descriptions
* 8) Add hostNode to graph & validate its DebugDotPrint descriptions
* 9) Add mecpyNode1D to graph & validate its DebugDotPrint descriptions
* 10) Add mecpyNode3D to graph & validate its DebugDotPrint descriptions
* 11) Add MemcpyNodeToSymbol to graph & validate its DebugDotPrint descriptions
* 12) Add MemcpyNodeFromSymbol to graph & validate its DebugDotPrint descriptions
* 13) Add Dependencies to graph & validate its DebugDotPrint descriptions
* Test source
* ------------------------
*  - /unit/graph/hipGraphDebugDotPrint.cc
* Test requirements
* ------------------------
*  - HIP_VERSION >= 5.6
*/
static void hipGraphDebugDotPrint_Functional(const char* fName,
unsigned int flag = 0) {
static void hipGraphDebugDotPrint_Functional(const char* fName, unsigned int flag = 0) {
constexpr size_t Nbytes = N * sizeof(int);
constexpr auto blocksPerCU = 6; // to hide latency
constexpr auto threadsPerBlock = 256;
@@ -134,13 +129,13 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
HIP_CHECK(hipGraphCreate(&graph, 0));
HIP_CHECK(hipStreamCreate(&stream));
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_A, graph, nullptr, 0, A_d, A_h,
Nbytes, hipMemcpyHostToDevice));
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_B, graph, nullptr, 0, B_d, B_h,
Nbytes, hipMemcpyHostToDevice));
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_A, graph, nullptr, 0, A_d, A_h, Nbytes,
hipMemcpyHostToDevice));
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_B, graph, nullptr, 0, B_d, B_h, Nbytes,
hipMemcpyHostToDevice));
void* kernelArgs[] = {&A_d, &B_d, &C_d, reinterpret_cast<void *>(&NElem)};
kNodeParams.func = reinterpret_cast<void *>(HipTest::vectorADD<int>);
void* kernelArgs[] = {&A_d, &B_d, &C_d, reinterpret_cast<void*>(&NElem)};
kNodeParams.func = reinterpret_cast<void*>(HipTest::vectorADD<int>);
kNodeParams.gridDim = dim3(blocks);
kNodeParams.blockDim = dim3(threadsPerBlock);
kNodeParams.sharedMemBytes = 0;
@@ -151,8 +146,8 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
HIP_CHECK(hipGraphAddKernelNode(&kNodeAdd, graph, nullptr, 0, &kNodeParams));
// Add MemCpy node to graph & validate its DebugDotPrint descriptions
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_C, graph, nullptr, 0, C_h, C_d,
Nbytes, hipMemcpyDeviceToHost));
HIP_CHECK(hipGraphAddMemcpyNode1D(&memcpy_C, graph, nullptr, 0, C_h, C_d, Nbytes,
hipMemcpyDeviceToHost));
// Add Dependencies to graph & validate its DebugDotPrint descriptions
HIP_CHECK(hipGraphAddDependencies(graph, &memcpy_A, &kNodeAdd, 1));
@@ -172,8 +167,7 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
HIP_CHECK(hipEventCreate(&event));
// Add eventRecord to graph & validate its DebugDotPrint descriptions
HIP_CHECK(hipGraphAddEventRecordNode(&eventRecord, graph, nullptr,
0, event));
HIP_CHECK(hipGraphAddEventRecordNode(&eventRecord, graph, nullptr, 0, event));
// Add eventWait to graph & validate its DebugDotPrint descriptions
HIP_CHECK(hipGraphAddEventWaitNode(&eventWait, graph, nullptr, 0, event));
@@ -187,45 +181,42 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
hipMemcpy3DParms myparams;
uint32_t size = width * height * depth * sizeof(int);
hipGraphNode_t mcpyNode3D;
int *hData = reinterpret_cast<int*>(malloc(size));
int* hData = reinterpret_cast<int*>(malloc(size));
REQUIRE(hData != nullptr);
// Initialize host buffer
for (int i = 0; i < depth; i++) {
for (int j = 0; j < height; j++) {
for (int k = 0; k < width; k++) {
hData[i*width*height + j*width + k] = i*width*height + j*width + k;
hData[i * width * height + j * width + k] = i * width * height + j * width + k;
}
}
}
hipChannelFormatDesc channelDesc = hipCreateChannelDesc(sizeof(int)*8,
0, 0, 0, formatKind);
HIP_CHECK(hipMalloc3DArray(&devArray1, &channelDesc,
make_hipExtent(width, height, depth), hipArrayDefault));
hipChannelFormatDesc channelDesc = hipCreateChannelDesc(sizeof(int) * 8, 0, 0, 0, formatKind);
HIP_CHECK(hipMalloc3DArray(&devArray1, &channelDesc, make_hipExtent(width, height, depth),
hipArrayDefault));
memset(&myparams, 0x0, sizeof(hipMemcpy3DParms));
myparams.srcPos = make_hipPos(0, 0, 0);
myparams.dstPos = make_hipPos(0, 0, 0);
myparams.extent = make_hipExtent(width , height, depth);
myparams.srcPtr = make_hipPitchedPtr(hData, width * sizeof(int),
width, height);
myparams.extent = make_hipExtent(width, height, depth);
myparams.srcPtr = make_hipPitchedPtr(hData, width * sizeof(int), width, height);
myparams.dstArray = devArray1;
myparams.kind = hipMemcpyHostToDevice;
HIP_CHECK(hipGraphAddMemcpyNode(&mcpyNode3D, childGraph,
nullptr, 0, &myparams));
HIP_CHECK(hipGraphAddMemcpyNode(&mcpyNode3D, childGraph, nullptr, 0, &myparams));
// Add MemcpyNodeToSymbol to graph & validate its DebugDotPrint description
hipGraphNode_t memcpyToSymbolNode, memcpyFromSymbolNode;
HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, childGraph,
nullptr, 0, HIP_SYMBOL(globalIn),
B_h, Nbytes, 0, hipMemcpyHostToDevice));
HIP_CHECK(hipGraphAddMemcpyNodeToSymbol(&memcpyToSymbolNode, childGraph, nullptr, 0,
HIP_SYMBOL(globalIn), B_h, Nbytes, 0,
hipMemcpyHostToDevice));
// Add MemcpyNodeFromSymbol to graph & validate its DebugDotPrint description
HIP_CHECK(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, childGraph,
nullptr, 0, B_h, HIP_SYMBOL(globalIn),
Nbytes, 0, hipMemcpyDeviceToHost));
HIP_CHECK(hipGraphAddMemcpyNodeFromSymbol(&memcpyFromSymbolNode, childGraph, nullptr, 0, B_h,
HIP_SYMBOL(globalIn), Nbytes, 0,
hipMemcpyDeviceToHost));
HIP_CHECK(hipGraphAddDependencies(childGraph, &memcpyToSymbolNode, &memcpyFromSymbolNode, 1));
// Add memset node to graph & validate its DebugDotPrint descriptions
hipMemsetParams memsetParams{};
@@ -236,15 +227,13 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
memsetParams.elementSize = sizeof(char);
memsetParams.width = Nbytes;
memsetParams.height = 1;
HIP_CHECK(hipGraphAddMemsetNode(&memsetNode, childGraph, nullptr, 0,
&memsetParams));
HIP_CHECK(hipGraphAddMemsetNode(&memsetNode, childGraph, nullptr, 0, &memsetParams));
// Add childGraphNode to graph & validate its DebugDotPrint descriptions
HIP_CHECK(hipGraphAddChildGraphNode(&childGraphNode, graph,
nullptr, 0, childGraph));
HIP_CHECK(hipGraphAddChildGraphNode(&childGraphNode, graph, nullptr, 0, childGraph));
std::map<std::string, unsigned> graphData;
graphData["->"] = 4; // number of edges
graphData["->"] = 4; // number of edges
graphData["MEMCPY"] = 6;
graphData["HtoA"] = 1;
graphData["HtoD"] = 3;
@@ -257,15 +246,12 @@ static void hipGraphDebugDotPrint_Functional(const char* fName,
graphData["HOST"] = 1;
#if HT_NVIDIA
if ( flag == hipGraphDebugDotFlagsVerbose ||
flag == hipGraphDebugDotFlagsMemcpyNodeParams ) {
if (flag == hipGraphDebugDotFlagsVerbose || flag == hipGraphDebugDotFlagsMemcpyNodeParams) {
graphData["HOST"] = 7;
}
#endif
if ( flag == hipGraphDebugDotFlagsVerbose ||
flag == hipGraphDebugDotFlagsKernelNodeAttributes
) {
if (flag == hipGraphDebugDotFlagsVerbose || flag == hipGraphDebugDotFlagsKernelNodeAttributes) {
graphData["KERNEL"] = 1;
}
@@ -299,8 +285,7 @@ TEST_CASE("Unit_hipGraphDebugDotPrint_Functional") {
CHECK_IMAGE_SUPPORT
SECTION("Call with hipGraphDebugDotFlagsVerbose flag") {
hipGraphDebugDotPrint_Functional("./graphDotFileFuncVerbose.dot",
hipGraphDebugDotFlagsVerbose);
hipGraphDebugDotPrint_Functional("./graphDotFileFuncVerbose.dot", hipGraphDebugDotFlagsVerbose);
}
SECTION("Call with hipGraphDebugDotFlagsKernelNodeParams flag") {
hipGraphDebugDotPrint_Functional("./graphDotFileFuncKernelParams.dot",
@@ -324,38 +309,38 @@ TEST_CASE("Unit_hipGraphDebugDotPrint_Functional") {
}
SECTION("Call with hipGraphDebugDotFlagsExtSemasSignalNodeParams flag") {
hipGraphDebugDotPrint_Functional("./graphDotFileFuncExtSemasSignal.dot",
hipGraphDebugDotFlagsExtSemasSignalNodeParams);
hipGraphDebugDotFlagsExtSemasSignalNodeParams);
}
SECTION("Call with hipGraphDebugDotFlagsExtSemasWaitNodeParams flag") {
hipGraphDebugDotPrint_Functional("./graphDotFileFuncExtSemasWait.dot",
hipGraphDebugDotFlagsExtSemasWaitNodeParams);
hipGraphDebugDotFlagsExtSemasWaitNodeParams);
}
SECTION("Call with hipGraphDebugDotFlagsKernelNodeAttributes flag") {
hipGraphDebugDotPrint_Functional("./graphDotFileFuncKernelNodeAttr.dot",
hipGraphDebugDotFlagsKernelNodeAttributes);
hipGraphDebugDotFlagsKernelNodeAttributes);
}
}
/**
* Test Description
* ------------------------
*  - Negative Test for API - hipGraphDebugDotPrint Argument Check
* 1) Pass graph as nullptr
* 2) Pass graph as uninitialize structure
* 3) Pass path for dot file to store as nullptr
* 4) Pass path for dot file to store as empth path
* 5) Pass flag as hipGraphDebugDotFlags MIN - 1
* 6) Pass flag as hipGraphDebugDotFlags MAX + 1
* 7) Pass flag as INT_MAX
* Test source
* ------------------------
*  - /unit/graph/hipGraphDebugDotPrint.cc
* Test requirements
* ------------------------
*  - HIP_VERSION >= 5.6
*/
* Test Description
* ------------------------
*  - Negative Test for API - hipGraphDebugDotPrint Argument Check
* 1) Pass graph as nullptr
* 2) Pass graph as uninitialize structure
* 3) Pass path for dot file to store as nullptr
* 4) Pass path for dot file to store as empth path
* 5) Pass flag as hipGraphDebugDotFlags MIN - 1
* 6) Pass flag as hipGraphDebugDotFlags MAX + 1
* 7) Pass flag as INT_MAX
* Test source
* ------------------------
*  - /unit/graph/hipGraphDebugDotPrint.cc
* Test requirements
* ------------------------
*  - HIP_VERSION >= 5.6
*/
#define DOT_FILE_PATH_NEG "./graphDotFileNeg.dot"
#define DOT_FILE_PATH_NEG "./graphDotFileNeg.dot"
TEST_CASE("Unit_hipGraphDebugDotPrint_Argument_Check") {
hipGraph_t graph;
@@ -381,13 +366,11 @@ TEST_CASE("Unit_hipGraphDebugDotPrint_Argument_Check") {
REQUIRE(hipErrorOperatingSystem == ret);
}
SECTION("Pass flag as hipGraphDebugDotFlags MIN - 1") {
ret = hipGraphDebugDotPrint(graph, DOT_FILE_PATH_NEG,
hipGraphDebugDotFlagsVerbose-1);
ret = hipGraphDebugDotPrint(graph, DOT_FILE_PATH_NEG, hipGraphDebugDotFlagsVerbose - 1);
REQUIRE(hipSuccess == ret);
}
SECTION("Pass flag as hipGraphDebugDotFlags MAX + 1") {
ret = hipGraphDebugDotPrint(graph, DOT_FILE_PATH_NEG,
hipGraphDebugDotFlagsHandles+1);
ret = hipGraphDebugDotPrint(graph, DOT_FILE_PATH_NEG, hipGraphDebugDotFlagsHandles + 1);
REQUIRE(hipSuccess == ret);
}
SECTION("Pass flag as INT_MAX") {
@@ -400,6 +383,6 @@ TEST_CASE("Unit_hipGraphDebugDotPrint_Argument_Check") {
#endif // __linux__
/**
* End doxygen group GraphTest.
* @}
*/
* End doxygen group GraphTest.
* @}
*/