AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-470698 - fix formatting, add format check workflow (#657)

Browse Source
This commit is contained in:
Danylo Lytovchenko
2025-08-20 16:28:06 +02:00
committed by GitHub
parent 5840940caa
commit f7338717ae
1574 changed files with 162972 additions and 199346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/hip-tests/catch/unit/memory/hipSVMTestByteGranularity.cpp
+11 -15
View File
@@ -48,8 +48,7 @@ __global__ void sum_neighbor_locations(char* a, unsigned int num_devices,
for (unsigned int j = 0; j < num_devices; j++) {
sum += a[i + j]; // add my neighbors to the right
}
if (sum != expected_sum)
atomicAdd_system(error_count, 1u); // like opencl atomic_inc()
if (sum != expected_sum) atomicAdd_system(error_count, 1u); // like opencl atomic_inc()
}
/**
@@ -97,25 +96,24 @@ TEST_CASE("test_svm_byte_granularity") {
HIP_CHECK(hipHostMalloc(&pA, sizeof(char) * num_elements, hipHostMallocNonCoherent));
unsigned int** error_counts = (unsigned int**)malloc(sizeof(void*) * num_devices);
for(unsigned int i=0; i < num_devices; i++) {
for (unsigned int i = 0; i < num_devices; i++) {
// hipHostMallocCoherent means CL_MEM_SVM_FINE_GRAIN_BUFFER + CL_MEM_SVM_ATOMICS
// We need atomic inc among different GPUs
HIP_CHECK(hipHostMalloc(&error_counts[i], sizeof(unsigned int) * num_elements,
hipHostMallocCoherent));
*error_counts[i] = 0;
}
for(int i = 0; i < num_elements; i++) pA[i] = -1;
for (int i = 0; i < num_elements; i++) pA[i] = -1;
// get all the devices going simultaneously
for(unsigned int d = 0; d < num_devices; d++) // device ids starting at 1.
for (unsigned int d = 0; d < num_devices; d++) // device ids starting at 1.
{
HIP_CHECK(hipSetDevice(d));
write_owned_locations<<<num_elements, 1, 0, streams[d]>>>(pA, num_devices_plus_host, d);
HIP_CHECK(hipGetLastError());
}
unsigned int host_id = num_devices; // host code will take the id above the devices.
for(unsigned int i = num_devices; i < num_elements; i+= num_devices_plus_host)
pA[i] = host_id;
for (unsigned int i = num_devices; i < num_elements; i += num_devices_plus_host) pA[i] = host_id;
for (unsigned int d = 0; d < num_devices; d++) {
HIP_CHECK(hipStreamSynchronize(streams[d]));
@@ -124,11 +122,10 @@ TEST_CASE("test_svm_byte_granularity") {
// now check that each device can see the byte writes made by the other devices.
// adjusted so sum_neighbor_locations doesn't read past end of buffer
size_t adjusted_num_elements = num_elements - num_devices;
for(unsigned int d = 0; d < num_devices; d++)
{
for (unsigned int d = 0; d < num_devices; d++) {
HIP_CHECK(hipSetDevice(d));
sum_neighbor_locations<<<adjusted_num_elements, 1, 0, streams[d]>>>(pA, num_devices_plus_host,
error_counts[d]);
error_counts[d]);
HIP_CHECK(hipGetLastError());
}
@@ -136,18 +133,17 @@ TEST_CASE("test_svm_byte_granularity") {
HIP_CHECK(hipStreamSynchronize(streams[d]));
}
// see if any of the devices found errors
for(unsigned int d = 0; d < num_devices; d++) {
for (unsigned int d = 0; d < num_devices; d++) {
if (*error_counts[d] > 0) {
fprintf(stderr, "*error_counts[%u] = %u\n", d, *error_counts[d]);
REQUIRE(false);
}
}
unsigned int expected = (num_devices_plus_host * (num_devices_plus_host - 1))/2;
unsigned int expected = (num_devices_plus_host * (num_devices_plus_host - 1)) / 2;
// check that host can see the byte writes made by the devices.
for(unsigned int i = 0; i < num_elements - num_devices_plus_host; i++)
{
for (unsigned int i = 0; i < num_elements - num_devices_plus_host; i++) {
unsigned int sum = 0;
for(unsigned int j = 0; j < num_devices_plus_host; j++) sum += pA[i+j];
for (unsigned int j = 0; j < num_devices_plus_host; j++) sum += pA[i + j];
if (sum != expected) {
fprintf(stderr, "[%u]: sum %u != expected %u", i, sum, expected);
REQUIRE(false);