Updates/fixes for CI, docs, tests, samples, and common library (#528)

- .github/workflows/continuous_integration.yml
  - apt-get update before apt-get install
  - remove libgtest-dev
  - actions-comment-pull-request: v2.4.3 -> v2.5.0
- .github/workflows/formatting.yml
  - create-pull-request: v5 -> v6
- cmake/rocprofiler_options.cmake
  - remove unused ROCPROFILER_DEBUG_TRACE and ROCPROFILER_LD_AQLPROFILE options
- samples/counter_collection/callback_client.cpp
  - corr_id field renamed to correlation_id
- samples/counter_collection/client.cpp
  - corr_id field renamed to correlation_id
- include/rocprofiler-sdk/fwd.h
  - In rocprofiler_record_counter_t: rename corr_id field to correlation_id
  - doxygen fixes
- lib/common/utility.*
  - remove get_accurate_clock_id_impl
  - timestamp_ns() defaults to CLOCK_BOOTTIME
- lib/rocprofiler-sdk/counters/core.cpp
  - fix spelling mistake: extrenal -> external
  - corr_id field renamed to correlation_id
- lib/rocprofiler-sdk-tool/tool.cpp
  - fix destruction of static tool::output_file before finalization
- scripts/update-docs.sh
  - define PROJECT_NAME
- tests/async-copy-tracing/validate.py
  - init_time and fini_time checks
  - hip_api_traces, marker_api_tracing
- tests/common/serialization.hpp
  - fix save function for rocprofiler_record_counter_t following rename of corr_id to correlation_id
- tests/kernel-tracing/validate.py
  - init_time and fini_time checks
  - relax test_total_runtime range
- tests/rocprofv3/tracing/CMakeLists.txt
  - remove -M from rocprofv3-test-systrace-execute
  - exclude test_hsa_api_trace in rocprofv3-test-systrace-validate due to HIP API tracing
- tests/rocprofv3/tracing/validate.py
  - update test_kernel_trace to accept mangled or demangled
- tests/tools/json-tool.cpp
  - remove use of GLOG
  - include init_time and fini_time
  - write_json(...) function

[ROCm/rocprofiler-sdk commit: 0d939edbba]

projects/rocprofiler-sdk/tests/kernel-tracing/validate.py

@@ -8,7 +8,8 @@ import pytest
 def node_exists(name, data, min_len=1):
     assert name in data
     assert data[name] is not None
-    assert len(data[name]) >= min_len
+    if isinstance(data[name], (list, tuple, dict, set)):
+        assert len(data[name]) >= min_len
 
 
 def test_data_structure(input_data):
@@ -19,6 +20,12 @@ def test_data_structure(input_data):
 
     sdk_data = data["rocprofiler-sdk-json-tool"]
 
+    node_exists("metadata", sdk_data)
+    node_exists("pid", sdk_data["metadata"])
+    node_exists("main_tid", sdk_data["metadata"])
+    node_exists("init_time", sdk_data["metadata"])
+    node_exists("fini_time", sdk_data["metadata"])
+
     node_exists("agents", sdk_data)
     node_exists("call_stack", sdk_data)
     node_exists("callback_records", sdk_data)
@@ -60,18 +67,20 @@ def test_timestamps(input_data):
         for itr in sdk_data["buffer_records"][titr]:
             assert itr["start_timestamp"] <= itr["end_timestamp"]
 
-    for itr in sdk_data["buffer_records"]["memory_copies"]:
-        assert itr["start_timestamp"] <= itr["end_timestamp"]
+    for titr in ["kernel_dispatches", "memory_copies"]:
+        for itr in sdk_data["buffer_records"][titr]:
+            assert itr["start_timestamp"] < itr["end_timestamp"]
+            assert itr["correlation_id"]["internal"] > 0
+            assert itr["correlation_id"]["external"] > 0
+            assert sdk_data["metadata"]["init_time"] < itr["start_timestamp"]
+            assert sdk_data["metadata"]["init_time"] < itr["end_timestamp"]
+            assert sdk_data["metadata"]["fini_time"] > itr["start_timestamp"]
+            assert sdk_data["metadata"]["fini_time"] > itr["end_timestamp"]
 
-    for itr in sdk_data["buffer_records"]["kernel_dispatches"]:
-        assert itr["start_timestamp"] < itr["end_timestamp"]
-        assert itr["correlation_id"]["internal"] > 0
-        assert itr["correlation_id"]["external"] > 0
-
-        api_start = cb_start[itr["correlation_id"]["internal"]]
-        api_end = cb_end[itr["correlation_id"]["internal"]]
-        assert api_start < itr["start_timestamp"]
-        assert api_end <= itr["end_timestamp"]
+            api_start = cb_start[itr["correlation_id"]["internal"]]
+            api_end = cb_end[itr["correlation_id"]["internal"]]
+            assert api_start < itr["start_timestamp"]
+            assert api_end <= itr["end_timestamp"]
 
 
 def test_total_runtime(input_data):
@@ -84,8 +93,8 @@ def test_total_runtime(input_data):
 
     expected_runtime = 1.0e3  # one second in milliseconds
 
-    assert (sum(runtime_data) * 1.0e-6) >= (0.9 * expected_runtime)
-    assert (sum(runtime_data) * 1.0e-6) <= (1.1 * expected_runtime)
+    assert (sum(runtime_data) * 1.0e-6) >= (0.8 * expected_runtime)
+    assert (sum(runtime_data) * 1.0e-6) <= (1.2 * expected_runtime)
 
 
 def test_internal_correlation_ids(input_data):