From bb50cf42a262948e1cf779672f4d98fed1050508 Mon Sep 17 00:00:00 2001 From: "Galantsev, Dmitrii" Date: Wed, 6 Dec 2023 02:43:04 -0600 Subject: [PATCH 1/2] TESTS - Fix overdrive error on not-supported Change-Id: I47e7f499229b47b151f4ba4d5fa9c59ac04d6816 Signed-off-by: Galantsev, Dmitrii [ROCm/rocm_smi_lib commit: 102c2c692ab3d7e9c96bd04fcd81fce0b0b1481a] --- .../tests/rocm_smi_test/functional/overdrive_read.cc | 10 ++++++++++ .../rocm_smi_test/functional/overdrive_read_write.cc | 9 +++++++++ 2 files changed, 19 insertions(+) diff --git a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc index b3450d60fc..9d93daa83a 100755 --- a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc +++ b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc @@ -99,6 +99,16 @@ void TestOverdriveRead::Run(void) { PrintDeviceHeader(i); err = rsmi_dev_overdrive_level_get(i, &val_ui32); + if (err == RSMI_STATUS_NOT_SUPPORTED) { + IF_VERB(STANDARD) { + std::cout << + "\t**Overdrive Level get is not supported on this machine" << std::endl; + } + // Verify api support checking functionality is working + err = rsmi_dev_overdrive_level_get(i, nullptr); + ASSERT_EQ(err, RSMI_STATUS_NOT_SUPPORTED); + continue; + } CHK_ERR_ASRT(err) IF_VERB(STANDARD) { std::cout << "\t**OverDrive Level:" << val_ui32 << std::endl; diff --git a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc index a5d2426f7b..9182a4a43a 100755 --- a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc +++ b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc @@ -101,12 +101,21 @@ void TestOverdriveReadWrite::Run(void) { std::cout << "Set Overdrive level to 0%..." << std::endl; } ret = rsmi_dev_overdrive_level_set(dv_ind, 0); + if (ret == RSMI_STATUS_NOT_SUPPORTED) { + IF_VERB(STANDARD) { + std::cout << + "\t**Overdrive Level set is not supported on this machine" << std::endl; + } + continue; + } CHK_ERR_ASRT(ret) IF_VERB(STANDARD) { std::cout << "Set Overdrive level to 10%..." << std::endl; } ret = rsmi_dev_overdrive_level_set(dv_ind, 10); CHK_ERR_ASRT(ret) + // this won't be reachable if set doesn't work + // and is checked by overdrive_read.cc test ret = rsmi_dev_overdrive_level_get(dv_ind, &val); CHK_ERR_ASRT(ret) IF_VERB(STANDARD) { From f38b62abf569edffa57d9096a3219dab22876cbf Mon Sep 17 00:00:00 2001 From: "Galantsev, Dmitrii" Date: Wed, 6 Dec 2023 19:33:17 -0600 Subject: [PATCH 2/2] TESTS - Temporarily disable overdrive tests Change-Id: Ice06d31e874621abf3135548eedfe2158281891d Signed-off-by: Galantsev, Dmitrii [ROCm/rocm_smi_lib commit: 48163b8d4fa56b9ef4c2914376e701cffd19374b] --- .../tests/rocm_smi_test/functional/overdrive_read.cc | 1 + .../tests/rocm_smi_test/functional/overdrive_read_write.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc index 9d93daa83a..9dbd9bf2d5 100755 --- a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc +++ b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read.cc @@ -86,6 +86,7 @@ void TestOverdriveRead::Close() { void TestOverdriveRead::Run(void) { + GTEST_SKIP_("Temporarily disabled due to kernel issue"); rsmi_status_t err; uint32_t val_ui32; diff --git a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc index 9182a4a43a..2b1cb36d5c 100755 --- a/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc +++ b/projects/rocm-smi-lib/tests/rocm_smi_test/functional/overdrive_read_write.cc @@ -85,6 +85,7 @@ void TestOverdriveReadWrite::Close() { void TestOverdriveReadWrite::Run(void) { + GTEST_SKIP_("Temporarily disabled due to kernel issue"); rsmi_status_t ret; uint32_t val;