From f93831cf6a979a85a4fdde98acb52ec84089d155 Mon Sep 17 00:00:00 2001 From: Nilesh M Negi Date: Fri, 15 Mar 2024 12:18:18 -0500 Subject: [PATCH] BUILD: Enable RCCL static build (#1114) Signed-off-by: nileshnegi [ROCm/rccl commit: 53fad75001bb5782c08f265e8677a62f2e657a87] --- projects/rccl/CMakeLists.txt | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/projects/rccl/CMakeLists.txt b/projects/rccl/CMakeLists.txt index d0977e3cfe..09f0049b4a 100644 --- a/projects/rccl/CMakeLists.txt +++ b/projects/rccl/CMakeLists.txt @@ -670,11 +670,6 @@ endif() if(NOT BUILD_SHARED_LIBS) message(STATUS "Building static RCCL library") - target_link_libraries(rccl PRIVATE --emit-static-lib) - set(CMAKE_AR "${hipcc_executable}") - get_property(link_libraries TARGET rccl PROPERTY LINK_LIBRARIES) - string (REPLACE ";" " " LINK_PROPS "${link_libraries}") - set(CMAKE_CXX_ARCHIVE_CREATE " -o ${LINK_PROPS} ") else() message(STATUS "Building shared RCCL library") endif() @@ -764,11 +759,13 @@ if(BUILD_TESTS) rocm_package_setup_client_component(tests PACKAGE_NAME unittests) add_subdirectory(test) - add_custom_command(TARGET rccl POST_BUILD - COMMENT "Extracting metadata from librccl.so" - COMMAND COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/scripts/extract_metadata.cmake - VERBATIM - ) + if(BUILD_SHARED_LIBS) + add_custom_command(TARGET rccl POST_BUILD + COMMENT "Extracting metadata from librccl.so" + COMMAND COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/scripts/extract_metadata.cmake + VERBATIM + ) + endif() endif() rocm_create_package(