Remove comparisons of signed to unsigned values

tests/functional_tests/alltoall_tester.cpp

@@ -142,7 +142,7 @@ template <typename T1>
 void AlltoallTester<T1>::resetBuffers(uint64_t size) {
   int n_pes = rocshmem_team_n_pes(ROCSHMEM_TEAM_WORLD);
   for (int i = 0; i < n_pes; i++) {
-    for (int j = 0; j < size; j++) {
+    for (uint64_t j = 0; j < size; j++) {
       init_buf(source_buf[i * size + j], dest_buf[i * size + j], (T1)i);
     }
   }
@@ -152,10 +152,10 @@ template <typename T1>
 void AlltoallTester<T1>::verifyResults(uint64_t size) {
   int n_pes = rocshmem_team_n_pes(ROCSHMEM_TEAM_WORLD);
   for (int i = 0; i < n_pes; i++) {
-    for (int j = 0; j < size; j++) {
+    for (uint64_t j = 0; j < size; j++) {
       auto r = verify_buf(dest_buf[i * size + j], i);
       if (r.first == false) {
-        fprintf(stderr, "Data validation error at idx %d\n", j);
+        fprintf(stderr, "Data validation error at idx %lu\n", j);
         fprintf(stderr, "%s.\n", r.second.c_str());
         exit(-1);
       }

tests/functional_tests/fcollect_tester.cpp

@@ -141,7 +141,7 @@ template <typename T1>
 void FcollectTester<T1>::resetBuffers(uint64_t size) {
   int n_pes = rocshmem_team_n_pes(ROCSHMEM_TEAM_WORLD);
   for (int i = 0; i < n_pes; i++) {
-    for (int j = 0; j < size; j++) {
+    for (uint64_t j = 0; j < size; j++) {
       // Note: This is redundant work,
       // source is being reinitialized multiple times
       init_buf(source_buf[j], dest_buf[i * size + j]);
@@ -153,10 +153,10 @@ template <typename T1>
 void FcollectTester<T1>::verifyResults(uint64_t size) {
   int n_pes = rocshmem_team_n_pes(ROCSHMEM_TEAM_WORLD);
   for (int i = 0; i < n_pes; i++) {
-    for (int j = 0; j < size; j++) {
+    for (uint64_t j = 0; j < size; j++) {
       auto r = verify_buf(dest_buf[i * size + j], i);
       if (r.first == false) {
-        fprintf(stderr, "Data validation error at idx %d\n", j);
+        fprintf(stderr, "Data validation error at idx %lu\n", j);
         fprintf(stderr, "%s.\n", r.second.c_str());
         // exit(-1);
         return;

tests/functional_tests/primitive_mr_tester.cpp

@@ -100,9 +100,9 @@ void PrimitiveMRTester::verifyResults(uint64_t size) {
           : 1;
 
   if (args.myid == check_id) {
-    for (int i = 0; i < size; i++) {
+    for (uint64_t i = 0; i < size; i++) {
       if (r_buf[i] != '0') {
-        fprintf(stderr, "Data validation error at idx %d\n", i);
+        fprintf(stderr, "Data validation error at idx %lu\n", i);
         fprintf(stderr, "Got %c, Expected %c\n", r_buf[i], '0');
         exit(-1);
       }

tests/functional_tests/primitive_tester.cpp

@@ -123,9 +123,9 @@ void PrimitiveTester::verifyResults(uint64_t size) {
           : 1;
 
   if (args.myid == check_id) {
-    for (int i = 0; i < size; i++) {
+    for (uint64_t i = 0; i < size; i++) {
       if (r_buf[i] != '0') {
-        fprintf(stderr, "Data validation error at idx %d\n", i);
+        fprintf(stderr, "Data validation error at idx %lu\n", i);
         fprintf(stderr, "Got %c, Expected %c\n", r_buf[i], '0');
         exit(-1);
       }

tests/functional_tests/random_access_tester.cpp

@@ -154,7 +154,7 @@ RandomAccessTester::~RandomAccessTester() {
 }
 
 void RandomAccessTester::resetBuffers(uint64_t size) {
-  for (int i = 0; i < args.max_msg_size / sizeof(int) * args.wg_size * space;
+  for (size_t i = 0; i < args.max_msg_size / sizeof(int) * args.wg_size * space;
        i++) {
     s_buf[i] = 1;
     r_buf[i] = 0;
@@ -187,21 +187,21 @@ void RandomAccessTester::launchKernel(dim3 gridSize, dim3 blockSize, int loop,
 }
 
 void RandomAccessTester::verifyResults(uint64_t size) {
-  int offset, i, j;
+  uint64_t offset;
   for (int k = 0; k < _num_waves; k++) {
-    for (i = 0; i < _num_bins; i++) {
+    for (int i = 0; i < _num_bins; i++) {
       int index = i + _num_bins * k;
       if (args.op_type == PutType) {
-        if (_PE_bins[index] == args.myid) {
+        if (_PE_bins[index] == static_cast<uint32_t>(args.myid)) {
           offset = _off_bins[index];
-          for (j = 0; j < ((size / sizeof(int)) * args.coal_coef); j++) {
+          for (uint64_t j = 0; j < ((size / sizeof(int)) * args.coal_coef); j++) {
             h_buf[offset + j] = 1;
           }
         }
       } else {
         if (args.myid == 0) {
           offset = _off_bins[index];
-          for (j = 0; j < ((size / sizeof(int)) * args.coal_coef); j++) {
+          for (uint64_t j = 0; j < ((size / sizeof(int)) * args.coal_coef); j++) {
             h_buf[offset + j] = 1;
           }
         }
@@ -212,9 +212,9 @@ void RandomAccessTester::verifyResults(uint64_t size) {
   CHECK_HIP(hipMemcpy(h_dev_buf, r_buf, space * args.wg_size * size,
 		      hipMemcpyDeviceToHost));
   CHECK_HIP(hipDeviceSynchronize());
-  for (i = 0; i < (space * args.wg_size * size / sizeof(int)); i++) {
+  for (uint64_t i = 0; i < (space * args.wg_size * size / sizeof(int)); i++) {
     if (h_dev_buf[i] != h_buf[i]) {
-      printf("PE %d  Got Data Validation: expecting %d got %d at  %d \n",
+      printf("PE %d  Got Data Validation: expecting %d got %d at  %lu\n",
              args.myid, h_buf[i], h_dev_buf[i], i);
       exit(-1);
     }

tests/functional_tests/signaling_operations_tester.cpp

@@ -143,9 +143,9 @@ void SignalingOperationsTester::verifyResults(uint64_t size) {
                              ? 0 : -1; // do not check if it doesn't match a test
 
   if (args.myid == check_data_id) {
-    for (int i = 0; i < size; i++) {
+    for (uint64_t i = 0; i < size; i++) {
       if (r_buf[i] != '0') {
-        fprintf(stderr, "Data validation error at idx %d\n", i);
+        fprintf(stderr, "Data validation error at idx %lu\n", i);
         fprintf(stderr, "Got %c, Expected %c\n", r_buf[i], '0');
         exit(-1);
       }

tests/functional_tests/swarm_tester.cpp

@@ -80,9 +80,9 @@ void GetSwarmTester::launchKernel(dim3 gridSize, dim3 blockSize, int loop,
 
 void GetSwarmTester::verifyResults(uint64_t size) {
   if (args.myid == 0) {
-    for (int i = 0; i < size * args.wg_size; i++) {
+    for (uint64_t i = 0; i < size * args.wg_size; i++) {
       if (r_buf[i] != '0') {
-        fprintf(stderr, "Data validation error at idx %d\n", i);
+        fprintf(stderr, "Data validation error at idx %lu\n", i);
         fprintf(stderr, "Got %c, Expected %c\n", r_buf[i], '0');
         exit(-1);
       }

tests/functional_tests/team_broadcast_tester.cpp

@@ -145,17 +145,17 @@ void TeamBroadcastTester<T1>::postLaunchKernel() {
 
 template <typename T1>
 void TeamBroadcastTester<T1>::resetBuffers(uint64_t size) {
-  for (int i = 0; i < args.max_msg_size; i++) {
+  for (uint64_t i = 0; i < args.max_msg_size; i++) {
     init_buf(source_buf[i], dest_buf[i]);
   }
 }
 
 template <typename T1>
 void TeamBroadcastTester<T1>::verifyResults(uint64_t size) {
-  for (int i = 0; i < size; i++) {
+  for (uint64_t i = 0; i < size; i++) {
     auto r = verify_buf(dest_buf[i]);
     if (r.first == false) {
-      fprintf(stderr, "Data validation error at idx %d\n", i);
+      fprintf(stderr, "Data validation error at idx %lu\n", i);
       fprintf(stderr, "%s.\n", r.second.c_str());
       exit(-1);
     }

tests/functional_tests/team_ctx_primitive_tester.cpp

@@ -120,9 +120,9 @@ void TeamCtxPrimitiveTester::verifyResults(uint64_t size) {
       (_type == TeamCtxGetTestType || _type == TeamCtxGetNBITestType) ? 0 : 1;
 
   if (args.myid == check_id) {
-    for (int i = 0; i < size; i++) {
+    for (uint64_t i = 0; i < size; i++) {
       if (r_buf[i] != '0') {
-        fprintf(stderr, "Data validation error at idx %d\n", i);
+        fprintf(stderr, "Data validation error at idx %lu\n", i);
         fprintf(stderr, "Got %c, Expected %c\n", r_buf[i], '0');
         exit(-1);
       }

tests/functional_tests/team_reduction_tester.cpp

@@ -153,7 +153,7 @@ void TeamReductionTester<T1, T2>::postLaunchKernel() {
 
 template <typename T1, ROCSHMEM_OP T2>
 void TeamReductionTester<T1, T2>::resetBuffers(uint64_t size) {
-  for (int i = 0; i < args.max_msg_size; i++) {
+  for (uint64_t i = 0; i < args.max_msg_size; i++) {
     init_buf(s_buf[i], r_buf[i]);
   }
 }
@@ -161,10 +161,10 @@ void TeamReductionTester<T1, T2>::resetBuffers(uint64_t size) {
 template <typename T1, ROCSHMEM_OP T2>
 void TeamReductionTester<T1, T2>::verifyResults(uint64_t size) {
   int n_pes = rocshmem_n_pes();
-  for (int i = 0; i < size; i++) {
+  for (uint64_t i = 0; i < size; i++) {
     auto r = verify_buf(r_buf[i], (T1)n_pes);
     if (r.first == false) {
-      fprintf(stderr, "Data validation error at idx %d\n", i);
+      fprintf(stderr, "Data validation error at idx %lu\n", i);
       fprintf(stderr, "%s.\n", r.second.c_str());
       exit(-1);
     }

tests/functional_tests/tester.cpp

@@ -653,7 +653,7 @@ uint64_t Tester::timerAvgInMicroseconds() {
    * TODO: (bpotter/avinash) Modify the calcuation for the Tiled version of
    *       puts and gets at wavefront level
   */
-  for (int i = 0; i < args.num_wgs; i++) {
+  for (uint64_t i = 0; i < args.num_wgs; i++) {
     sum += gpuCyclesToMicroseconds(timer[i]);
   }
 

tests/functional_tests/tester_arguments.hpp

@@ -62,8 +62,8 @@ class TesterArguments {
   /**
    * Arguments obtained from rocshmem
    */
-  unsigned numprocs = UINT_MAX;
-  unsigned myid = UINT_MAX;
+  int numprocs = INT_MAX;
+  int myid = INT_MAX;
 
   /**
    * Defaults tester values
@@ -71,7 +71,7 @@ class TesterArguments {
   int loop = 10;
   int skip = 10;
   int loop_large = 10;
-  int large_message_size = 32768;
+  uint64_t large_message_size = 32768;
 };
 
 #endif