From fa1ac559cbd85c30d93bb81b3263a95e9d55c94d Mon Sep 17 00:00:00 2001 From: Ben Sander Date: Fri, 5 May 2017 17:28:11 -0500 Subject: [PATCH] Fix some typos, add additional guidance for -BSymbolic [ROCm/clr commit: 9a026b62a8a4019d8125696081307cb5f6f4ecde] --- projects/clr/hipamd/docs/markdown/hip_bugs.md | 2 ++ projects/clr/hipamd/src/hip_memory.cpp | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/projects/clr/hipamd/docs/markdown/hip_bugs.md b/projects/clr/hipamd/docs/markdown/hip_bugs.md index abb31d80e8..91b2a5a019 100644 --- a/projects/clr/hipamd/docs/markdown/hip_bugs.md +++ b/projects/clr/hipamd/docs/markdown/hip_bugs.md @@ -45,6 +45,8 @@ To correct, add the following flag to hcc or hipcc: $ hipcc -Wl,-Bsymbolic ... ``` +Ensure there is no space in the "Wl,-Bsymbolic" option. + ### What is the current limitation of HIP Generic Grid Launch method? 1. __global__ functions cannot be marked as static or put in an unnamed namespace i.e. they cannot be given internal linkage (this would clash with __attribute__((weak))); diff --git a/projects/clr/hipamd/src/hip_memory.cpp b/projects/clr/hipamd/src/hip_memory.cpp index c4bc7db096..1ba698f461 100644 --- a/projects/clr/hipamd/src/hip_memory.cpp +++ b/projects/clr/hipamd/src/hip_memory.cpp @@ -104,8 +104,8 @@ void * allocAndSharePtr(const char *msg, size_t sizeBytes, ihipCtx_t *ctx, unsig auto device = ctx->getWriteableDevice(); ptr = hc::am_alloc(sizeBytes, device->_acc, amFlags); - tprintf(DB_MEM, " alloc %s ptr:%p size:%zu on dev:%d\n", - msg, ptr, sizeBytes, device->_deviceId); + tprintf(DB_MEM, " alloc %s ptr:%p-%p size:%zu on dev:%d\n", + msg, ptr, static_cast(ptr)+sizeBytes, sizeBytes, device->_deviceId); if (ptr != nullptr) { int r = sharePtr(ptr, ctx, hipFlags);