Generating hiprtc lib with hcc+hip-clang

Review comments - generate hiprtc lib everytime when HIP_PLATFORM is hcc

Changes for hip-clang

Removing pre processor directive to simplify

Change-Id: Id38ab368362b58ee0458baeb8051fea709ae6bba


[ROCm/hip commit: 54447268cc]
This commit is contained in:
Jatin Chaudhary authored and Tao Sang committed 2020-02-24 11:44:17 -05:00
1 parent b98cb2b0e0
commit fa2cc448de
3 files changed
+12 -18

No files matched your search

+2 -2
View File
@@ -235,7 +235,7 @@ struct _hiprtcProgram {
const auto it{find_if(reader.sections.begin(), reader.sections.end(),
[](const section* x) {
return x->get_name() == ".kernel";
return (x->get_name() == ".hip_fatbin") || (x->get_name() == ".kernel");
})};
if (it == reader.sections.end()) return false;
@@ -513,7 +513,7 @@ hiprtcResult hiprtcCompileProgram(hiprtcProgram p, int n, const char** o)
const auto src{p->writeTemporaryFiles(tmp.path())};
vector<string> args{hipcc, "-shared"};
vector<string> args{hipcc, "-fPIC -shared"};
if (n) args.insert(args.cend(), o, o + n);
handleTarget(args);