From fa377062e666df26167d5be81f1d324008a01df3 Mon Sep 17 00:00:00 2001 From: "Hernandez, Gerardo" Date: Thu, 12 Jun 2025 09:52:28 +0100 Subject: [PATCH] SWDEV-510589 - fix libgcc1 dependency on Debian 10 (#252) * fix libgcc1 should added to HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES and not HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES * add libgcc1 and not libgcc_s1 also to HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES as it seems rpms are also generated when compiling on Debian [ROCm/clr commit: 0877d257e691e05895cfadf34c4fffa2beccbaa4] --- projects/clr/hipamd/packaging/CMakeLists.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/projects/clr/hipamd/packaging/CMakeLists.txt b/projects/clr/hipamd/packaging/CMakeLists.txt index ef62e00088..f0f5e041e6 100644 --- a/projects/clr/hipamd/packaging/CMakeLists.txt +++ b/projects/clr/hipamd/packaging/CMakeLists.txt @@ -198,7 +198,15 @@ if(HIP_ENABLE_ROCPROFILER_REGISTER) set(HIP_RUNTIME_ROCM_PKG_DEPENDENCIES "${HIP_RUNTIME_ROCM_PKG_DEPENDENCIES}, rocprofiler-register") endif() -set(HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES "libnuma1, libstdc++6, libgcc-s1, libc6") +set(HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES "libnuma1, libstdc++6, libc6") + +if(DEB10_DISTRO) + # On Debian Buster only: libgcc_s.so.1 is in the package libgcc1 + set(HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES "${HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES}, libgcc1") +else() + set(HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES "${HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES}, libgcc-s1") +endif() + set(CPACK_DEBIAN_BINARY_PACKAGE_DEPENDS "${HIP_RUNTIME_ROCM_PKG_DEPENDENCIES}, ${HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES}") set(CPACK_DEBIAN_BINARY_PACKAGE_PROVIDES "hip-rocclr (= ${CPACK_PACKAGE_VERSION})") @@ -224,6 +232,7 @@ else() set(HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES "${HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES}, (libgcc or libgcc_s1)" ) endif() endif() + set(CPACK_RPM_BINARY_PACKAGE_REQUIRES "${HIP_RUNTIME_ROCM_PKG_DEPENDENCIES}, ${HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES}") set(CPACK_RPM_BINARY_PACKAGE_PROVIDES "hip-rocclr = ${HIP_BASE_VERSION}")