From fa90ca8669c51fb2fa9450d34ca5e063e0051679 Mon Sep 17 00:00:00 2001 From: Benjamin Welton Date: Tue, 12 Mar 2024 21:20:14 -0700 Subject: [PATCH] Disable test that checks dims (need AQL fake data support) (#612) * Disable test that checks dims (need AQL fake data support * source formatting (clang-format v11) (#613) Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com> [ROCm/rocprofiler-sdk commit: 2a262235dbe7102302fd94be1b3d7ba37b745c43] --- .../rocprofiler-sdk/counters/tests/core.cpp | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/core.cpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/core.cpp index a5243b46a9..d63f3d8af4 100644 --- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/core.cpp +++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/core.cpp @@ -181,28 +181,28 @@ buffered_callback(rocprofiler_context_id_t, } } - /** - * Specific counters default to a size of 128 even if they have less data (primarily - * TCP). This is a known quirk on AQL profile's end where it will allocate for 128 entries - * but return less (and the data may be duplicated across entries). Skip these entires for - * testing purposes since we cannot determine what mock data will be in the return (and its - * arch dependent). - */ - if(expected.expected_size == 128) return; + // /** + // * Specific counters default to a size of 128 even if they have less data (primarily + // * TCP). This is a known quirk on AQL profile's end where it will allocate for 128 entries + // * but return less (and the data may be duplicated across entries). Skip these entires for + // * testing purposes since we cannot determine what mock data will be in the return (and its + // * arch dependent). + // */ + // if(expected.expected_size == 128) return; - EXPECT_EQ(seen_dims.size(), expected.expected_size); - EXPECT_EQ(seen_data.size(), expected.expected_size); + // EXPECT_EQ(seen_dims.size(), expected.expected_size); + // EXPECT_EQ(seen_data.size(), expected.expected_size); - ASSERT_FALSE(seen_data.empty()); - if(expected.is_special) - { - EXPECT_EQ(*seen_data.begin(), expected.special_val); - } - else - { - EXPECT_EQ(*seen_data.begin(), 1.0); - EXPECT_EQ(*seen_data.rbegin(), double(seen_data.size())); - } + // ASSERT_FALSE(seen_data.empty()); + // if(expected.is_special) + // { + // EXPECT_EQ(*seen_data.begin(), expected.special_val); + // } + // else + // { + // EXPECT_EQ(*seen_data.begin(), 1.0); + // EXPECT_EQ(*seen_data.rbegin(), double(seen_data.size())); + // } } void