AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply constexpr on global constant varaibles

Browse Source 
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9d538b7abc6a0ce700ec3332b97fc144db5fc1ef
This commit is contained in:
Tao Sang
2020-07-14 20:10:24 -04:00
committed by Tao Sang
parent 2800fc2fa3
commit fdef6f722f
62 changed files with 224 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rocclr/utils/concurrent.hpp
+1 -1
View File
@@ -34,7 +34,7 @@ namespace amd { /*@{*/
namespace details {
template <typename T, int N> struct TaggedPointerHelper {
static const uintptr_t TagMask = (1u << N) - 1;
static constexpr uintptr_t TagMask = (1u << N) - 1;
private:
TaggedPointerHelper(); // Cannot instantiate
rocclr/utils/util.hpp
+7 -7
View File
@@ -55,13 +55,13 @@ template <> struct NextPowerOfTwoFunction<1> {
};
template <uint N, int S> struct NextPowerOfTwoHelper {
static const uint prev = NextPowerOfTwoHelper<N, S / 2>::value;
static const uint value = (prev >> S) | prev;
static constexpr uint prev = NextPowerOfTwoHelper<N, S / 2>::value;
static constexpr uint value = (prev >> S) | prev;
};
template <uint N> struct NextPowerOfTwoHelper<N, 1> { static const int value = (N >> 1) | N; };
template <uint N> struct NextPowerOfTwoHelper<N, 1> { static constexpr int value = (N >> 1) | N; };
template <uint N> struct NextPowerOfTwo {
static const uint value = NextPowerOfTwoHelper<N - 1, 16>::value + 1;
static constexpr uint value = NextPowerOfTwoHelper<N - 1, 16>::value + 1;
};
//! \endcond
@@ -83,10 +83,10 @@ template <typename T> inline T nextPowerOfTwo(T val) {
}
// Compute log2(N)
template <uint N> struct Log2 { static const uint value = Log2<N / 2>::value + 1; };
template <uint N> struct Log2 { static constexpr uint value = Log2<N / 2>::value + 1; };
// Break the recursion
template <> struct Log2<1> { static const uint value = 0; };
template <> struct Log2<1> { static constexpr uint value = 0; };
/*! \brief Return the log2 for a value of type T.
*
@@ -190,7 +190,7 @@ inline uint leastBitSet64(uint64_t value) {
#elif defined(__GNUC__)
return value ? __builtin_ctzll(value) : (uint)-1;
#else
static const uint8_t lookup67[67 + 1] = {
static constexpr uint8_t lookup67[67 + 1] = {
64, 0, 1, 39, 2, 15, 40, 23, 3, 12, 16, 59, 41, 19, 24, 54, 4, -1, 13, 10, 17, 62, 60,
28, 42, 30, 20, 51, 25, 44, 55, 47, 5, 32, -1, 38, 14, 22, 11, 58, 18, 53, 63, 9, 61, 27,
29, 50, 43, 46, 31, 37, 21, 57, 52, 8, 26, 49, 45, 36, 56, 7, 48, 35, 6, 34, 33, -1};