[SWDEV-498711] RDC Partition Implementation (#119)

* [SWDEV-498711] RDC Partition Implementation Change-Id: Ibfc3709793770537e4c9d36458f34c6b4f461724 Signed-off-by: adapryor <Adam.pryor@amd.com> [ROCm/rdc commit: 47692d3ed5]
2025-03-27 14:10:11 -05:00
parent 791fa376e9
commit fe868f6763
29 changed files with 1503 additions and 358 deletions
@@ -0,0 +1,54 @@
+/*
+Copyright (c) 2025 - present Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#ifndef INCLUDE_RDC_LIB_RDCENTITYCODEC_H_
+#define INCLUDE_RDC_LIB_RDCENTITYCODEC_H_
+
+#include "rdc/rdc.h"
+
+/*
+ *
+ * See rdc.h for description of entity_index
+ * Shifts and masks help get only the bits in question to decode/encode
+ *
+ * Ex, RDC_ENTITY_TYPE_SHIFT = 29 helps shift the 29 irrelevant bits, so we're
+ * only left with the top 3 type bits.
+ * Then, the corresponding 3 type bits are anded with the RDC_ENTITY_TYPE_MASK = 0x7
+ * which = 111 in binary, "copying" the type bits.
+ *
+ *
+ */
+static constexpr uint32_t RDC_ENTITY_TYPE_SHIFT = 29;
+static constexpr uint32_t RDC_ENTITY_ROLE_SHIFT = 27;
+static constexpr uint32_t RDC_ENTITY_INSTANCE_SHIFT = 11;
+static constexpr uint32_t RDC_ENTITY_DEVICE_SHIFT = 0;
+
+static constexpr uint32_t RDC_ENTITY_TYPE_MASK = 0x7;        // 3 bits for type.
+static constexpr uint32_t RDC_ENTITY_ROLE_MASK = 0x3;        // 2 bits for role.
+static constexpr uint32_t RDC_ENTITY_INSTANCE_MASK = 0x3FF;  // 10 bits for instance.
+static constexpr uint32_t RDC_ENTITY_DEVICE_MASK = 0x3FF;    // 10 bits for device.
+
+rdc_entity_info_t rdc_get_info_from_entity_index(uint32_t entity_index);
+uint32_t rdc_get_entity_index_from_info(rdc_entity_info_t info);
+bool rdc_is_partition_string(const char* s);
+bool rdc_parse_partition_string(const char* s, uint32_t* physicalGpu, uint32_t* partition);
+
+#endif  // INCLUDE_RDC_LIB_RDCENTITYCODEC_H_
@@ -116,7 +116,7 @@ class RdcHandler {
  virtual rdc_status_t rdc_health_check(rdc_gpu_group_t group_id,
                                        rdc_health_response_t* response) = 0;
  virtual rdc_status_t rdc_health_clear(rdc_gpu_group_t group_id) = 0;
-    // topology API
+  // topology API
  virtual rdc_status_t rdc_device_topology_get(uint32_t gpu_index,
                                               rdc_device_topology_t* results) = 0;
  virtual rdc_status_t rdc_link_status_get(rdc_link_status_t* results) = 0;
@@ -131,6 +131,12 @@ class RdcHandler {
  // Clear the setting
  virtual rdc_status_t rdc_config_clear(rdc_gpu_group_t group_id) = 0;

+  virtual rdc_status_t rdc_get_num_partition(uint32_t index, uint16_t* num_partition) = 0;
+
+  virtual rdc_status_t rdc_instance_profile_get(uint32_t entity_index,
+                                                rdc_instance_resource_type_t resource_type,
+                                                rdc_resource_profile_t* profile) = 0;
+
  virtual ~RdcHandler() {}
 };

@@ -0,0 +1,47 @@
+/*
+Copyright (c) 2025 - present Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#ifndef INCLUDE_RDC_LIB_RDCPARTITION_H_
+#define INCLUDE_RDC_LIB_RDCPARTITION_H_
+
+#include <memory>
+
+#include "rdc/rdc.h"
+
+namespace amd {
+namespace rdc {
+
+class RdcPartition {
+ public:
+  virtual rdc_status_t rdc_instance_profile_get_impl(uint32_t entity_index,
+                                                     rdc_instance_resource_type_t resource_type,
+                                                     rdc_resource_profile_t* profile) = 0;
+
+  virtual rdc_status_t rdc_get_num_partition_impl(uint32_t index, uint16_t* num_partition) = 0;
+
+  virtual ~RdcPartition() {}
+};
+typedef std::shared_ptr<RdcPartition> RdcPartitionPtr;
+
+}  // namespace rdc
+}  // namespace amd
+
+#endif  // INCLUDE_RDC_LIB_RDCPARTITION_H_
@@ -32,6 +32,7 @@ THE SOFTWARE.
 #include "rdc_lib/RdcMetricsUpdater.h"
 #include "rdc_lib/RdcModuleMgr.h"
 #include "rdc_lib/RdcNotification.h"
+#include "rdc_lib/RdcPartition.h"
 #include "rdc_lib/RdcPolicy.h"
 #include "rdc_lib/RdcTopologyLink.h"
 #include "rdc_lib/RdcWatchTable.h"
@@ -121,7 +122,7 @@ class RdcEmbeddedHandler final : public RdcHandler {
  rdc_status_t rdc_health_check(rdc_gpu_group_t group_id, rdc_health_response_t* response) override;
  rdc_status_t rdc_health_clear(rdc_gpu_group_t group_id) override;
  rdc_status_t rdc_device_topology_get(uint32_t gpu_index, rdc_device_topology_t* results) override;
-  
+
  rdc_status_t rdc_link_status_get(rdc_link_status_t* results) override;

  // Set one configure
@@ -134,11 +135,18 @@ class RdcEmbeddedHandler final : public RdcHandler {
  // Clear the setting
  rdc_status_t rdc_config_clear(rdc_gpu_group_t group_id) override;

+  rdc_status_t rdc_get_num_partition(uint32_t index, uint16_t* num_partition) override;
+
+  rdc_status_t rdc_instance_profile_get(uint32_t entity_index,
+                                        rdc_instance_resource_type_t resource_type,
+                                        rdc_resource_profile_t* profile) override;
+
  explicit RdcEmbeddedHandler(rdc_operation_mode_t op_mode);
  ~RdcEmbeddedHandler() final;

 private:
  rdc_status_t get_gpu_gauges(rdc_gpu_gauges_t* gpu_gauges);
+  RdcPartitionPtr partition_;
  RdcGroupSettingsPtr group_settings_;
  RdcCacheManagerPtr cache_mgr_;
  RdcMetricFetcherPtr metric_fetcher_;
@@ -150,7 +158,6 @@ class RdcEmbeddedHandler final : public RdcHandler {
  RdcTopologyLinkPtr topologylink_;
  RdcConfigSettingsPtr config_handler_;
  std::future<void> updater_;
-  
 };

 }  // namespace rdc
@@ -28,6 +28,7 @@ THE SOFTWARE.
 #include <string>

 #include "rdc_lib/RdcGroupSettings.h"
+#include "rdc_lib/impl/RdcPartitionImpl.h"

 namespace amd {
 namespace rdc {
@@ -51,7 +52,7 @@ class RdcGroupSettingsImpl : public RdcGroupSettings {
  rdc_status_t rdc_group_field_get_all_ids(rdc_field_grp_t field_group_id_list[],
                                           uint32_t* count) override;

-  RdcGroupSettingsImpl();
+  explicit RdcGroupSettingsImpl(const RdcPartitionPtr& partition);

 private:
  std::map<rdc_gpu_group_t, rdc_group_info_t> gpu_group_;
@@ -60,6 +61,7 @@ class RdcGroupSettingsImpl : public RdcGroupSettings {
  uint32_t cur_field_group_id_ = 0;
  std::mutex group_mutex_;
  std::mutex field_group_mutex_;
+  RdcPartitionPtr partition_;
 };

 }  // namespace rdc
@@ -0,0 +1,44 @@
+/*
+Copyright (c) 2025 - present Advanced Micro Devices, Inc. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+*/
+#ifndef INCLUDE_RDC_LIB_IMPL_RDCPARTITIONIMPL_H_
+#define INCLUDE_RDC_LIB_IMPL_RDCPARTITIONIMPL_H_
+
+#include <memory>
+
+#include "rdc/rdc.h"
+#include "rdc_lib/RdcPartition.h"
+
+namespace amd {
+namespace rdc {
+
+class RdcPartitionImpl : public RdcPartition {
+ public:
+  rdc_status_t rdc_instance_profile_get_impl(uint32_t entity_index,
+                                             rdc_instance_resource_type_t resource_type,
+                                             rdc_resource_profile_t* profile);
+  rdc_status_t rdc_get_num_partition_impl(uint32_t index, uint16_t* num_partition);
+};
+
+}  // namespace rdc
+}  // namespace amd
+
+#endif  // INCLUDE_RDC_LIB_IMPL_RDCPARTITIONIMPL_H_
@@ -126,9 +126,15 @@ class RdcStandaloneHandler : public RdcHandler {
  rdc_status_t rdc_health_check(rdc_gpu_group_t group_id, rdc_health_response_t* response) override;
  rdc_status_t rdc_health_clear(rdc_gpu_group_t group_id) override;
  rdc_status_t rdc_device_topology_get(uint32_t gpu_index, rdc_device_topology_t* results) override;
-  
+
  rdc_status_t rdc_link_status_get(rdc_link_status_t* results) override;

+  rdc_status_t rdc_get_num_partition(uint32_t index, uint16_t* num_partition) override;
+
+  rdc_status_t rdc_instance_profile_get(uint32_t entity_index,
+                                        rdc_instance_resource_type_t resource_type,
+                                        rdc_resource_profile_t* profile) override;
+
  explicit RdcStandaloneHandler(const char* ip_and_port, const char* root_ca,
                                const char* client_cert, const char* client_key);

@@ -23,6 +23,8 @@ THE SOFTWARE.
 #ifndef INCLUDE_RDC_LIB_IMPL_RSMIUTILS_H_
 #define INCLUDE_RDC_LIB_IMPL_RSMIUTILS_H_

+#include <vector>
+
 #include "amd_smi/amdsmi.h"
 #include "rdc/rdc.h"

@@ -33,6 +35,12 @@ rdc_status_t Smi2RdcError(amdsmi_status_t rsmi);
 amdsmi_status_t get_processor_handle_from_id(uint32_t gpu_id,
                                             amdsmi_processor_handle* processor_handle);
 amdsmi_status_t get_processor_count(uint32_t& all_processor_count);
+amdsmi_status_t get_socket_handles(std::vector<amdsmi_socket_handle>& sockets);
+amdsmi_status_t get_processor_handles(amdsmi_socket_handle socket,
+                                      std::vector<amdsmi_processor_handle>& processors);
+amdsmi_status_t get_kfd_partition_id(amdsmi_processor_handle proc, uint32_t* partition_id);
+amdsmi_status_t get_metrics_info(amdsmi_processor_handle proc, amdsmi_gpu_metrics_t* metrics);
+amdsmi_status_t get_num_partition(uint32_t index, uint16_t* num_partition);

 }  // namespace rdc
 }  // namespace amd