AI/rocm-systems
2
0
Forkuj 0
Kod Zgłoszenia Oczekujące zmiany Actions Packages Projekty Wydania Wiki Aktywność
76 333 Commity 3 Gałęzie 0 Tagi
develop
Wykres commitów

6425 Commity

Autor SHA1 Wiadomość Data
Evgeny Mankov 2cd2afa84b [HIPIFY][perl][fix] Treat ::device_function as a device function 
+ Do not treat somenamespace::device_function_name as a device function
+ Fix generation of warnUnsupportedDeviceFunctions function in hipify-clang
+ Update hipify-perl based on hipify-clang -perl generation
+ Update device test math_functions.cu for hipify-perl

[Restrictions]
- hipify-perl is yet unable to handle function declarations in user namespaces
- hipify-perl is yet unable to handle using directive


[ROCm/hip commit: 4f59ec25fe]
 2019-09-16 17:36:55 +03:00
Evgeny Mankov a1fcf145f3 [HIPIFY] Fix build failure due to typo in [#1377] 
[ROCm/hip commit: 3f66e7b0b9]
 2019-09-16 14:28:52 +03:00
mhbliao 2a58af4380 [HIP] Remove a circular including. (#1418) 
[ROCm/hip commit: 1f8c3bbd3b]
 2019-09-16 08:32:47 +00:00
satyanveshd fe1fae3ec2 Fix checks in hipMemcpy[D/H]to[D/H]() (#1397) 
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/hip commit: cfbd0e77fe]
 2019-09-16 08:32:38 +00:00
AlexBinXie d86d4d674d [hip]Skip test when hipHostMallocCoherent is not supported by implementation (#1380) 
[ROCm/hip commit: 5ed1f3e2c8]
 2019-09-16 08:31:43 +00:00
ansurya b5549f4397 Added new device attributes (#1377) 
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/hip commit: ceb734b917]
 2019-09-16 08:31:30 +00:00
Aryan Salmanpour 9e9a505b39 [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368) 
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting


[ROCm/hip commit: bac52d3729]
 2019-09-16 08:31:17 +00:00
Aryan Salmanpour 8e18dee555 [hip][tests] add a unit test for testing hipLaunchCooperativeKernel (#1361) 
* [hip][tests] add a unit test for testing hipLaunchCooperativeKernel

* use __ockl_grid_sync function

* remove already defined __ockl_grid_sync function

* use sync function for grid synchronization


[ROCm/hip commit: 48880a017e]
 2019-09-16 08:31:09 +00:00
Evgeny Mankov 8e1256aa00 [HIPIFY] Scripting related refactoring 
+ Move generating hipify-perl and hipify-python into separate namespaces and files
+ Move getAbsoluteFilePath and getAbsoluteDirectoryPath to StringUtils


[ROCm/hip commit: b7df0627b1]
 2019-09-15 21:13:56 +03:00
Evgeny Mankov 202b65876d [HIPIFY][perl] Syn with hipify-clang 
[ROCm/hip commit: 287ceac229]
 2019-09-15 15:25:40 +03:00
Evgeny Mankov 019d08d2f0 [HIPIFY][perl] Generate sub warnUnsupportedDeviceFunctions 
[ROCm/hip commit: fd8a7675f8]
 2019-09-15 15:18:58 +03:00
Evgeny Mankov 37d2ddc72b Merge pull request #1417 from emankov/master 
[HIPIFY][doc] Update README.md

[ROCm/hip commit: 6770e993a4]
 2019-09-13 18:58:22 +03:00
Evgeny Mankov 7a6f9d0e3e [HIPIFY][doc] Update README.md 
+ Adding -DLLVM_TARGETS_TO_BUILD="NVPTX" to LLVM's cmake command line for minimizing LLVM's build (tested)
+ Test logs update
+ Versions update


[ROCm/hip commit: 182058fa0b]
 2019-09-13 18:56:48 +03:00
foreman ed83e2e992 P4 to Git Change 1997981 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/13 11:17:32 
SWDEV-203438 - [HIP] AllGather RCCL test issue
	The test tries to launch a kernel on two devices at once and they need to communicate with each other.
	For that, it uses a custom stream for each devices.
	Problem is in getNullStream we used to call syncStreams all the time
	and it was syncing all the streams even the ones on different devices.
	So that made the second kernel launch (on 2n dev) to wait for the first kernel to finish which
	would never occur since the first one was waiting for the second one.
	The fix is to not call syncStreams from getNullStream because we sync already anyway prior in general.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#24 edit


[ROCm/hip commit: 184ee3f5a0]
 2019-09-13 11:28:33 -04:00
Rahul Garg 60adfab243 Fix typo and colon in comment 
[ROCm/hip commit: f0a1f95864]
 2019-09-13 03:09:01 +05:30
Rahul Garg e79f2d0ff8 [HACK] Temporary fix for hipFree for hipManagedMalloc 
[ROCm/hip commit: fe47b2185c]
 2019-09-13 02:10:21 +05:30
foreman e755a251e5 P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09 
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit


[ROCm/hip commit: a508c497ec]
 2019-09-12 14:35:36 -04:00
Evgeny Mankov bc550cc062 [HIPIFY] Add unsupported fp16 functions 
[ROCm/hip commit: 34540002dd]
 2019-09-12 18:51:25 +03:00
Evgeny Mankov 2863db60b2 [HIPIFY] Add more unsupported device functions 
[ROCm/hip commit: 58c1a144d1]
 2019-09-12 17:53:25 +03:00
Evgeny Mankov aae3b6dd50 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h 
[ROCm/hip commit: 0426035468]
 2019-09-11 18:07:09 +03:00
Evgeny Mankov 023e47adf1 Merge pull request #1406 from emankov/master 
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)

[ROCm/hip commit: ccf8ffc0c9]
 2019-09-11 15:49:46 +03:00
Evgeny Mankov ba10db6fc6 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl) 
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);


[ROCm/hip commit: 56ab105e9d]
 2019-09-10 15:59:06 +03:00
Aditya Lad 0a90bd8c0f Replacment of RENAME command in CMakeLists.txt (#1402) 
[ROCm/hip commit: 90acfb809c]
 2019-09-10 08:35:16 +00:00
foreman 78ecb21bd6 P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42 
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit


[ROCm/hip commit: 66a6e703f2]
 2019-09-09 14:50:37 -04:00
foreman 7b8634a03c P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57 
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit


[ROCm/hip commit: f3e2d275c5]
 2019-09-09 14:42:47 -04:00
foreman bf11a2e460 P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36 
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit


[ROCm/hip commit: 8167dee7d5]
 2019-09-06 19:11:43 -04:00
Evgeny Mankov 17b734afde [HIPIFY] Add device functions support 
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.


[ROCm/hip commit: 6602fadc16]
 2019-09-06 18:34:12 +03:00
foreman d59a4d4b77 P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22 
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit


[ROCm/hip commit: 5db35686db]
 2019-09-06 04:33:24 -04:00
foreman 8e4664bd3b P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36 
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit


[ROCm/hip commit: ee1b139bd9]
 2019-09-05 16:45:19 -04:00
foreman cdf514589a P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40 
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit


[ROCm/hip commit: 3b5927d7fe]
 2019-09-05 14:34:47 -04:00
foreman e841213b5a P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44 
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit


[ROCm/hip commit: 485caa0602]
 2019-09-05 14:30:10 -04:00
foreman 4ee148290d P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26 
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit


[ROCm/hip commit: 9b5b4c4761]
 2019-09-05 14:12:32 -04:00
Jeff Daily 191482e1e4 fix bug where HIP_DB=1 seg faults at startup (#1388) 
[ROCm/hip commit: 8384f487ad]
 2019-09-05 10:04:19 +00:00
mhbliao 4913aec033 [hip] Stop using noduplicate and replace it with convergent. (#1390) 
[ROCm/hip commit: 119ee4b671]
 2019-09-05 10:03:43 +00:00
Paul Fultz II 9082a9990e Use hcc when building with hcc compiler (#1225) 
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME


[ROCm/hip commit: f6cf7e4e79]
 2019-09-05 10:03:04 +00:00
Evgeny Mankov 4d105b10ca [HIPIFY][cmake][#1394] Fix 
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7


[ROCm/hip commit: ab560d8fd2]
 2019-09-05 12:08:56 +03:00
Evgeny Mankov 5ba0d63058 [HIPIFY][perl] Code cleanup (preparation for generating) 
[ROCm/hip commit: 3a034a3427]
 2019-09-05 11:52:59 +03:00
foreman 6e0697f64f P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05 
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add


[ROCm/hip commit: 6b67514724]
 2019-09-04 17:16:03 -04:00
Evgeny Mankov 835b6481ea [HIPIFY][perl] Sync hipify-perl with hipify-clang 
Sync by means of semi-automatic generation: hipify-clang -perl


[ROCm/hip commit: 2a4c008385]
 2019-09-04 17:07:45 +03:00
Evgeny Mankov 2b06d68835 [HIPIFY][perl] Code cleanup and formatting 
[ROCm/hip commit: 5b8843a127]
 2019-09-04 16:37:26 +03:00
Evgeny Mankov 8896d276fe [HIPIFY][perl][#259] Fix 
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );


[ROCm/hip commit: b98330609b]
 2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 73b6fe599c Do not include cuda wappers for OMP for hip-clang (#1382) 
[ROCm/hip commit: 8fe8fc18c0]
 2019-09-03 05:13:59 +00:00
Rahul Garg 83d9c2769b Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381) 
This reverts commit 7dca0455e9.

[ROCm/hip commit: 6545521d6c]
 2019-09-03 05:13:46 +00:00
Nicholas Malaya 0915e29c6f Fix Broken Link in hip_porting_guide (#1376) 
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.

[ROCm/hip commit: 5a6eafcbf1]
 2019-09-03 05:13:35 +00:00
Sarbojit2019 fed6843ecf Removed hipLaunchKernel macro got missed in Merge (#1374) 
[ROCm/hip commit: e1f9e08ea7]
 2019-09-03 05:13:07 +00:00
Evgeny Mankov 29c8b80fc4 [HIPIFY][doc] Update README.md (testing, versions) 
[ROCm/hip commit: fbf23ed231]
 2019-09-02 18:18:43 +03:00
Evgeny Mankov a4af0f2fc1 [HIPIFY][tests] Add occupancy test 
[ROCm/hip commit: 1bf6deb149]
 2019-09-02 17:54:06 +03:00
Evgeny Mankov 8a0224db1d [HIPIFY][fix] Fix for upcoming LLVM 10.0 
[ROCm/hip commit: ce4140f94d]
 2019-09-01 18:15:03 +03:00
Sameer Sahasrabuddhe 8afbecf687 remove obsolete test for OCKL Asynchronous Streams 
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.


[ROCm/hip commit: 70023c9075]
 2019-08-30 20:41:29 +05:30
foreman 0b5aa5c913 P4 to Git Change 1991227 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/29 17:26:37 
SWDEV-193938 - [HIP] Use fine grained pool for hipHostRegister

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#43 edit


[ROCm/hip commit: d484ac0098]
 2019-08-29 17:35:38 -04:00