AI/rocm-systems
2
0 Fork 0
Código Issues Pull Requests Ações Pacotes Projetos Versões Wiki Atividade
76.333 Commits 3 Branches 0 Tags
develop
Gráfico de Commits
76333 Commits
Este Branch
Este Branch
Todos os Branches
Autor SHA1 Mensagem Data
Sean Keely 56ed5c8904 Refactor blocking sdma commands. 
Remove fence pool and use two signals.  Two signals allows overlapped
submission and copy while reducing thread busy polling.

Change-Id: Idb5f8e4c7f482a596ffce9e7799191fdd785a216
 2018-08-29 19:13:23 -04:00
Sean Keely 0af87e4a02 Refactor blocking sdma commands. 
Remove fence pool and use two signals.  Two signals allows overlapped
submission and copy while reducing thread busy polling.

Change-Id: Idb5f8e4c7f482a596ffce9e7799191fdd785a216


[ROCm/ROCR-Runtime commit: 56ed5c8904]
 2018-08-29 19:13:23 -04:00
Sean Keely e0839ab27e Implement SDMA copy rect for gfx9. 
Fix pitch overflow due to small element detection.
Add wide pitch 2D copy handling.
Cleanup code duplication.

Change-Id: I93b1584aba8e5964957eb7ab3544df806ca3e2f9
 2018-08-29 19:13:07 -04:00
Sean Keely 61b53915d7 Implement SDMA copy rect for gfx9. 
Fix pitch overflow due to small element detection.
Add wide pitch 2D copy handling.
Cleanup code duplication.

Change-Id: I93b1584aba8e5964957eb7ab3544df806ca3e2f9


[ROCm/ROCR-Runtime commit: e0839ab27e]
 2018-08-29 19:13:07 -04:00
foreman ad1839e9ee P4 to Git Change 1599701 by gandryey@gera-w8 on 2018/08/29 18:48:36 
SWDEV-79445 - OCL generic changes and code clean-up
	- Use SDMA staging transfers for data upload if pinning fails. Fixes HIP failure in a test that uses the code segment data for uppload.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#26 edit


[ROCm/clr commit: 45d50bb738]
 2018-08-29 18:57:40 -04:00
foreman 45d50bb738 P4 to Git Change 1599701 by gandryey@gera-w8 on 2018/08/29 18:48:36 
SWDEV-79445 - OCL generic changes and code clean-up
	- Use SDMA staging transfers for data upload if pinning fails. Fixes HIP failure in a test that uses the code segment data for uppload.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#26 edit
 2018-08-29 18:57:40 -04:00
foreman 0a5f1257f5 P4 to Git Change 1599699 by gandryey@gera-w8 on 2018/08/29 18:43:02 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move WaveLimiter logic to the abstract layer. PAL version was taken as the base, thus performance of GSL path can be affected by this change

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#315 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devwavelimiter.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/runtime/device/devwavelimiter.hpp#1 move/add
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#598 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#331 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#133 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#15 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#11 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#107 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#8 move/delete
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#8 move/delete


[ROCm/clr commit: 6cc75de90f]
 2018-08-29 18:54:19 -04:00
foreman 6cc75de90f P4 to Git Change 1599699 by gandryey@gera-w8 on 2018/08/29 18:43:02 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move WaveLimiter logic to the abstract layer. PAL version was taken as the base, thus performance of GSL path can be affected by this change

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#315 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devwavelimiter.cpp#1 move/add
... //depot/stg/opencl/drivers/opencl/runtime/device/devwavelimiter.hpp#1 move/add
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#598 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#331 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#133 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#15 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#11 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#107 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#8 move/delete
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#8 move/delete
 2018-08-29 18:54:19 -04:00
shaoyunl 30a4ab39f3 thunk: Avoid create PCIe indirect link on none large bar target 
PCIe P2P (indirect) IOLinks should only be created if the remote GPU
is large-BAR

Change-Id: I55cbb5e37c5d41267583e07aca6bdcc708403029
Signed-off-by: shaoyunl <Shaoyun.Liu@amd.com>
 2018-08-29 16:31:55 -04:00
shaoyunl 38a722523c thunk: Avoid create PCIe indirect link on none large bar target 
PCIe P2P (indirect) IOLinks should only be created if the remote GPU
is large-BAR

Change-Id: I55cbb5e37c5d41267583e07aca6bdcc708403029
Signed-off-by: shaoyunl <Shaoyun.Liu@amd.com>


[ROCm/ROCR-Runtime commit: 30a4ab39f3]
 2018-08-29 16:31:55 -04:00
Aaron Enye Shi 6ce7e12be9 __forceinline__ needs inline and always_inline 
Related to SWDEV-163084


[ROCm/clr commit: decf9beec9]
 2018-08-29 18:33:35 +00:00
Aaron Enye Shi decf9beec9 __forceinline__ needs inline and always_inline 
Related to SWDEV-163084
 2018-08-29 18:33:35 +00:00
Aaron Enye Shi 8a602184bb __forceinline__ needs inline and always_inline 
Related to SWDEV-163084


[ROCm/hip commit: e7352a1f4a]
 2018-08-29 18:33:35 +00:00
Aaron Enye Shi e7352a1f4a __forceinline__ needs inline and always_inline 
Related to SWDEV-163084
 2018-08-29 18:33:35 +00:00
Shaoyun Liu 7796994f46 Thunk: Avoid add indirect link for the GPUS with xGMI link 
Change-Id: I06f511c55e28919512fda79b504566818dc2a5ab
Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>
 2018-08-29 13:22:58 -04:00
Shaoyun Liu 71b392fdf8 Thunk: Avoid add indirect link for the GPUS with xGMI link 
Change-Id: I06f511c55e28919512fda79b504566818dc2a5ab
Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>


[ROCm/ROCR-Runtime commit: 7796994f46]
 2018-08-29 13:22:58 -04:00
foreman 5f5ea9af64 P4 to Git Change 1599472 by gandryey@gera-w8 on 2018/08/29 12:25:34 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move FindLocalWorkSize() logic to the abstraction layer
	- Replace the ROCr path with the common FindLocalWorkSize() functionality

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#227 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#314 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#330 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#132 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#63 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#67 edit


[ROCm/clr commit: 5ee211e801]
 2018-08-29 12:35:08 -04:00
foreman 5ee211e801 P4 to Git Change 1599472 by gandryey@gera-w8 on 2018/08/29 12:25:34 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move FindLocalWorkSize() logic to the abstraction layer
	- Replace the ROCr path with the common FindLocalWorkSize() functionality

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#227 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#314 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#330 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#132 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#63 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#67 edit
 2018-08-29 12:35:08 -04:00
Aaron Enye Shi 31864c4973 Remove testing bitinsert/extract on nvcc path 
[ROCm/clr commit: ecfb2bdeba]
 2018-08-29 15:29:53 +00:00
Aaron Enye Shi ecfb2bdeba Remove testing bitinsert/extract on nvcc path 2018-08-29 15:29:53 +00:00
Aaron Enye Shi 1a34cbc1c4 Remove testing bitinsert/extract on nvcc path 
[ROCm/hip commit: bbcb3fa0c0]
 2018-08-29 15:29:53 +00:00
Aaron Enye Shi bbcb3fa0c0 Remove testing bitinsert/extract on nvcc path 2018-08-29 15:29:53 +00:00
Yaxun Sam Liu 137880f369 Add clock() and clock64() 
[ROCm/clr commit: 0f4546deca]
 2018-08-29 10:51:00 -04:00
Yaxun Sam Liu 0f4546deca Add clock() and clock64() 2018-08-29 10:51:00 -04:00
Yaxun Sam Liu c1ab349fc7 Add clock() and clock64() 
[ROCm/hip commit: 1f74a66bea]
 2018-08-29 10:51:00 -04:00
Yaxun Sam Liu 1f74a66bea Add clock() and clock64() 2018-08-29 10:51:00 -04:00
fpadmin 68cdeeba66 Adding class size>8bytes tests 
[ROCm/clr commit: 19b5ac131a]
 2018-08-29 15:16:43 +05:30
fpadmin 19b5ac131a Adding class size>8bytes tests 2018-08-29 15:16:43 +05:30
fpadmin 65a48ce72e Adding class size>8bytes tests 
[ROCm/hip commit: 0022f53a10]
 2018-08-29 15:16:43 +05:30
fpadmin 0022f53a10 Adding class size>8bytes tests 2018-08-29 15:16:43 +05:30
foreman a48fcb65b2 P4 to Git Change 1599289 by chui@ocl-promo-incrementor on 2018/08/29 02:57:14 
SWDEV-2 - Change OpenCL version number from 2726 to 2727.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2474 edit


[ROCm/clr commit: 3f02c35aea]
 2018-08-29 03:07:58 -04:00
foreman 3f02c35aea P4 to Git Change 1599289 by chui@ocl-promo-incrementor on 2018/08/29 02:57:14 
SWDEV-2 - Change OpenCL version number from 2726 to 2727.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2474 edit
 2018-08-29 03:07:58 -04:00
xinhui pan a040a24243 kfdtest: Let BigBufferStressTest detect memory leak 
As it will alloc as much as small system memory to reach the allocation limit.
We can try to alloc memory several times to see if any allocation in
the previous step cause memory leak.

Also we test if GPU can access these memory correctly or not.

Change-Id: I309f9821b6bc99c212a6bfbc21fe3086ab589fd3
Signed-off-by: xinhui pan <xinhui.pan@amd.com>
 2018-08-28 22:50:42 -04:00
xinhui pan 4dce73a17c kfdtest: Let BigBufferStressTest detect memory leak 
As it will alloc as much as small system memory to reach the allocation limit.
We can try to alloc memory several times to see if any allocation in
the previous step cause memory leak.

Also we test if GPU can access these memory correctly or not.

Change-Id: I309f9821b6bc99c212a6bfbc21fe3086ab589fd3
Signed-off-by: xinhui pan <xinhui.pan@amd.com>


[ROCm/ROCR-Runtime commit: a040a24243]
 2018-08-28 22:50:42 -04:00
foreman 6d60a084ba P4 to Git Change 1599194 by gandryey@gera-w8 on 2018/08/28 18:38:33 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move printf setup in the kernels to the abstraction layer

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#329 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#131 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.cpp#47 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#238 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#71 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprintf.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprintf.hpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#25 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprintf.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprintf.hpp#6 edit


[ROCm/clr commit: ef83d84899]
 2018-08-28 18:48:05 -04:00
foreman ef83d84899 P4 to Git Change 1599194 by gandryey@gera-w8 on 2018/08/28 18:38:33 
SWDEV-79445 - OCL generic changes and code clean-up
	- Move printf setup in the kernels to the abstraction layer

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#329 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#131 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.cpp#47 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprintf.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#238 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#71 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprintf.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprintf.hpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#25 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprintf.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprintf.hpp#6 edit
 2018-08-28 18:48:05 -04:00
foreman 0eb2d36332 P4 to Git Change 1599157 by gandryey@gera-ocl-lc on 2018/08/28 17:11:04 
SWDEV-79445 - OCL generic changes and code clean-up
	- Add devkerenle.cpp/hpp files for device::Kernel object
	- Move generic code for the arguments setup from the device layer to the abstraction layer
	- Update ROCr and PAL paths to utilize the generic logic for the arguments setup

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#226 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#313 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#328 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#130 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#61 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/runtime/runtimedefs#51 edit


[ROCm/clr commit: 5cfeb120ed]
 2018-08-28 17:30:29 -04:00
foreman 5cfeb120ed P4 to Git Change 1599157 by gandryey@gera-ocl-lc on 2018/08/28 17:11:04 
SWDEV-79445 - OCL generic changes and code clean-up
	- Add devkerenle.cpp/hpp files for device::Kernel object
	- Move generic code for the arguments setup from the device layer to the abstraction layer
	- Update ROCr and PAL paths to utilize the generic logic for the arguments setup

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#226 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#313 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#328 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#130 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#61 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/runtime/runtimedefs#51 edit
 2018-08-28 17:30:29 -04:00
Aaron Enye Shi 7801c309b3 Add tests for bitextract and bitinsert 
[ROCm/clr commit: 622342f01d]
 2018-08-28 20:01:54 +00:00
Aaron Enye Shi 622342f01d Add tests for bitextract and bitinsert 2018-08-28 20:01:54 +00:00
Aaron Enye Shi 31a34f6804 Add tests for bitextract and bitinsert 
[ROCm/hip commit: 5893bbc1f4]
 2018-08-28 20:01:54 +00:00
Aaron Enye Shi 5893bbc1f4 Add tests for bitextract and bitinsert 2018-08-28 20:01:54 +00:00
Aaron Enye Shi 3a7ad8a604 Add bitinsert64 to device functions 
[ROCm/clr commit: 031c0204d8]
 2018-08-28 20:01:14 +00:00
Aaron Enye Shi 031c0204d8 Add bitinsert64 to device functions 2018-08-28 20:01:14 +00:00
Aaron Enye Shi 9619457b1f Add bitinsert64 to device functions 
[ROCm/hip commit: ba9fc6f355]
 2018-08-28 20:01:14 +00:00
Aaron Enye Shi ba9fc6f355 Add bitinsert64 to device functions 2018-08-28 20:01:14 +00:00
Aaron Enye Shi 06a68d3eb6 Clean up and add meaningful variables to bit funcs 
[ROCm/clr commit: 24429eabb0]
 2018-08-28 18:19:48 +00:00
Aaron Enye Shi 24429eabb0 Clean up and add meaningful variables to bit funcs 2018-08-28 18:19:48 +00:00
Aaron Enye Shi eb2e7e0671 Clean up and add meaningful variables to bit funcs 
[ROCm/hip commit: b939a3c6ed]
 2018-08-28 18:19:48 +00:00
Aaron Enye Shi b939a3c6ed Clean up and add meaningful variables to bit funcs 2018-08-28 18:19:48 +00:00