SWDEV-143465 - Fix crashes while mixed work with hsail and amdil (legacy) paths
Redirect (where it is possible) ACL API calls from HSAIL lib to legacy AMDIL lib if target is AMDIL.
For those functions (aclCreateFromBinary, aclReadFromMem), where redirect is impossible, explicit loadLibrary for AMDIL lib and call of corresponding function from AMDIL lib is performed.
[Reviewed] by Stas (http://ocltc.amd.com/reviews/r/14238)
[Testing] rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#30 edit
[ROCm/clr commit: a9ac031e6e]
SWDEV-143465 - Fix crashes while mixed work with hsail and amdil (legacy) paths
Redirect (where it is possible) ACL API calls from HSAIL lib to legacy AMDIL lib if target is AMDIL.
For those functions (aclCreateFromBinary, aclReadFromMem), where redirect is impossible, explicit loadLibrary for AMDIL lib and call of corresponding function from AMDIL lib is performed.
[Reviewed] by Stas (http://ocltc.amd.com/reviews/r/14238)
[Testing] rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#30 edit
SWDEV-2 - Change OpenCL version number from 2589 to 2590.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2337 edit
[ROCm/clr commit: 8548f9262e]
SWDEV-2 - Change OpenCL version number from 2589 to 2590.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2337 edit
- Added a new target "clangformat" which formats the code using the
clang-format tool found in HCC package.
- Renamed target "static_check" to "cppcheck".
- Use find_program() macro to make the build system more robust.
Change-Id: Ifefbf36f23ff7ef27a870120d5b9170d0cc8aa52
[ROCm/clr commit: 6ef0c494d1]
- Added a new target "clangformat" which formats the code using the
clang-format tool found in HCC package.
- Renamed target "static_check" to "cppcheck".
- Use find_program() macro to make the build system more robust.
Change-Id: Ifefbf36f23ff7ef27a870120d5b9170d0cc8aa52
- Added a new target "clangformat" which formats the code using the
clang-format tool found in HCC package.
- Renamed target "static_check" to "cppcheck".
- Use find_program() macro to make the build system more robust.
Change-Id: Ifefbf36f23ff7ef27a870120d5b9170d0cc8aa52
[ROCm/hip commit: 1e559d19c3]
- Added a new target "clangformat" which formats the code using the
clang-format tool found in HCC package.
- Renamed target "static_check" to "cppcheck".
- Use find_program() macro to make the build system more robust.
Change-Id: Ifefbf36f23ff7ef27a870120d5b9170d0cc8aa52
SWDEV-2 - Change OpenCL version number from 2588 to 2589.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2336 edit
[ROCm/clr commit: 94025b9c3b]
Maneesh Gupta
foreman
Chris Freehill
Evgeny
Alex Voicu