EPR #010002 - Change OpenCL version number from 1810 to 1811.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1557 edit
EPR #419347 - Fix a d3d9 memory leak.
According to https://msdn.microsoft.com/en-us/library/windows/desktop/bb174386(v=vs.85).aspx: Calling IDirect3DDevice9::GetDirect3D will increase the internal reference count on the IDirect3D9 interface. Failure to call IUnknown::Release when finished using this IDirect3D9 interface results in a memory leak..
Although p3d9devEx->Release() has the same effect as p3d9dev->Release(), for clarification we better use p3d9dev->Release() instead.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceD3D9.cpp#13 edit
[ROCm/clr commit: 6d913bfc23]
EPR #419347 - Fix a d3d9 memory leak.
According to https://msdn.microsoft.com/en-us/library/windows/desktop/bb174386(v=vs.85).aspx: Calling IDirect3DDevice9::GetDirect3D will increase the internal reference count on the IDirect3D9 interface. Failure to call IUnknown::Release when finished using this IDirect3D9 interface results in a memory leak..
Although p3d9devEx->Release() has the same effect as p3d9dev->Release(), for clarification we better use p3d9dev->Release() instead.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceD3D9.cpp#13 edit
EPR #010002 - Change OpenCL version number from 1809 to 1810.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1556 edit
[ROCm/clr commit: f329e3fc66]
EPR #010002 - Change OpenCL version number from 1809 to 1810.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1556 edit
ECR #304775 - Mipmaps support in OpenCL
- Enable PAD2 bit for miplevel views
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#218 edit
EPR #010002 - Change OpenCL version number from 1808 to 1809.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1555 edit
[ROCm/clr commit: 60c0f95fa6]
EPR #010002 - Change OpenCL version number from 1808 to 1809.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1555 edit
EPR #010002 - Change OpenCL version number from 1807 to 1808.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1554 edit
[ROCm/clr commit: d9a4d01b17]
EPR #010002 - Change OpenCL version number from 1807 to 1808.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1554 edit
EPR #010002 - Change OpenCL version number from 1806 to 1807.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1553 edit
[ROCm/clr commit: 6a1476d1ce]
EPR #010002 - Change OpenCL version number from 1806 to 1807.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1553 edit
EPR #010002 - Change OpenCL version number from 1805 to 1806.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1552 edit
[ROCm/clr commit: 6852d41216]
EPR #010002 - Change OpenCL version number from 1805 to 1806.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1552 edit
EPR #403782 - IOMMU2/SVM
- Update the caching and hit logic for resource cache to reflect allocation attributes for SVM. Else it can give wrong hits leading to hangs if a regular surface is used for shader upload etc. IOMMUv2 strictly needs shader and command buffers to have EXECUTE attribute.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7572/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#217 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.hpp#80 edit
[ROCm/clr commit: 4f338e5578]
EPR #403782 - IOMMU2/SVM
- Update the caching and hit logic for resource cache to reflect allocation attributes for SVM. Else it can give wrong hits leading to hangs if a regular surface is used for shader upload etc. IOMMUv2 strictly needs shader and command buffers to have EXECUTE attribute.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7572/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#217 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.hpp#80 edit
EPR #397491 - Disabling generic address space on 32 bit windows too for now.
Back out revision 116 from //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#117 edit
[ROCm/clr commit: 24ac37876f]
EPR #397491 - Disabling generic address space on 32 bit windows too for now.
Back out revision 116 from //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#117 edit
EPR #397491 - According to HSA-Finalizer-ADD, for GPUVM32 private_segment_aperture_base_hi and group_segment_aperture_base_hi should be equal to the 32 bits of the 32 bit private and group segment flat address aperture.
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#362 edit
[ROCm/clr commit: 9d37ac1fc8]
EPR #397491 - According to HSA-Finalizer-ADD, for GPUVM32 private_segment_aperture_base_hi and group_segment_aperture_base_hi should be equal to the 32 bits of the 32 bit private and group segment flat address aperture.
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#362 edit
EPR #010002 - Change OpenCL version number from 1804 to 1805.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1551 edit
[ROCm/clr commit: a24f070742]
EPR #010002 - Change OpenCL version number from 1804 to 1805.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1551 edit
ECR #333756 - HSA Finalizer: Make sure size of kernarg segment, alignment of kernarg, private and group segments are multiple of 16. Update ORCA runtime assert. [ OpenCL integration of CL 1151953]
Change by Nikolay Haustov
Testing: http://ocltc:8111/viewModification.html?modId=51851&personal=true&init=1&tab=vcsModificationBuilds
Also fix uncovered problem in test.
Testing: pre-checkin
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/sc/HSAIL/hsail-fin/HSAILFinalizer.cpp#16 integrate
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/sc/HSAIL/tests/src/finalizer/features/structural_analysis/short_circuit/short_circuit06.hsail#4 integrate
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#284 edit
[ROCm/clr commit: 4cffcd3997]
ECR #333756 - HSA Finalizer: Make sure size of kernarg segment, alignment of kernarg, private and group segments are multiple of 16. Update ORCA runtime assert. [ OpenCL integration of CL 1151953]
Change by Nikolay Haustov
Testing: http://ocltc:8111/viewModification.html?modId=51851&personal=true&init=1&tab=vcsModificationBuilds
Also fix uncovered problem in test.
Testing: pre-checkin
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/sc/HSAIL/hsail-fin/HSAILFinalizer.cpp#16 integrate
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/sc/HSAIL/tests/src/finalizer/features/structural_analysis/short_circuit/short_circuit06.hsail#4 integrate
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#284 edit
EPR #010002 - Change OpenCL version number from 1803 to 1804.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1550 edit
[ROCm/clr commit: 7fa12b2bc8]
EPR #010002 - Change OpenCL version number from 1803 to 1804.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1550 edit
EPR #403782 - IOMMU2/SVM
- Disable DX interop on SVM. This is a feature for SVM and may need more work.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7555/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#310 edit
[ROCm/clr commit: 915592103f]
EPR #403782 - IOMMU2/SVM
- Disable DX interop on SVM. This is a feature for SVM and may need more work.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7555/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#310 edit
EPR #010002 - Change OpenCL version number from 1802 to 1803.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1549 edit
[ROCm/clr commit: ebe57f6e94]
EPR #010002 - Change OpenCL version number from 1802 to 1803.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1549 edit
ECR #304775 - Mipmaps support
- Following CL#1151650. Change the comparison condition to 1.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#216 edit
ECR #304775 - Mipmaps support
- Enable miplevel flag even for the first mip level when runtime creates a view. Otherwise GSL may change the pitch alignment for the created view.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#215 edit
[ROCm/clr commit: b8c761b199]
ECR #304775 - Mipmaps support
- Enable miplevel flag even for the first mip level when runtime creates a view. Otherwise GSL may change the pitch alignment for the created view.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#215 edit
EPR #418590 - Fix improper check for temp path.
- Existing code will change temp path to "." if tempPath is "C:\Windows\Temp\"
- Need to make sure temp path will be changed to "." if tempPath is "C:\Windows\" or "C:\Windows"
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/os/os_win32.cpp#44 edit
[ROCm/clr commit: 4b5f8c85fa]
EPR #418590 - Fix improper check for temp path.
- Existing code will change temp path to "." if tempPath is "C:\Windows\Temp\"
- Need to make sure temp path will be changed to "." if tempPath is "C:\Windows\" or "C:\Windows"
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/os/os_win32.cpp#44 edit
EPR #397491 - Disable generic address space only on 32 bit Linux
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#116 edit
[ROCm/clr commit: dd63bd7d18]
EPR #397491 - Disable generic address space only on 32 bit Linux
Reviewed by: German
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#116 edit
EPR #412821 - Fix a crash when the ThreadTrace Object is freed before a ThreadTrace command is processed.
Also change 'None' to 'Undefined', since 'None' is a macro defined in X.h.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#77 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/threadtrace.hpp#5 edit
[ROCm/clr commit: 5da96e702c]
EPR #412821 - Fix a crash when the ThreadTrace Object is freed before a ThreadTrace command is processed.
Also change 'None' to 'Undefined', since 'None' is a macro defined in X.h.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#77 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/threadtrace.hpp#5 edit
foreman
Oded Gabbay