* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.
Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692
[ROCm/clr commit: da5f1a6146]
* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.
Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692
Skip CPU agents when fetching metrics. Only fetch metrics for GPU
agents.
Co-authored-by: Benjamin Welton <ben@amd.com>
[ROCm/rocprofiler-sdk commit: 0c4a583e23]
* Updated validation of aborted-app test to use hipExtHostAlloc now that tracing for this command is supported
* Updated CHANGELOG
[ROCm/rocprofiler-sdk commit: 5dd2f94f74]
new command includes following arguments:
- current - display the current partition information for the selected
gpu(s)
- memory - display memory partition information for the selected
gpu(s)
- accelerator - display accelerator partition information for the
selected gpu(s)
additional functionality will be added as more partition APIs are added.
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Change-Id: Ica86160139002ef5213d6d4b0e390670aeef01c8
new command includes following arguments:
- current - display the current partition information for the selected
gpu(s)
- memory - display memory partition information for the selected
gpu(s)
- accelerator - display accelerator partition information for the
selected gpu(s)
additional functionality will be added as more partition APIs are added.
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Change-Id: Ica86160139002ef5213d6d4b0e390670aeef01c8
[ROCm/amdsmi commit: 4e2fc2d604]
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure
Signed-off-by: coleramos425 <colramos@amd.com>
* Apply linting feedback
Signed-off-by: coleramos425 <colramos@amd.com>
* Update links in MAINTAINERS for new branches
Signed-off-by: coleramos425 <colramos@amd.com>
* Update MAINTAINERS.md for changelog formatting
Signed-off-by: coleramos425 <colramos@amd.com>
* Update Omniperf ver checker to allow tags with rocm- prefix
Signed-off-by: coleramos425 <colramos@amd.com>
* Add step to packaging workflow to upload release tarball to release
Signed-off-by: coleramos425 <colramos@amd.com>
* Synax change for release name in packaging action
Signed-off-by: coleramos425 <colramos@amd.com>
* Update MAINTAINERS for instuctions on ROCm releases
Signed-off-by: coleramos425 <colramos@amd.com>
* Update softprops pluvin to v2 and remove release name
Removing the release name enables us to modify an existing release with the matching tag
Signed-off-by: coleramos425 <colramos@amd.com>
* Remove draft option on softprops plugin
Signed-off-by: coleramos425 <colramos@amd.com>
---------
Signed-off-by: coleramos425 <colramos@amd.com>
[ROCm/rocprofiler-compute commit: d2e806d1aa]
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure
Signed-off-by: coleramos425 <colramos@amd.com>
* Apply linting feedback
Signed-off-by: coleramos425 <colramos@amd.com>
* Update links in MAINTAINERS for new branches
Signed-off-by: coleramos425 <colramos@amd.com>
* Update MAINTAINERS.md for changelog formatting
Signed-off-by: coleramos425 <colramos@amd.com>
* Update Omniperf ver checker to allow tags with rocm- prefix
Signed-off-by: coleramos425 <colramos@amd.com>
* Add step to packaging workflow to upload release tarball to release
Signed-off-by: coleramos425 <colramos@amd.com>
* Synax change for release name in packaging action
Signed-off-by: coleramos425 <colramos@amd.com>
* Update MAINTAINERS for instuctions on ROCm releases
Signed-off-by: coleramos425 <colramos@amd.com>
* Update softprops pluvin to v2 and remove release name
Removing the release name enables us to modify an existing release with the matching tag
Signed-off-by: coleramos425 <colramos@amd.com>
* Remove draft option on softprops plugin
Signed-off-by: coleramos425 <colramos@amd.com>
---------
Signed-off-by: coleramos425 <colramos@amd.com>
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add support for MI300X_A1
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove MI308X identification using num CUs, and format Python using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add Read the Docs
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add sphinx requirement
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove gpu_model identification using gpu_arch
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Fix Python formatting using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
[ROCm/rocprofiler-compute commit: c9773c157e]
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add support for MI300X_A1
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove MI308X identification using num CUs, and format Python using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add Read the Docs
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Add sphinx requirement
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove gpu_model identification using gpu_arch
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.
Signed-off-by: xuchen-amd <xuchen@amd.com>
* Fix Python formatting using black.
Signed-off-by: xuchen-amd <xuchen@amd.com>
---------
Signed-off-by: xuchen-amd <xuchen@amd.com>
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request
Signed-off-by: coleramos425 <colramos@amd.com>
[ROCm/rocprofiler-compute commit: 369b93bf46]
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request
Signed-off-by: coleramos425 <colramos@amd.com>
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work
Signed-off-by: coleramos425 <colramos@amd.com>
[ROCm/rocprofiler-compute commit: 5bc6b50b0b]
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work
Signed-off-by: coleramos425 <colramos@amd.com>
* Remove `dev` and `main` branch from workflows.
Update links in documentation.
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* `amd-staging` -> `amd-mainline` in docs
Signed-off-by: Peter Jun Park <peter.park@amd.com>
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Peter Jun Park <peter.park@amd.com>
Co-authored-by: Peter Jun Park <peter.park@amd.com>
[ROCm/rocprofiler-compute commit: 7c7705d2ba]
* Remove `dev` and `main` branch from workflows.
Update links in documentation.
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* `amd-staging` -> `amd-mainline` in docs
Signed-off-by: Peter Jun Park <peter.park@amd.com>
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: Peter Jun Park <peter.park@amd.com>
Co-authored-by: Peter Jun Park <peter.park@amd.com>
* Check that the minimum required Python (3.8) version is used.
Prints a descriptive error message, rather than a cryptic import
failure, if minimum Python version is not met.
Internal ticket SWDEV-477233.
* Disable the RPM mangling of shebangs.
The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
With this set, omniperf is always using the platform installed version
of python, which is python 3.6 on RHEL 8. Using virtual environments,
like conda, did not work.
* Fix pylint issues
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
[ROCm/rocprofiler-compute commit: cfeea83785]
* Check that the minimum required Python (3.8) version is used.
Prints a descriptive error message, rather than a cryptic import
failure, if minimum Python version is not met.
Internal ticket SWDEV-477233.
* Disable the RPM mangling of shebangs.
The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
With this set, omniperf is always using the platform installed version
of python, which is python 3.6 on RHEL 8. Using virtual environments,
like conda, did not work.
* Fix pylint issues
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Vladana Stojiljkovic
Jaydeep Patel
Jeffrey Novotny
Benjamin Welton
itrowbri
Maisam Arif
Galantsev, Dmitrii
gabrpham
David Galiffi
coleramos425
cfallows-amd
xuchen-amd
Daniel Su
Peter Park