76333 Commits

Author SHA1 Message Date
Chris Freehill f8d63e2fb4 hsakmt: Update amdp2ptest.c license to MIT
Change-Id: I1eb814dbb4b420840d9877fc6a4806708754ac69
2024-09-19 19:44:53 +00:00
Chris Freehill 297ccd2244 hsakmt: Update amdp2ptest.c license to MIT
Change-Id: I1eb814dbb4b420840d9877fc6a4806708754ac69


[ROCm/ROCR-Runtime commit: f8d63e2fb4]
2024-09-19 19:44:53 +00:00
David Yat Sin d6ec7b6489 rocr: Remove unnecessary function declarations
Change-Id: Ia2613ce74cac808f9239fc24049b57b7b1abaed9
2024-09-19 19:44:53 +00:00
David Yat Sin 3189a6b827 rocr: Remove unnecessary function declarations
Change-Id: Ia2613ce74cac808f9239fc24049b57b7b1abaed9


[ROCm/ROCR-Runtime commit: d6ec7b6489]
2024-09-19 19:44:53 +00:00
David Yat Sin 12e299e8d4 rocr: Fix compile error
Change-Id: Iae6bf08e834a426f6f97cbc51d2a1a38199015bd
2024-09-19 19:44:53 +00:00
David Yat Sin c4874743ce rocr: Fix compile error
Change-Id: Iae6bf08e834a426f6f97cbc51d2a1a38199015bd


[ROCm/ROCR-Runtime commit: 12e299e8d4]
2024-09-19 19:44:53 +00:00
Shweta Khatri c30ff893a6 Add rocprofiler-register dependency to build
Ensure rocprofiler-register is linked and added to DEB and RPM package dependencies.
Github ticket - https://github.com/ROCm/ROCm/issues/3654

Change-Id: Iaaaca8bfa81ca33da147673ef1be798109b70aa5
2024-09-19 19:44:53 +00:00
Shweta Khatri 8fc24427e8 Add rocprofiler-register dependency to build
Ensure rocprofiler-register is linked and added to DEB and RPM package dependencies.
Github ticket - https://github.com/ROCm/ROCm/issues/3654

Change-Id: Iaaaca8bfa81ca33da147673ef1be798109b70aa5


[ROCm/ROCR-Runtime commit: c30ff893a6]
2024-09-19 19:44:53 +00:00
David Yat Sin 924e11ba7f rocr: Increase queue size for co-op queues
Increase queue-size for co-op queues to 16K to improve performance on
some workloads

Change-Id: I4d3bf0ecbd30ebb648b68d9c5fdabadc670a386c
2024-09-19 19:44:53 +00:00
David Yat Sin e000dabf8b rocr: Increase queue size for co-op queues
Increase queue-size for co-op queues to 16K to improve performance on
some workloads

Change-Id: I4d3bf0ecbd30ebb648b68d9c5fdabadc670a386c


[ROCm/ROCR-Runtime commit: 924e11ba7f]
2024-09-19 19:44:53 +00:00
David Yat Sin 3cb25e5236 rocrtst: Add negative test for invalid buffer free
Add a negative test to try to free the ring buffer of a queue and
confirm that a memory error is generated.

Change-Id: I4afd95c69c62f7c3e1138d5d6c4a5fd237631e43
2024-09-19 19:44:53 +00:00
David Yat Sin 97489aa2c2 rocrtst: Add negative test for invalid buffer free
Add a negative test to try to free the ring buffer of a queue and
confirm that a memory error is generated.

Change-Id: I4afd95c69c62f7c3e1138d5d6c4a5fd237631e43


[ROCm/ROCR-Runtime commit: 3cb25e5236]
2024-09-19 19:44:53 +00:00
Wang, Yanyao c064218637 Remove hard-coded llvm-project folder for rocrtst
Signed-off-by: Wang, Yanyao <yanyao.wang@amd.com>
Change-Id: I9ba81c1182da812596d7d314f3a6dae7cbcd0c2d
2024-09-19 19:44:53 +00:00
Wang, Yanyao 564ca754d1 Remove hard-coded llvm-project folder for rocrtst
Signed-off-by: Wang, Yanyao <yanyao.wang@amd.com>
Change-Id: I9ba81c1182da812596d7d314f3a6dae7cbcd0c2d


[ROCm/ROCR-Runtime commit: c064218637]
2024-09-19 19:44:53 +00:00
Saleel Kudchadker d5c396e820 SWDEV-301667 - Improve logging
Change-Id: I3fa06791b7ac73d84b8a9586e6b3435fa8858d25


[ROCm/clr commit: 8c84a20b01]
2024-09-19 15:09:03 -04:00
Saleel Kudchadker 8c84a20b01 SWDEV-301667 - Improve logging
Change-Id: I3fa06791b7ac73d84b8a9586e6b3435fa8858d25
2024-09-19 15:09:03 -04:00
kjayapra-amd f19260d568 SWDEV-480772 - Remove name variable from amd::Monitor class.
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e


[ROCm/clr commit: 12a39fbf22]
2024-09-19 11:55:01 -04:00
kjayapra-amd 12a39fbf22 SWDEV-480772 - Remove name variable from amd::Monitor class.
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e
2024-09-19 11:55:01 -04:00
Zhang Ava da7bf7e366 Merge amd-staging into amd-master 20240917
Signed-off-by: Zhang Ava <niandong.zhang@amd.com>
Change-Id: I198c849530508a90eee8ae5454035b9c610b3f5a


[ROCm/rocm_smi_lib commit: af2507807f]
2024-09-19 18:44:19 +08:00
Zhang Ava af2507807f Merge amd-staging into amd-master 20240917
Signed-off-by: Zhang Ava <niandong.zhang@amd.com>
Change-Id: I198c849530508a90eee8ae5454035b9c610b3f5a
2024-09-19 18:44:19 +08:00
Marko Arandjelovic fc3c26a2af SWDEV-465206 - Enable Unit_hipModuleLaunchCooperativeKernel_Negative_Parameters
Change-Id: I35037f1b6cae5416b724499ac916ba1a70f9556e


[ROCm/hip-tests commit: 0112ed5137]
2024-09-19 04:00:50 -04:00
Marko Arandjelovic 0112ed5137 SWDEV-465206 - Enable Unit_hipModuleLaunchCooperativeKernel_Negative_Parameters
Change-Id: I35037f1b6cae5416b724499ac916ba1a70f9556e
2024-09-19 04:00:50 -04:00
David Galiffi 5c2b64ddca Update data-collection-modes.rst (#386)
Fixed a typo.
"fewer than 1024 instructions" should be "at least 1024 instructions"

[ROCm/rocprofiler-systems commit: ce1cea95e4]
2024-09-18 21:05:56 -04:00
David Galiffi ce1cea95e4 Update data-collection-modes.rst (#386)
Fixed a typo.
"fewer than 1024 instructions" should be "at least 1024 instructions"
2024-09-18 21:05:56 -04:00
Charis Poag ede0e6318d Fix python unittest not installing amd-smi-lib-test package install
Moving to TESTS_COMPONENT allows files to be placed
within the amd-smi-lib-test package.
Previously, was put within the amd-smi-lib package,
which will never be triggered for installation with
latest changes.

Change-Id: Id49dbe69bfc7d5bd1af403c28b946fe1edf64d8e
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-09-18 19:25:48 -05:00
Charis Poag 34ff05c5bb Fix python unittest not installing amd-smi-lib-test package install
Moving to TESTS_COMPONENT allows files to be placed
within the amd-smi-lib-test package.
Previously, was put within the amd-smi-lib package,
which will never be triggered for installation with
latest changes.

Change-Id: Id49dbe69bfc7d5bd1af403c28b946fe1edf64d8e
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: ede0e6318d]
2024-09-18 19:25:48 -05:00
gilbertlee-amd d4094525c8 Fixing install.sh to properly accept spaces in ONLY_FUNCS (#1339)
[ROCm/rccl commit: 575afee5de]
2024-09-18 17:25:36 -06:00
gilbertlee-amd 575afee5de Fixing install.sh to properly accept spaces in ONLY_FUNCS (#1339) 2024-09-18 17:25:36 -06:00
Charis Poag 5c778cadf1 Fix amd-smi CLI calls returning TypeError
$ amd-smi version
TypeError: unsupported operand type(s) for |: 'type' and 'type'

---------------
Python3 --versions lower than 3.10
do not support str | None

Using typing Optional and Union, we can create equivalent logic for
str | none
and
str | list | none

Change-Id: I1f4a7ab67333914b33639dc62652881e1127411e
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-09-18 16:59:12 -05:00
Charis Poag b6a68dd877 Fix amd-smi CLI calls returning TypeError
$ amd-smi version
TypeError: unsupported operand type(s) for |: 'type' and 'type'

---------------
Python3 --versions lower than 3.10
do not support str | None

Using typing Optional and Union, we can create equivalent logic for
str | none
and
str | list | none

Change-Id: I1f4a7ab67333914b33639dc62652881e1127411e
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 5c778cadf1]
2024-09-18 16:59:12 -05:00
Marko Arandjelovic a261d1f49c Revert "SWDEV-441296 - Allign hipTexObjectCreate error handling to CUDA"
This reverts commit 2e7581a69a.

Changing the error code is considered as a breaking change,
so it should be done in major releases only.

The other reason for reverting the commit is that this change itself
is incorrect. Cuda behaves in the same way as hip when
pResDesc or pTexDesc are nullptr.

Change-Id: I3abee6b79279b81ab01c7f8466c7f8e3776c4109


[ROCm/clr commit: cfdc9dfc36]
2024-09-18 16:38:16 -04:00
Marko Arandjelovic cfdc9dfc36 Revert "SWDEV-441296 - Allign hipTexObjectCreate error handling to CUDA"
This reverts commit 7d3c0c5e10.

Changing the error code is considered as a breaking change,
so it should be done in major releases only.

The other reason for reverting the commit is that this change itself
is incorrect. Cuda behaves in the same way as hip when
pResDesc or pTexDesc are nullptr.

Change-Id: I3abee6b79279b81ab01c7f8466c7f8e3776c4109
2024-09-18 16:38:16 -04:00
Rahul Manocha c4cab41cc2 SWDEV-479575 - Add marker to parent graph dependencies in childgraph node
1) Child Graph nodes need to have parent graph dependencies in waitlist.
2) Marker is placed on base stream with parent graph waitlist

Change-Id: Iec65a0171ea387be05b0733abcc708fb630e4be4


[ROCm/clr commit: 4d1ded9eaf]
2024-09-18 15:12:50 -04:00
Rahul Manocha 4d1ded9eaf SWDEV-479575 - Add marker to parent graph dependencies in childgraph node
1) Child Graph nodes need to have parent graph dependencies in waitlist.
2) Marker is placed on base stream with parent graph waitlist

Change-Id: Iec65a0171ea387be05b0733abcc708fb630e4be4
2024-09-18 15:12:50 -04:00
Harkirat Gill d263b53797 Fix for GitHub Issue #24: Update Event Stop Behavior
amd-smi event is failing to exit as it waits for all threads to complete before exiting. Each thread has to listen for a maximum of 10 seconds prior to exiting in the current implementation.

Lowered individual listen time for _event_thread allowing for a quicker exit while still capturing all events (Looped until escape sequence detected).

Added logging for escape character, not sure if needed but helps confirm that key press was registered.

Change-Id: I916608754798f966980a558342c7c62693252d7f
2024-09-18 14:54:40 -04:00
Harkirat Gill e73ae3d79d Fix for GitHub Issue #24: Update Event Stop Behavior
amd-smi event is failing to exit as it waits for all threads to complete before exiting. Each thread has to listen for a maximum of 10 seconds prior to exiting in the current implementation.

Lowered individual listen time for _event_thread allowing for a quicker exit while still capturing all events (Looped until escape sequence detected).

Added logging for escape character, not sure if needed but helps confirm that key press was registered.

Change-Id: I916608754798f966980a558342c7c62693252d7f


[ROCm/amdsmi commit: d263b53797]
2024-09-18 14:54:40 -04:00
gabrpham b7f779182d [SWDEV-448738] Added rocmsmi extremum command as 'set -L'
Change-Id: I997c630bd20cc61673813a2301eb5e3002619a32
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>

Change-Id: Ifa884303f9a0fa058af093a23f5be449bba54f29
2024-09-18 14:51:01 -04:00
gabrpham fbb1071046 [SWDEV-448738] Added rocmsmi extremum command as 'set -L'
Change-Id: I997c630bd20cc61673813a2301eb5e3002619a32
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>

Change-Id: Ifa884303f9a0fa058af093a23f5be449bba54f29


[ROCm/amdsmi commit: b7f779182d]
2024-09-18 14:51:01 -04:00
Sam Wu 7475783cb9 Add dependabot config for updating documentation requirements (#1018)
[ROCm/rocprofiler-sdk commit: cc45896bf5]
2024-09-18 11:31:17 -06:00
Sam Wu cc45896bf5 Add dependabot config for updating documentation requirements (#1018) 2024-09-18 11:31:17 -06:00
pghafari 3fc58e93b3 SWDEV-444447 - Fix regression for verbose printing for AMD_LOG_LEVEL=4
Change-Id: Id245caef711b7ccdf4e999e934993beb43d7c3d5


[ROCm/clr commit: 365ffd4805]
2024-09-18 13:08:10 -04:00
pghafari 365ffd4805 SWDEV-444447 - Fix regression for verbose printing for AMD_LOG_LEVEL=4
Change-Id: Id245caef711b7ccdf4e999e934993beb43d7c3d5
2024-09-18 13:08:10 -04:00
Aryan Salmanpour 094386c727 update docs (#56)
* update docs

* remove extra line

* clean up

[ROCm/rocjpeg commit: c0ce1e45b0]
2024-09-18 12:56:20 -04:00
Aryan Salmanpour c0ce1e45b0 update docs (#56)
* update docs

* remove extra line

* clean up
2024-09-18 12:56:20 -04:00
spolifroni-amd 0cf8f6ee66 Added a note pointing users to the official documentation and removed the local build information. This info is in the contribution documentation. (#417)
[ROCm/rocdecode commit: 1d1f31f85c]
2024-09-18 12:00:55 -04:00
spolifroni-amd 1d1f31f85c Added a note pointing users to the official documentation and removed the local build information. This info is in the contribution documentation. (#417) 2024-09-18 12:00:55 -04:00
AravindanC e495390b7f SWDEV-342167, SWDEV-461080 - Remove Hard Coded Install Permission
Change-Id: Ie42cf83cc9a665715e76966378237d479202e0a7


[ROCm/hip-tests commit: 38eedf86cf]
2024-09-18 11:48:03 -04:00
AravindanC 38eedf86cf SWDEV-342167, SWDEV-461080 - Remove Hard Coded Install Permission
Change-Id: Ie42cf83cc9a665715e76966378237d479202e0a7
2024-09-18 11:48:03 -04:00
Rahul Manocha e46733affe SWDEV-439234 - Fix for Segfault in ValidateMemAccess
Change-Id: I251d277eb5af16ba5c0de85ffd142a5f64fa469d


[ROCm/clr commit: 07261002b1]
2024-09-18 10:52:32 -04:00
Rahul Manocha 07261002b1 SWDEV-439234 - Fix for Segfault in ValidateMemAccess
Change-Id: I251d277eb5af16ba5c0de85ffd142a5f64fa469d
2024-09-18 10:52:32 -04:00