76333 Commits

Auteur SHA1 Bericht Datum
Saleel Kudchadker dfb1087c3e SWDEV-422207 - Tag captured kernel names for graphs
Change-Id: I9540daa4abf9c340541a681037e2dca4eec821ed


[ROCm/clr commit: dfd4635f91]
2024-01-03 11:50:05 -05:00
Saleel Kudchadker dfd4635f91 SWDEV-422207 - Tag captured kernel names for graphs
Change-Id: I9540daa4abf9c340541a681037e2dca4eec821ed
2024-01-03 11:50:05 -05:00
Jonathan R. Madsen 2ccb156030 Contexts update + buffer flushing + cleanup (#338)
* Update lib/rocprofiler-sdk/context/context.*

- get_registered_contexts functions (local copy)

* Update lib/rocprofiler-sdk/hsa/{queue,queue_controller}.cpp

- remove ROCPROFILER_BUFFER_TRACING_MEMORY_COPY code

* Update tests/kernel-tracing/kernel-tracing.cpp

- move stop() and flush() in tool_fini to before reporting of sizes of data collected

* Update lib/rocprofiler-sdk/hsa/hsa.*

- remove stale set_callback / activity_functor_t code

* Update lib/rocprofiler-sdk/buffer.cpp

- full wait instead of returning busy when buffer is busy
- use task_group::join instead of task_group::wait to fully wait for tasks to finish (bug fix)

* Update lib/rocprofiler-sdk/agent.cpp

- support agent mapping for CPU agents

* Remove direct access to vector of registered contexts

[ROCm/rocprofiler-sdk commit: 199f0b5421]
2024-01-03 04:26:46 -06:00
Jonathan R. Madsen 199f0b5421 Contexts update + buffer flushing + cleanup (#338)
* Update lib/rocprofiler-sdk/context/context.*

- get_registered_contexts functions (local copy)

* Update lib/rocprofiler-sdk/hsa/{queue,queue_controller}.cpp

- remove ROCPROFILER_BUFFER_TRACING_MEMORY_COPY code

* Update tests/kernel-tracing/kernel-tracing.cpp

- move stop() and flush() in tool_fini to before reporting of sizes of data collected

* Update lib/rocprofiler-sdk/hsa/hsa.*

- remove stale set_callback / activity_functor_t code

* Update lib/rocprofiler-sdk/buffer.cpp

- full wait instead of returning busy when buffer is busy
- use task_group::join instead of task_group::wait to fully wait for tasks to finish (bug fix)

* Update lib/rocprofiler-sdk/agent.cpp

- support agent mapping for CPU agents

* Remove direct access to vector of registered contexts
2024-01-03 04:26:46 -06:00
Konstantin Zhuravlyov 326372ce2d Don't pass -fsc-use-buffer-for-hsa-global option in OCLPerfUncoalescedRead test
- This is an SC-only option

Change-Id: If9afe5f8e4ec6dbcf6ce1ca4406131ef92669f84


[ROCm/clr commit: 55e5b3d07a]
2024-01-02 23:13:45 -05:00
Konstantin Zhuravlyov 55e5b3d07a Don't pass -fsc-use-buffer-for-hsa-global option in OCLPerfUncoalescedRead test
- This is an SC-only option

Change-Id: If9afe5f8e4ec6dbcf6ce1ca4406131ef92669f84
2024-01-02 23:13:45 -05:00
Rahul Garg 7f80480816 SWDEV-439428 - Bump HIP Minor version for ROCm 6.1
Change-Id: Iacd0b8d5460103b7d0e449a1b4885459d5bb1159


[ROCm/hip commit: d85696e1f6]
2024-01-03 04:10:35 +00:00
Rahul Garg d85696e1f6 SWDEV-439428 - Bump HIP Minor version for ROCm 6.1
Change-Id: Iacd0b8d5460103b7d0e449a1b4885459d5bb1159
2024-01-03 04:10:35 +00:00
Jonathan R. Madsen 56fea9f08b Code Coverage Reporting (#334)
* Update lib/rocprofiler-sdk/counters/{tests,parser/tests}/CMakeLists.txt

- use rocprofiler-static-library instead of rocprofiler-object-library

* Update scripts/run-ci.py

- support gcovr and pycobertura

* Update CI workflow for code coverage

- load/save cache for XML code coverage (via gcovr)
- generate and write code coverage comment
- archive code coverage HTML report
- fix name for sanitizer jobs

* Update CI workflow

- tweaks to env for PATH and LD_LIBRARY_PATH

* Add scripts/upload-image-to-github.py

- script for saving images to orphan branches to be used in markdown links

* Update CI workflow

- fix upload artifact conflict
- use upload-image-to-github.py

* Update CI workflow

- install extra packages for wkhtmltopdf/wkhtmltoimage

* Update CI workflow (code coverage)

- install more recent git
- tweak package installs for wkhtmltopdf/wkhtmltoimage

* Update CI workflow (code coverage)

- remove duplicate --cap-add=SYS_PTRACE

* Update CI and upload-image-to-github.py

- print versions

* Update upload-image-to-github.py

- check exit code of some subprocesses

* Update CI workflow

- fix GITHUB_PATH ordering
- fix LD_LIBRARY_PATH

* Update CI workflow

- fix code coverage cache keys (use SHAs)
- copy .codecov to .codecov.ref if a cached .codecov exists

* Update upload-image-to-github.py

- Update git pull/push commands

* Update upload-image-to-github.py

- git fetch before pulling
- git pull before committing

* Update upload-image-to-github.py

- git fetch after committing
- git pull after committing

* Update CI workflow

- list files before cat

* Update upload-image-to-github.py

- output messages

* Update CI workflow and upload-image-to-github.py

- fix output directory path for script to work with CI workflow

* Update CI workflow

- finishing touches/fixes on the code coverage comment generation

* Reproducible filenames

* Update CI workflow

- fix archive of code coverage data

* Fix relative path of reproducible file loc

* Update upload-image-to-github.py

- change update method

* rocprofiler-v2-internal -> rocprofiler-sdk-internal

[ROCm/rocprofiler-sdk commit: c5e45803e9]
2024-01-02 19:22:43 -06:00
Jonathan R. Madsen c5e45803e9 Code Coverage Reporting (#334)
* Update lib/rocprofiler-sdk/counters/{tests,parser/tests}/CMakeLists.txt

- use rocprofiler-static-library instead of rocprofiler-object-library

* Update scripts/run-ci.py

- support gcovr and pycobertura

* Update CI workflow for code coverage

- load/save cache for XML code coverage (via gcovr)
- generate and write code coverage comment
- archive code coverage HTML report
- fix name for sanitizer jobs

* Update CI workflow

- tweaks to env for PATH and LD_LIBRARY_PATH

* Add scripts/upload-image-to-github.py

- script for saving images to orphan branches to be used in markdown links

* Update CI workflow

- fix upload artifact conflict
- use upload-image-to-github.py

* Update CI workflow

- install extra packages for wkhtmltopdf/wkhtmltoimage

* Update CI workflow (code coverage)

- install more recent git
- tweak package installs for wkhtmltopdf/wkhtmltoimage

* Update CI workflow (code coverage)

- remove duplicate --cap-add=SYS_PTRACE

* Update CI and upload-image-to-github.py

- print versions

* Update upload-image-to-github.py

- check exit code of some subprocesses

* Update CI workflow

- fix GITHUB_PATH ordering
- fix LD_LIBRARY_PATH

* Update CI workflow

- fix code coverage cache keys (use SHAs)
- copy .codecov to .codecov.ref if a cached .codecov exists

* Update upload-image-to-github.py

- Update git pull/push commands

* Update upload-image-to-github.py

- git fetch before pulling
- git pull before committing

* Update upload-image-to-github.py

- git fetch after committing
- git pull after committing

* Update CI workflow

- list files before cat

* Update upload-image-to-github.py

- output messages

* Update CI workflow and upload-image-to-github.py

- fix output directory path for script to work with CI workflow

* Update CI workflow

- finishing touches/fixes on the code coverage comment generation

* Reproducible filenames

* Update CI workflow

- fix archive of code coverage data

* Fix relative path of reproducible file loc

* Update upload-image-to-github.py

- change update method

* rocprofiler-v2-internal -> rocprofiler-sdk-internal
2024-01-02 19:22:43 -06:00
Jatin Chaudhary 626287b229 SWDEV-436233 - document hiprtc cu/wgp mode changes
Change-Id: I477f3b53f3695c94eaefbcefb20d6ea91fb0dca0


[ROCm/hip commit: 838e587a24]
2024-01-02 17:46:40 -05:00
Jatin Chaudhary 838e587a24 SWDEV-436233 - document hiprtc cu/wgp mode changes
Change-Id: I477f3b53f3695c94eaefbcefb20d6ea91fb0dca0
2024-01-02 17:46:40 -05:00
Jatin Chaudhary 937678b4f6 SWDEV-436233 - fix the cumode in hiprtc
cumode should be active when wgp mode is off

Change-Id: I12f2e55d942ddeb0fb4470de7abc3caff1f430f7


[ROCm/clr commit: 49369f0851]
2024-01-02 17:43:32 -05:00
Jatin Chaudhary 49369f0851 SWDEV-436233 - fix the cumode in hiprtc
cumode should be active when wgp mode is off

Change-Id: I12f2e55d942ddeb0fb4470de7abc3caff1f430f7
2024-01-02 17:43:32 -05:00
jeffqjiangNew 7ee24483ff * rocDecode/HEVC: Fixed a bug in destroy data buffer function in VAAPI layer. (#150)
- We have to clear the buffer id after destroying it. Without this clearing, we will encounter VAAPI buffer destroy failure on certain conformance streams where scaling list is signaled dynamically. In this case, we create different number of data buffers on different frames. If we do not clear the buffer id when destroying it, a dummy scaling list buffer id will have the same value as another buffer, resulting double destroy.

[ROCm/rocdecode commit: 33d6b37ddb]
2024-01-02 15:56:18 -05:00
jeffqjiangNew 33d6b37ddb * rocDecode/HEVC: Fixed a bug in destroy data buffer function in VAAPI layer. (#150)
- We have to clear the buffer id after destroying it. Without this clearing, we will encounter VAAPI buffer destroy failure on certain conformance streams where scaling list is signaled dynamically. In this case, we create different number of data buffers on different frames. If we do not clear the buffer id when destroying it, a dummy scaling list buffer id will have the same value as another buffer, resulting double destroy.
2024-01-02 15:56:18 -05:00
jeffqjiangNew 2b9ea06e5c * rocDecode/HEVC: Fixed an issue in reference list reconstruction. (#149)
- Removed a size check which was put in in early bring up stage and causes some conformance stream failures.
  - Also capped the DPB buffer size to 16 when we increase it from the spec value.

[ROCm/rocdecode commit: 6db0b79144]
2024-01-02 15:55:52 -05:00
jeffqjiangNew 6db0b79144 * rocDecode/HEVC: Fixed an issue in reference list reconstruction. (#149)
- Removed a size check which was put in in early bring up stage and causes some conformance stream failures.
  - Also capped the DPB buffer size to 16 when we increase it from the spec value.
2024-01-02 15:55:52 -05:00
Giovanni Lenzi Baraldi 32127d2f76 Gbaraldi/navi3fix (#318)
* Adding Navi3x gate fixes

* Making reproducible runtime more reproducible

* source formatting (clang-format v11) (#319)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Update lib/common/utility.hpp

- revert

* Update lib/common/environment.{hpp,cpp}

- support get_env for various integral types

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- query ROCPROFILER_GATE_CAPACITY in ctor of active_capacity_gate

* Update tests/apps/reproducible-runtime

- fix help message
- misc float vs. double changes
- update output messages

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 3d539c1677]
2024-01-02 16:12:02 -03:00
Giovanni Lenzi Baraldi 3d539c1677 Gbaraldi/navi3fix (#318)
* Adding Navi3x gate fixes

* Making reproducible runtime more reproducible

* source formatting (clang-format v11) (#319)

Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>

* Update lib/common/utility.hpp

- revert

* Update lib/common/environment.{hpp,cpp}

- support get_env for various integral types

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- query ROCPROFILER_GATE_CAPACITY in ctor of active_capacity_gate

* Update tests/apps/reproducible-runtime

- fix help message
- misc float vs. double changes
- update output messages

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-01-02 16:12:02 -03:00
Giovanni LB 137aef0419 Changed MI300 GFX
Change-Id: I3ed497d5517df226d9d03a1d5ebc7d515efd1fab
2024-01-02 12:54:54 -05:00
Giovanni LB 7914a557bc Changed MI300 GFX
Change-Id: I3ed497d5517df226d9d03a1d5ebc7d515efd1fab


[ROCm/rocprofiler commit: 137aef0419]
2024-01-02 12:54:54 -05:00
German 4750a76899 SWDEV-404889 - Enable debugger interface in PAL
Add GPU_DEBUG_ENABLE to control ttpm behavior. If enabled,
then HW will collect more debug info at some perf cost

Change-Id: Icee0686b903a7b1bd483710b9d611877cd43c6aa


[ROCm/clr commit: 7d661bc7df]
2024-01-02 11:51:42 -05:00
German 7d661bc7df SWDEV-404889 - Enable debugger interface in PAL
Add GPU_DEBUG_ENABLE to control ttpm behavior. If enabled,
then HW will collect more debug info at some perf cost

Change-Id: Icee0686b903a7b1bd483710b9d611877cd43c6aa
2024-01-02 11:51:42 -05:00
Satyanvesh Dittakavi f423584145 SWDEV-379212 - Handle template kernels with hiprtc lowered names
Change-Id: Ib8e6493a1f342f92a35031d5ee39b2e22132b56a


[ROCm/clr commit: dc8f66b86f]
2024-01-02 03:28:28 -05:00
Satyanvesh Dittakavi dc8f66b86f SWDEV-379212 - Handle template kernels with hiprtc lowered names
Change-Id: Ib8e6493a1f342f92a35031d5ee39b2e22132b56a
2024-01-02 03:28:28 -05:00
Giovanni LB bc9ada7d34 SWDEV-437776: ATT fix for s_delay_salu
Change-Id: I962c40c4c4fa2583a235e8185a056fdb69e44c78
2023-12-31 14:42:30 -05:00
Giovanni LB 40c312234d SWDEV-437776: ATT fix for s_delay_salu
Change-Id: I962c40c4c4fa2583a235e8185a056fdb69e44c78


[ROCm/rocprofiler commit: bc9ada7d34]
2023-12-31 14:42:30 -05:00
dependabot[bot] 8d1fc8d773 Bump actions/upload-pages-artifact from 2 to 3 (#327)
[ROCm/rocprofiler-sdk commit: 3eac7ce2e8]
2023-12-30 04:48:49 +00:00
dependabot[bot] 3eac7ce2e8 Bump actions/upload-pages-artifact from 2 to 3 (#327) 2023-12-30 04:48:49 +00:00
dependabot[bot] 416acd877f Bump actions/deploy-pages from 3 to 4 (#326)
[ROCm/rocprofiler-sdk commit: 567bdf746e]
2023-12-30 03:46:44 +00:00
dependabot[bot] 567bdf746e Bump actions/deploy-pages from 3 to 4 (#326) 2023-12-30 03:46:44 +00:00
Giovanni LB cc518909c5 SWDEV-437776: Fixing ATT CSV ordering
Change-Id: If111b9a2d4354a036693795cfbc18e87899f1f1c
2023-12-29 16:16:55 -03:00
Giovanni LB bb54d71939 SWDEV-437776: Fixing ATT CSV ordering
Change-Id: If111b9a2d4354a036693795cfbc18e87899f1f1c


[ROCm/rocprofiler commit: cc518909c5]
2023-12-29 16:16:55 -03:00
Ioannis Assiouras 4046aa4c72 SWDEV-439209 - Fixed Unit_hipMemVmm_Basic
Change-Id: I658d30e9ab7814517383d02550c338e5aeae554e


[ROCm/hip-tests commit: 9131d555f9]
2023-12-29 11:22:14 +00:00
Ioannis Assiouras 9131d555f9 SWDEV-439209 - Fixed Unit_hipMemVmm_Basic
Change-Id: I658d30e9ab7814517383d02550c338e5aeae554e
2023-12-29 11:22:14 +00:00
Yifan Zhang 808a4428b6 kfdtest: add APUs judgement in LargestVramBufferTest criteria
This patch is to add APUs judgement in LargestVramBufferTest criteria.

Change-Id: Ic69093f8ebed8be0b1c58787e2a294d86fb49bb0
2023-12-28 17:17:31 +08:00
Yifan Zhang 29820a0887 kfdtest: add APUs judgement in LargestVramBufferTest criteria
This patch is to add APUs judgement in LargestVramBufferTest criteria.

Change-Id: Ic69093f8ebed8be0b1c58787e2a294d86fb49bb0


[ROCm/ROCR-Runtime commit: 808a4428b6]
2023-12-28 17:17:31 +08:00
Yifan Zhang 92c0015787 kfdtest: finetune MMBench subtest criteria
Change the proportion to 6/10 on APUs.

Change-Id: I3576cb23d0f14ff6d576a5db4bdeef9446aa10d2
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
2023-12-28 17:12:44 +08:00
Yifan Zhang f5125d542a kfdtest: finetune MMBench subtest criteria
Change the proportion to 6/10 on APUs.

Change-Id: I3576cb23d0f14ff6d576a5db4bdeef9446aa10d2
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>


[ROCm/ROCR-Runtime commit: 92c0015787]
2023-12-28 17:12:44 +08:00
Giovanni LB 25a02fe03e SWDEV-437776: Fixing typo for in stitch.py. Fixing singleDispatch kernel name.
Change-Id: I8d65598fffa4f15f78a64f741fdcb9a4a77af2a0
2023-12-27 18:08:39 -05:00
Giovanni LB 064f77ecf3 SWDEV-437776: Fixing typo for in stitch.py. Fixing singleDispatch kernel name.
Change-Id: I8d65598fffa4f15f78a64f741fdcb9a4a77af2a0


[ROCm/rocprofiler commit: 25a02fe03e]
2023-12-27 18:08:39 -05:00
Giovanni LB 1c5bf0b96e SWDEV-437442: Re-enable CTF plugin
Change-Id: I290c6504c76b715c6d3bdfd2da6d7e5656cf8dfe
2023-12-27 17:17:37 -05:00
Giovanni LB dbcf4ffd09 SWDEV-437442: Re-enable CTF plugin
Change-Id: I290c6504c76b715c6d3bdfd2da6d7e5656cf8dfe


[ROCm/rocprofiler commit: 1c5bf0b96e]
2023-12-27 17:17:37 -05:00
Yifan Zhang 72324444cc kfdtest: finetune LargestVramBuffer subtest criteria
Change the proportion to 3/5 on APUs.

Change-Id: I0dc37fb1c309605811551b88259473603c81f9ae
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
2023-12-27 16:23:17 +08:00
Yifan Zhang 1c0d18bce6 kfdtest: finetune LargestVramBuffer subtest criteria
Change the proportion to 3/5 on APUs.

Change-Id: I0dc37fb1c309605811551b88259473603c81f9ae
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>


[ROCm/ROCR-Runtime commit: 72324444cc]
2023-12-27 16:23:17 +08:00
Ruili Ji 4b69351394 To fix sdma segment fault for error address
pad_size address shall start from command_addr not
(command_addr + total_command_size)

Change-Id: I3d8491986caf2d4d5dc41b1d90286c21e7c0a457
2023-12-25 09:31:13 +08:00
Ruili Ji ff2c3dfcca To fix sdma segment fault for error address
pad_size address shall start from command_addr not
(command_addr + total_command_size)

Change-Id: I3d8491986caf2d4d5dc41b1d90286c21e7c0a457


[ROCm/ROCR-Runtime commit: 4b69351394]
2023-12-25 09:31:13 +08:00
Jonathan R. Madsen 2e56a928ee Merge branch 'amd-mainline' into amd-staging
[ROCm/rocprofiler-register commit: f785235543]
2023-12-21 21:56:10 -06:00
Jonathan R. Madsen f785235543 Merge branch 'amd-mainline' into amd-staging 2023-12-21 21:56:10 -06:00