76333 Commits

Author SHA1 Message Date
David DeBonis a4943c512e Update CODEOWNERS (#154)
* Update CODEOWNERS

Adding me as a reviewer

* Update .github/CODEOWNERS

Co-authored-by: Nilesh M Negi <Nilesh.Negi@amd.com>

* Update CODEOWNERS

Added Alex

---------

Co-authored-by: Nilesh M Negi <Nilesh.Negi@amd.com>
2025-10-01 07:07:28 -06:00
Edgar Gabriel 53fa35b980 Remove MPI compile-time dependency (#264)
* use dlsym for MPI functions

to allow compiling without MPI support, convert the usage of MPI functions and symbols to be based on a dlopen/dlsym based mechanism. Turns out this cannot be done entirely vendor neutral, slightly different solutions might be required for Open MPI, MPICH and the new MPI ABI.

* checkpoint

more work to be done.

* checkpoint 2

* checkpoint 3

* checkpoint 4

examples compile and link correctly

* checkpoitn 5 (I think)

* Checkpoitn 6

* dyld-mpi: adapt GDA

* dyldmpi: tests that depend on MPI need to link with it themselves

* do not ../mpi_instance.h

* dyldmpi: make the symetricHeapTestFixture compile

* dyldmpi: Change cmakery, compiles and run gda w/o external MPI

* Make it also compile in external MPI mode

* dyldmpi: ipc unit tests compile but do not link

* dyldmpi: new approach, if external mpi required, link with mpi,
otherwise use ompi5 abi

* C-style comments in cmakelist..

* dyldmpi: examples: do not fail compiling if MPI not found at build time,
instead do not compile the MPI required examples

* more updates to CMake logic

* convert RO backend

and a few other cleanups

* update some unit tests

to work with the dlopen MPI environment correctly.

---------

Co-authored-by: Aurelien Bouteiller <abouteil@amd.com>

[ROCm/rocshmem commit: e4c427a736]
2025-10-01 08:06:56 -05:00
Edgar Gabriel e4c427a736 Remove MPI compile-time dependency (#264)
* use dlsym for MPI functions

to allow compiling without MPI support, convert the usage of MPI functions and symbols to be based on a dlopen/dlsym based mechanism. Turns out this cannot be done entirely vendor neutral, slightly different solutions might be required for Open MPI, MPICH and the new MPI ABI.

* checkpoint

more work to be done.

* checkpoint 2

* checkpoint 3

* checkpoint 4

examples compile and link correctly

* checkpoitn 5 (I think)

* Checkpoitn 6

* dyld-mpi: adapt GDA

* dyldmpi: tests that depend on MPI need to link with it themselves

* do not ../mpi_instance.h

* dyldmpi: make the symetricHeapTestFixture compile

* dyldmpi: Change cmakery, compiles and run gda w/o external MPI

* Make it also compile in external MPI mode

* dyldmpi: ipc unit tests compile but do not link

* dyldmpi: new approach, if external mpi required, link with mpi,
otherwise use ompi5 abi

* C-style comments in cmakelist..

* dyldmpi: examples: do not fail compiling if MPI not found at build time,
instead do not compile the MPI required examples

* more updates to CMake logic

* convert RO backend

and a few other cleanups

* update some unit tests

to work with the dlopen MPI environment correctly.

---------

Co-authored-by: Aurelien Bouteiller <abouteil@amd.com>
2025-10-01 08:06:56 -05:00
Istvan Kiss 118dc600ca Add reference to supported data types section (#1893)
[ROCm/rccl commit: 3776129011]
2025-10-01 12:36:14 +02:00
Istvan Kiss 3776129011 Add reference to supported data types section (#1893) 2025-10-01 12:36:14 +02:00
Geo Min 36a1fd87af Removing landed patch (#1184) 2025-09-30 16:51:41 -07:00
Geo Min b0a9a2386f [ci] Adding TheRock CI coverage for rocm-core (#868)
* TheRock CI points to rocm systems

* Fixing depth

* Fixing cache path

* Adding core components

* Adding more packages

* try this for windows building

* Add math libs

* Adding core only

* Attempt with no ccache

* adding patching

* Adding ls test

* adding this

* removing ls test

* changing dir name

* Adding cleanup for patch

* Adding ref

* adding correct no include

* Adding new temp branch for testing

* empty commit

* empty commit

* Adding commit hash bump

* Adding new hash for removed patches

* Adding TheRock submodule bump

* trying with compiler removed test

* Try dvc pull windows

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Adding correct env

* revert to ../

* Adding path

* try new var

* Adding new branch

* Adding correct hash

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Update .github/workflows/therock-ci-windows.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

---------

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>
2025-09-30 16:08:50 -07:00
Marius Brehler 026a4e82a3 Rollup of build changes needed for compat with TheRock. (#1086)
* Rollup of build changes needed for compat with TheRock.
* When built for a non-default ROCM location, the HIP headers can't be found by a few targets.
* Uses pkg_check for DRM libraries like ROCR-Runtime does (which avoids accidental fallback to system versions).
* Robust fix for nolink targets
* nolink targets essentially exist for include directories
* all nolink targets are automatically added to rocprofiler-sdk-headers with a $<BUILD_INTERFACE:...> generator expression
* Re-add previously used mechanism to find drm libs

---------

Co-authored-by: Marius Brehler <marius.brehler@amd.com>
Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-09-30 18:39:10 -04:00
Jin Jung c6d44b47d4 Fix VulkanTest::CreateMappedStorage _WIN64 segfault (#1173)
* Fix VulkanTest::CreateMappedStorage _WIN64 segfault

* Fix Indentation
2025-09-30 14:52:05 -07:00
ywang103-amd eeeaa06159 attach/detach: change workload of unit test to accommodate SDK's current limitation (#1169)
* add double mode of workload dynamic_share with on remove sleeping and
set ROCP_TOOL_ATTACH=1 for running workload

* add comment in dynamic_shared.hip to exaplain how to use argv

* refactor the attach/detach profiling time in unit tests
2025-09-30 13:16:43 -07:00
abchoudh-amd f45c8d5f6b Bugfixes for test failure (#1106)
- Bugfixes
- Update test instructions using docker
2025-09-30 15:48:41 -04:00
Jason Bonnell 953fd60e9b rocprofiler GHCR Rename (#1112)
- Rename the GHCR packages for rocprofiler Docker images to reduce the number of packages that will be released on the repository
- Changed package name to only include the OS instead of OS+Version - version moved to the tag instead.
- Updated Dockerfile.*.ci files to specify target ROCm version from tarball in name.
2025-09-30 15:15:12 -04:00
Jason Bonnell cec7ce77d6 Add sudo apt-get update command to workflow (#1177)
- 404 Not Found errors when trying to download dependencies in the Get the latest therock build step. Adding `sudo apt-get update` command first to avoid this.
- Added `sudo apt-get update` to the rocprofiler-sdk-build-ci-docker-images.yml workflow.
2025-09-30 14:09:36 -04:00
Venkateshwar Reddy Kandula c441a87a00 [rocprofiler-sdk][RCCL] RCCL New API changes for RCCL_API_TRACE_VERSION_PATCH = 2 (#985)
- Address build issue with RCCL sync with NCCL commit: ROCm/rccl@08a7be2
- Patch Version Bump-up PR: ROCm/rccl#1916
2025-09-30 12:42:42 -04:00
Aryan Salmanpour 31d76118ed Packaging - Update rocJPEG package dependencies (#186)
[ROCm/rocjpeg commit: 5fea241f7d]
2025-09-29 20:52:53 -07:00
Aryan Salmanpour 5fea241f7d Packaging - Update rocJPEG package dependencies (#186) 2025-09-29 20:52:53 -07:00
Jeremy Newton 5c905c4b65 Packaging - Drop libva-amdgpu for RHEL 9+, Ubuntu 24, and SLES (#656)
* Drop libva-amdgpu for newer distros

Due to bugs in mixing old and new libva installed, having both
libva-amdgpu packages just causes bugs due to edge cases. It's easier
to just use the inbox packages for RHEL9+, SLE, and UB24.04.

RHEL 8 and UB22.04 still needs libva-amdgpu since libva is too old.

I also noticed that SLE should be pulling in libva-drm2 as a runtime
requirement, since rocdecode only uses the DRM interface.

SWDEV-555510
SWDEV-557842

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>

* rocDecode-setup.py - Fix

```
rocDecode-setup.py", line 246
    else
        ^
SyntaxError: expected ':'

```

* rocDecode-setup.py - Fix

```
rocDecode-setup.py", line 246
    else
        ^
SyntaxError: expected ':'

```

* rocDecode-setup.py - fix

```
E: Unable to locate package rocm-hip-runtime-devlibstdc++-12-dev
E: Couldn't find any package by regex 'rocm-hip-runtime-devlibstdc++-12-dev'

```

---------

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>

[ROCm/rocdecode commit: d179c02e36]
2025-09-29 15:52:51 -07:00
Jeremy Newton d179c02e36 Packaging - Drop libva-amdgpu for RHEL 9+, Ubuntu 24, and SLES (#656)
* Drop libva-amdgpu for newer distros

Due to bugs in mixing old and new libva installed, having both
libva-amdgpu packages just causes bugs due to edge cases. It's easier
to just use the inbox packages for RHEL9+, SLE, and UB24.04.

RHEL 8 and UB22.04 still needs libva-amdgpu since libva is too old.

I also noticed that SLE should be pulling in libva-drm2 as a runtime
requirement, since rocdecode only uses the DRM interface.

SWDEV-555510
SWDEV-557842

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>

* rocDecode-setup.py - Fix

```
rocDecode-setup.py", line 246
    else
        ^
SyntaxError: expected ':'

```

* rocDecode-setup.py - Fix

```
rocDecode-setup.py", line 246
    else
        ^
SyntaxError: expected ':'

```

* rocDecode-setup.py - fix

```
E: Unable to locate package rocm-hip-runtime-devlibstdc++-12-dev
E: Couldn't find any package by regex 'rocm-hip-runtime-devlibstdc++-12-dev'

```

---------

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
2025-09-29 15:52:51 -07:00
systems-assistant[bot] d1ee1f0cba Upgrade binutils version from 2.42 to newer 2.44 version (#113)
* Upgrade binutils version from 2.42 to newer 2.44

---------

Co-authored-by: Marjan Antic <marantic@amd.com>
Co-authored-by: Sajina Kandy <sputhala@amd.com>
2025-09-29 14:50:33 -04:00
Yiltan 4f955324ac Fix g/p tests (#266)
[ROCm/rocshmem commit: 6bb46887e8]
2025-09-29 14:27:25 -04:00
Yiltan 6bb46887e8 Fix g/p tests (#266) 2025-09-29 14:27:25 -04:00
Avinash Kethineedi f18abbc1f2 feat: add atomic CAS support for bnxt NICs (#267)
[ROCm/rocshmem commit: df46e80116]
2025-09-29 11:39:35 -05:00
Avinash Kethineedi df46e80116 feat: add atomic CAS support for bnxt NICs (#267) 2025-09-29 11:39:35 -05:00
Avinash Kethineedi 594fee5791 GDA 64 bit atomics APIs (#254)
feat(gda): add support for
  * Standard atomics
    - atomic_CAS
    - atomic_fetch_CAS
  * Extended atomics
    - atomic set
    - atomic swap
  * Bitwise atomics
    - atomic_fetch_and
    - atomic_and
    - atomic_fetch_or
    - atomic_or
    - atomic_fetch_xor
    - atomic_xor


[ROCm/rocshmem commit: 98323a6086]
2025-09-29 11:38:49 -05:00
Avinash Kethineedi 98323a6086 GDA 64 bit atomics APIs (#254)
feat(gda): add support for
  * Standard atomics
    - atomic_CAS
    - atomic_fetch_CAS
  * Extended atomics
    - atomic set
    - atomic swap
  * Bitwise atomics
    - atomic_fetch_and
    - atomic_and
    - atomic_fetch_or
    - atomic_or
    - atomic_fetch_xor
    - atomic_xor
2025-09-29 11:38:49 -05:00
itrowbri 956daca743 [Docs][rocprofv3]Add Consecutive Kernels Parameter Description to Docs (#1111)
* Add consecutive kernels parameter description

* remove space

* Updated docs and CHANGELOG
2025-09-29 11:21:13 -05:00
David DeBonis 32b3a82956 Adding usage tip for ignore cpu affinity (#1948)
* Adding usage tip for ignore cpu affinity

* Update docs/how-to/rccl-usage-tips.rst

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

* Update docs/how-to/rccl-usage-tips.rst

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

---------

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

[ROCm/rccl commit: d23d18f423]
2025-09-29 10:11:21 -06:00
David DeBonis d23d18f423 Adding usage tip for ignore cpu affinity (#1948)
* Adding usage tip for ignore cpu affinity

* Update docs/how-to/rccl-usage-tips.rst

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

* Update docs/how-to/rccl-usage-tips.rst

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

---------

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>
2025-09-29 10:11:21 -06:00
Nilesh M Negi 9d300c46f0 [BUILD] Add rccl_compat.h to src/CMakeLists.txt (#152)
[ROCm/rccl-tests commit: a15d1edaa3]
2025-09-28 13:33:33 -05:00
Nilesh M Negi a15d1edaa3 [BUILD] Add rccl_compat.h to src/CMakeLists.txt (#152) 2025-09-28 13:33:33 -05:00
Bhuvan Mital 3169352cad changes for hugepages backed host buffer for larger allocations (#1841)
[ROCm/rccl commit: 65b69bf318]
2025-09-28 00:40:22 -05:00
Bhuvan Mital 65b69bf318 changes for hugepages backed host buffer for larger allocations (#1841) 2025-09-28 00:40:22 -05:00
Artem Kuzmitckii 722b0cd579 Revert disabling of context tracking for Radeon (#1927)
* Revert disabling of context tracking for Radeon

Original commit df3b7e47
 `Disable context tracking for the current version. (#1839)`

* Add env variable for disabling of context tracking for Radeon

`export NCCL_DISABLE_CONTEXT_TRACKING=1` to force disable of context tracking

* Update docs/how-to/rccl-usage-tips.rst

Fix grammar, thanks @amd-jnovotny

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

* Rename NCCL_DISABLE_CONTEXT_TRACKING -> RCCL_DISABLE_CONTEXT_TRACKING

* Revert changes in includes and rename util function

---------

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

[ROCm/rccl commit: 07925ec027]
2025-09-27 15:19:50 -04:00
Artem Kuzmitckii 07925ec027 Revert disabling of context tracking for Radeon (#1927)
* Revert disabling of context tracking for Radeon

Original commit 6fc228e2
 `Disable context tracking for the current version. (#1839)`

* Add env variable for disabling of context tracking for Radeon

`export NCCL_DISABLE_CONTEXT_TRACKING=1` to force disable of context tracking

* Update docs/how-to/rccl-usage-tips.rst

Fix grammar, thanks @amd-jnovotny

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>

* Rename NCCL_DISABLE_CONTEXT_TRACKING -> RCCL_DISABLE_CONTEXT_TRACKING

* Revert changes in includes and rename util function

---------

Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>
2025-09-27 15:19:50 -04:00
Ajay GunaShekar 81775169cc SWDEV-1 - hipcc args: --rocm-path to --hip-path in tests (#998) 2025-09-26 15:35:20 -07:00
Arif, Maisam 8758b8f75a [SWDEV-456192] Update process CLI help text (#720)
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
2025-09-26 17:33:01 -05:00
Arif, Maisam 9e57c34359 [SWDEV-456192] Update process CLI help text (#720)
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: 8758b8f75a]
2025-09-26 17:33:01 -05:00
Park, Peter 311eade5b1 docs: Update Doxygen, Sphinx, and readthedocs configs (#719)
* conf: update RTD config to ub24.04 (doxygen 1.9.8) and py3.12
* update generate-docs workflow
* Update "modules" to "topics" due to Doxygen 1.9.8
* bump rocm-docs-core to 1.25.0 and pip-compile requirements.txt
* doxygen: fill in version string in Doxyfile from conf.py
* remove unneeded rocm-smi-lib tutorials
* remove wikipedia references in doxyfile to satisfy ci check

Signed-off-by: Park, Peter <Peter.Park@amd.com>
2025-09-26 17:30:48 -05:00
Park, Peter 83bbbd55a3 docs: Update Doxygen, Sphinx, and readthedocs configs (#719)
* conf: update RTD config to ub24.04 (doxygen 1.9.8) and py3.12
* update generate-docs workflow
* Update "modules" to "topics" due to Doxygen 1.9.8
* bump rocm-docs-core to 1.25.0 and pip-compile requirements.txt
* doxygen: fill in version string in Doxyfile from conf.py
* remove unneeded rocm-smi-lib tutorials
* remove wikipedia references in doxyfile to satisfy ci check

Signed-off-by: Park, Peter <Peter.Park@amd.com>

[ROCm/amdsmi commit: 311eade5b1]
2025-09-26 17:30:48 -05:00
Mustafa Abduljabbar cb4b286d2b Enable viewing algo/proto/channels used in rccl-tests output (#151)
* Enable algo/proto/channel viewing 

* Use dynamic symbol loading to avoid build/runtime issues with non-compatible RCCL versions

* Reduce code duplication

[ROCm/rccl-tests commit: 0c94d4d2b3]
2025-09-26 18:09:01 -04:00
Mustafa Abduljabbar 0c94d4d2b3 Enable viewing algo/proto/channels used in rccl-tests output (#151)
* Enable algo/proto/channel viewing 

* Use dynamic symbol loading to avoid build/runtime issues with non-compatible RCCL versions

* Reduce code duplication
2025-09-26 18:09:01 -04:00
alex-breslow-amd 6423f5b024 Gate code by rocm_version (#1945)
[ROCm/rccl commit: 45166f6586]
2025-09-26 13:28:41 -07:00
alex-breslow-amd 45166f6586 Gate code by rocm_version (#1945) 2025-09-26 13:28:41 -07:00
Laura Promberger fb3677cad6 fetch_sources: replace flags that the newer version recognizes (#1148)
* fetch_sources: replace flags that the newer version recognizes

* fetch_sources: remove --no-include-rocm-libraries
2025-09-26 11:36:28 -07:00
Maisam Arif e61eac1368 [SWDEV-538483] Fix amdsmi.h doc tag for amdsmi_set_power_cap
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I919eba1745990fd05ca3ff1077317e7b1244fded
2025-09-26 13:28:43 -05:00
Maisam Arif 0d00e3c5ab [SWDEV-538483] Fix amdsmi.h doc tag for amdsmi_set_power_cap
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I919eba1745990fd05ca3ff1077317e7b1244fded


[ROCm/amdsmi commit: e61eac1368]
2025-09-26 13:28:43 -05:00
amd-hsivasun c16b06a7d7 [Ex CI] Enable aqlprofile (#1002)
* [Ex CI] Enable aqlprofile

* [Ex CI] Added PipelineID for aqlprofile
2025-09-26 14:00:41 -04:00
Maisam Arif bd3579a1ac Create symbolic links instead of hard links
This unbreaks having sources on one mount point and builds at another.

Signed-off-by: Marius Brehler <marius.brehler@amd.com>
Change-Id: I68363112382a95baaa867cad91e09bdec2b30d90
2025-09-26 12:17:06 -05:00
Maisam Arif 28fbf0d74f Create symbolic links instead of hard links
This unbreaks having sources on one mount point and builds at another.

Signed-off-by: Marius Brehler <marius.brehler@amd.com>
Change-Id: I68363112382a95baaa867cad91e09bdec2b30d90


[ROCm/amdsmi commit: bd3579a1ac]
2025-09-26 12:17:06 -05:00
dependabot[bot] 007438d519 Docs - Bump rocm-docs-core[api_reference] from 1.23.0 to 1.25.0 in /docs/sphinx (#185)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.23.0 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.23.0...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocjpeg commit: f0064636fd]
2025-09-26 10:12:00 -07:00