76333 Commits
Author SHA1 Message Date
Ammar ELWazir 548d853f56 SWDEV-387702 & SWDEV-387711: Fixing the location of the rocprofilerv2 tool
Change-Id: I5a7439351f1153c4c9f29b3fb4990fcc4de69c65


[ROCm/rocprofiler commit: 256875a69f]
2023-05-16 18:10:49 +00:00
Wenkai Du f7184aef3f Revert "Ensure memory copy integrity during transport setup (#731)" (#741)
* Revert "Ensure memory copy integrity during transport setup (#731)"

This reverts commit 0c0c35927a.

Add stream synchronization in ncclStrongStreamRelease.

* Use event record and wait

[ROCm/rccl commit: 4ca7742c61]
2023-05-16 10:34:47 -07:00
Wenkai Du 4ca7742c61 Revert "Ensure memory copy integrity during transport setup (#731)" (#741)
* Revert "Ensure memory copy integrity during transport setup (#731)"

This reverts commit 36e453c61e.

Add stream synchronization in ncclStrongStreamRelease.

* Use event record and wait
2023-05-16 10:34:47 -07:00
Satyanvesh Dittakavi 82e044cb6a SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02


[ROCm/clr commit: c98fad1edc]
2023-05-16 14:21:19 +00:00
Satyanvesh Dittakavi c98fad1edc SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02
2023-05-16 14:21:19 +00:00
Ammar ELWazir 52eebaa6e6 Fixing rocprofv2 script
Change-Id: I3adbd216116ad44032e5a01d880f9cf4d4074ae7
2023-05-15 18:40:41 -04:00
Ammar ELWazir 2ffc3d1adc Fixing rocprofv2 script
Change-Id: I3adbd216116ad44032e5a01d880f9cf4d4074ae7


[ROCm/rocprofiler commit: 52eebaa6e6]
2023-05-15 18:40:41 -04:00
coleramos425 e606c7b040 Remove wave cycles from LDS section (#130)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 8eb7f2b7e5]
2023-05-15 17:21:09 -05:00
coleramos425 8eb7f2b7e5 Remove wave cycles from LDS section (#130)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-15 17:21:09 -05:00
coleramos425 52d1847d2b Update VGPR counter (#117)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: d8d834ff60]
2023-05-15 17:04:08 -05:00
coleramos425 d8d834ff60 Update VGPR counter (#117)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-15 17:04:08 -05:00
David Yat Sin 38e832a682 Reserve scratch on first queue allocation
Some workloads running on multi-GPU create 1 process per GPU. So each
process creates a GPU agent on every GPU, but will only create queues on
one GPU. This would cause un-necessary scratch reservation.

Change-Id: I50a216f0bcc0b5f707f3943147390b0ecec1ac22
2023-05-15 17:10:57 -04:00
David Yat Sin 7ecdefb7ca Reserve scratch on first queue allocation
Some workloads running on multi-GPU create 1 process per GPU. So each
process creates a GPU agent on every GPU, but will only create queues on
one GPU. This would cause un-necessary scratch reservation.

Change-Id: I50a216f0bcc0b5f707f3943147390b0ecec1ac22


[ROCm/ROCR-Runtime commit: 38e832a682]
2023-05-15 17:10:57 -04:00
Jatin Chaudhary 9e5b96d567 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21


[ROCm/clr commit: 8753db5446]
2023-05-15 15:52:04 -04:00
Jatin Chaudhary 8753db5446 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21
2023-05-15 15:52:04 -04:00
gobhardw 56a2989ffa SWDEV-398161, SWDEV-398764 Fixed hsa-trace failures for profiling data corrupted
Change-Id: I3d8dbb2a40d948cd06cb1278acc50dc5be4ca0ef


[ROCm/roctracer commit: ee713682a1]
2023-05-15 22:38:23 +05:30
gobhardw ee713682a1 SWDEV-398161, SWDEV-398764 Fixed hsa-trace failures for profiling data corrupted
Change-Id: I3d8dbb2a40d948cd06cb1278acc50dc5be4ca0ef
2023-05-15 22:38:23 +05:30
Graham Sider bd63e5045c Fix scratch allocation occupancy reduction loop
If the required scratch allocation is too large, ROCr will attempt to
reduce it by lowering the dispatch's targeted occupancy. The reduction
loop however was prone to overflow if waves_per_cu was not a multiple of
waves_per_group. Ensure no overflow by aligning waves_per_cu to
waves_per_group.

On GC 9.4.3 dGPU, dispatches with a large grid size and a
waves_per_group of e.g. 16 may require to reduce occupancy such that
waves_per_cu is less than waves_per_group to ensure the allocation size
is small enough. Allow this while also ensuring the tmpring scratch wave
count is kept divisible by the number of SEs per XCC.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: Ie4016dcd8166a9ae69e9decc26a3eec882b49480
2023-05-15 14:55:42 +00:00
Graham Sider 53b5692d07 Fix scratch allocation occupancy reduction loop
If the required scratch allocation is too large, ROCr will attempt to
reduce it by lowering the dispatch's targeted occupancy. The reduction
loop however was prone to overflow if waves_per_cu was not a multiple of
waves_per_group. Ensure no overflow by aligning waves_per_cu to
waves_per_group.

On GC 9.4.3 dGPU, dispatches with a large grid size and a
waves_per_group of e.g. 16 may require to reduce occupancy such that
waves_per_cu is less than waves_per_group to ensure the allocation size
is small enough. Allow this while also ensuring the tmpring scratch wave
count is kept divisible by the number of SEs per XCC.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: Ie4016dcd8166a9ae69e9decc26a3eec882b49480


[ROCm/ROCR-Runtime commit: bd63e5045c]
2023-05-15 14:55:42 +00:00
Kent Russell d966243783 kfdtest: Add include directory for ROCr merge
When we merge thunk into ROCr, kfdtest will be in a different folder
structure. Add the new location to ensure that we can build now and in
the future with no disruptions

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: I6517e061cb0da7137d903abbc380bfc7126f40d4
2023-05-15 10:13:49 -04:00
Kent Russell 4d26b1cf48 kfdtest: Add include directory for ROCr merge
When we merge thunk into ROCr, kfdtest will be in a different folder
structure. Add the new location to ensure that we can build now and in
the future with no disruptions

Signed-off-by: Kent Russell <kent.russell@amd.com>
Change-Id: I6517e061cb0da7137d903abbc380bfc7126f40d4


[ROCm/ROCR-Runtime commit: d966243783]
2023-05-15 10:13:49 -04:00
David Yat Sin 3477fbc661 Do not report reserved scratch cache as available
Scratch cache reserved memory is only available for scratch memory use
so do not report this memory as available to the user via the
HSA_AMD_AGENT_INFO_MEMORY_AVAIL api.

Change-Id: I52f96e62536458bcaa52b9f4be5de856d5680dc4
2023-05-15 09:45:31 -04:00
David Yat Sin 2d924e337d Do not report reserved scratch cache as available
Scratch cache reserved memory is only available for scratch memory use
so do not report this memory as available to the user via the
HSA_AMD_AGENT_INFO_MEMORY_AVAIL api.

Change-Id: I52f96e62536458bcaa52b9f4be5de856d5680dc4


[ROCm/ROCR-Runtime commit: 3477fbc661]
2023-05-15 09:45:31 -04:00
Ioannis Assiouras ad30c947bf SWDEV-400119 - Return error from globalFreeMemory() if HSA available memory query fails
Change-Id: I33c069fa1e0d31891f64dc8167a24ef9d7ed1426


[ROCm/clr commit: a07e38be2f]
2023-05-15 11:54:25 +01:00
Ioannis Assiouras a07e38be2f SWDEV-400119 - Return error from globalFreeMemory() if HSA available memory query fails
Change-Id: I33c069fa1e0d31891f64dc8167a24ef9d7ed1426
2023-05-15 11:54:25 +01:00
Ammar ELWazir 2a835dd7e8 Fixing Samples to adapt Enter & Exit Phase
Change-Id: I41d8ad18931cfb43fad79e60df4d22053cb00d17
2023-05-12 19:22:59 +00:00
Ammar ELWazir 54a24a643c Fixing Samples to adapt Enter & Exit Phase
Change-Id: I41d8ad18931cfb43fad79e60df4d22053cb00d17


[ROCm/rocprofiler commit: 2a835dd7e8]
2023-05-12 19:22:59 +00:00
David Yat Sin f0000da7b3 Removing invalid gfx entries
Change-Id: I1a9a9a064f5f65ecc3e124c5dd7d6baf6b5ccb5c
2023-05-12 11:59:27 -04:00
David Yat Sin e1ded285a9 Removing invalid gfx entries
Change-Id: I1a9a9a064f5f65ecc3e124c5dd7d6baf6b5ccb5c


[ROCm/ROCR-Runtime commit: f0000da7b3]
2023-05-12 11:59:27 -04:00
David Yat Sin 7b74271d5e Disable Queue_Validation_InvalidGroupMemory
Temporarily disabling rocrtstNeg.Queue_Validation_InvalidGroupMemory
until it is fixed.

Change-Id: Ifc1973a960c8d0bae27e2628e4bfddc60f70325d
2023-05-12 11:03:26 -04:00
David Yat Sin 7a157d8e55 Disable Queue_Validation_InvalidGroupMemory
Temporarily disabling rocrtstNeg.Queue_Validation_InvalidGroupMemory
until it is fixed.

Change-Id: Ifc1973a960c8d0bae27e2628e4bfddc60f70325d


[ROCm/ROCR-Runtime commit: 7b74271d5e]
2023-05-12 11:03:26 -04:00
Yifan Zhang d319660838 kfdtest: Using non-paged memory allocation for wptr on devices that have MES scheduler
Starting with GFX11, wptr BOs must be mapped to GART for MES to determine work
on unmapped queues for usermode queue oversubscription (no aggregated doorbell)

Change-Id: I10e30fdc2bec587cef9427faa4874957988c34b3
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
2023-05-12 01:06:37 -04:00
Yifan Zhang 7b4b914b72 kfdtest: Using non-paged memory allocation for wptr on devices that have MES scheduler
Starting with GFX11, wptr BOs must be mapped to GART for MES to determine work
on unmapped queues for usermode queue oversubscription (no aggregated doorbell)

Change-Id: I10e30fdc2bec587cef9427faa4874957988c34b3
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>


[ROCm/ROCR-Runtime commit: d319660838]
2023-05-12 01:06:37 -04:00
Yifan Zhang 53ed978c3d kfdtest: add non paged wptr judging API.
If MES is enabled, wptr has to be non paged memory,
Add an API to check this condition.

Change-Id: I53af1f6687d5332d102e7062c3d760e33b96e722
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
2023-05-12 01:06:37 -04:00
Yifan Zhang 32eb2e1b33 kfdtest: add non paged wptr judging API.
If MES is enabled, wptr has to be non paged memory,
Add an API to check this condition.

Change-Id: I53af1f6687d5332d102e7062c3d760e33b96e722
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>


[ROCm/ROCR-Runtime commit: 53ed978c3d]
2023-05-12 01:06:37 -04:00
Cole Ramos d60bee9ffb Merge pull request #126 from feizheng10/simplify_show_all
Simplify interface of tty show

[ROCm/rocprofiler-compute commit: 6dd77db61e]
2023-05-11 14:23:57 -05:00
Cole Ramos 6dd77db61e Merge pull request #126 from feizheng10/simplify_show_all
Simplify interface of tty show
2023-05-11 14:23:57 -05:00
coleramos425 8b2b78d193 Redefine boring merge values
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 444102d927]
2023-05-11 14:04:02 -05:00
coleramos425 444102d927 Redefine boring merge values
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-11 14:04:02 -05:00
coleramos425 502ce88ca8 Add grid size option and cmd line option for --join-type
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 419e2fcac6]
2023-05-11 13:00:30 -05:00
coleramos425 419e2fcac6 Add grid size option and cmd line option for --join-type
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-11 13:00:30 -05:00
gobhardw 0b401d71c6 SWDEV-397576 Adding protection for HIP calls to understand MI failures
Change-Id: Icd6a2cb3be5520ee57fdd76bfafa06801b7061c0
2023-05-11 13:02:31 -04:00
gobhardw 7a3a0b18f1 SWDEV-397576 Adding protection for HIP calls to understand MI failures
Change-Id: Icd6a2cb3be5520ee57fdd76bfafa06801b7061c0


[ROCm/rocprofiler commit: 0b401d71c6]
2023-05-11 13:02:31 -04:00
Saleel Kudchadker adf6512dad Report XGMI SDMA upon query
Report XGMI SDMA engines when queried for H2D/D2H.

Change-Id: I4fb7b24bc15d1745b3844485bdeab71282a787a5
2023-05-11 12:20:41 -04:00
Saleel Kudchadker 5630103f4a Report XGMI SDMA upon query
Report XGMI SDMA engines when queried for H2D/D2H.

Change-Id: I4fb7b24bc15d1745b3844485bdeab71282a787a5


[ROCm/ROCR-Runtime commit: adf6512dad]
2023-05-11 12:20:41 -04:00
Bill(Shuzhou) Liu dc4ba12e00 Return NOT_SUPPORT for set function in VM guest
Fix the unit tests which are fail in VM guest environment.

Change-Id: Id7c58887692bbdecba54f5d2d8463b292e19b4ad
2023-05-11 10:42:55 -05:00
Bill(Shuzhou) Liu da3da06941 Return NOT_SUPPORT for set function in VM guest
Fix the unit tests which are fail in VM guest environment.

Change-Id: Id7c58887692bbdecba54f5d2d8463b292e19b4ad


[ROCm/amdsmi commit: dc4ba12e00]
2023-05-11 10:42:55 -05:00
Suma Hegde 3fa4402833 updated amdsmi_wrapper.py
following command is run to generate this file
cmake -B build && make -C build && make -C build python_wrapper

Change-Id: I9ee03c4030537c9e8d260e776c04da52d93a9570
2023-05-11 11:01:45 -04:00
Suma Hegde 6b138833bf updated amdsmi_wrapper.py
following command is run to generate this file
cmake -B build && make -C build && make -C build python_wrapper

Change-Id: I9ee03c4030537c9e8d260e776c04da52d93a9570


[ROCm/amdsmi commit: 3fa4402833]
2023-05-11 11:01:45 -04:00
Suma Hegde edd8f1ae23 Renamed APIs
amdsmi_dev_open_supported_func_iterator -> amdsmi_open_supported_func_iterator
amdsmi_dev_open_supported_variant_iterator -> amdsmi_open_supported_variant_iterator
amdsmi_dev_close_supported_func_iterator -> amdsmi_close_supported_func_iterator

Change-Id: Ie9b2efa5aee7095c3c835b91de1951df6b065510
2023-05-11 11:01:37 -04:00