76333 Commits
Author SHA1 Message Date
ROCm CI Service Account f6f82b86da SWDEV-379927 - ignore --rocm-path option on nvidia platform (#3156)
Change-Id: I5e9ff0378c14dc0894a07d71aff4261c155ec1af
2023-02-17 10:34:51 -08:00
Ranjith Ramakrishnan ee63dd0dc5 SWDEV-383843 - Use relative path for RUNPATH
Build script was passing relative path for setting the RUNPATH. But clinfo is overriding it and using absolute paths
Removed the same from source code

Change-Id: I505e7fdc84c53d147f3afbc6c4133f906de2110f


[ROCm/clr commit: 067beca608]
2023-02-17 11:31:48 -05:00
Ranjith Ramakrishnan 067beca608 SWDEV-383843 - Use relative path for RUNPATH
Build script was passing relative path for setting the RUNPATH. But clinfo is overriding it and using absolute paths
Removed the same from source code

Change-Id: I505e7fdc84c53d147f3afbc6c4133f906de2110f
2023-02-17 11:31:48 -05:00
German 73f02aa6dc SWDEV-382397 - Move VirtualGPU destruction back to the thread exit
OS can terminate unfinished queue thread from default stream at any
time. Potentially leaving the queue lock in a bad state and causing a
deadlock if runtime destroys VirtualGPU later from the host thread.

Change-Id: I247f102ee84e6b4dba947504933395071945c85d


[ROCm/clr commit: 28daf98f1f]
2023-02-17 10:05:49 -05:00
German 28daf98f1f SWDEV-382397 - Move VirtualGPU destruction back to the thread exit
OS can terminate unfinished queue thread from default stream at any
time. Potentially leaving the queue lock in a bad state and causing a
deadlock if runtime destroys VirtualGPU later from the host thread.

Change-Id: I247f102ee84e6b4dba947504933395071945c85d
2023-02-17 10:05:49 -05:00
Maneesh Gupta 4b8bf631d0 SWDEV-366831 - Revert "File reorg backward compatibility message changed to #error"
This reverts commit de1e612775.

Reason for revert: Need to wait for apps to make fixes first

Change-Id: I337a0b56d268093fc8689152002a6f8a8ceb258f


[ROCm/clr commit: c7576e2add]
2023-02-17 03:46:29 -05:00
Maneesh Gupta c7576e2add SWDEV-366831 - Revert "File reorg backward compatibility message changed to #error"
This reverts commit c86bd74c67.

Reason for revert: Need to wait for apps to make fixes first

Change-Id: I337a0b56d268093fc8689152002a6f8a8ceb258f
2023-02-17 03:46:29 -05:00
Anusha GodavarthySurya 06ffd15060 SWDEV-366636 - Fix performance drop in TF-RCCL models
Change-Id: Idc845bb0dab858b94b9d2720cae8308cac2e7328


[ROCm/clr commit: f98dcf9d7f]
2023-02-17 00:48:13 -05:00
Anusha GodavarthySurya f98dcf9d7f SWDEV-366636 - Fix performance drop in TF-RCCL models
Change-Id: Idc845bb0dab858b94b9d2720cae8308cac2e7328
2023-02-17 00:48:13 -05:00
Rakesh Roy 7323f7a4cf SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983


[ROCm/hipother commit: bb635fd5ff]
2023-02-16 23:04:29 -05:00
Rakesh Roy bb635fd5ff SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983
2023-02-16 23:04:29 -05:00
Rakesh Roy 9c51780b13 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983


[ROCm/clr commit: 287d07ccd4]
2023-02-16 23:04:29 -05:00
Rakesh Roy 287d07ccd4 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983
2023-02-16 23:04:29 -05:00
Ioannis Assiouras 5007a5f15d SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef


[ROCm/clr commit: 8b87ccb8cc]
2023-02-16 17:49:12 -05:00
Ioannis Assiouras 8b87ccb8cc SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef
2023-02-16 17:49:12 -05:00
Galantsev, Dmitrii 3bed2b7b8f Improve Debian packaging recommendation
See: https://cmake.org/cmake/help/latest/cpack_gen/deb.html#variable:CPACK_DEBIAN_PACKAGE_RECOMMENDS

Change-Id: I945cbf2104d108caf0ee6e2e963ecfca9a6320e0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-02-16 14:40:40 -06:00
Galantsev, Dmitrii b0067b5c9a Improve Debian packaging recommendation
See: https://cmake.org/cmake/help/latest/cpack_gen/deb.html#variable:CPACK_DEBIAN_PACKAGE_RECOMMENDS

Change-Id: I945cbf2104d108caf0ee6e2e963ecfca9a6320e0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 3bed2b7b8f]
2023-02-16 14:40:40 -06:00
jatang 6723b780ca SWDEV-372613 - No need to link GLEW/GL for oclperf and oclruntime tests
Change-Id: I0b9fe78f3fb6d93a4e7d0fe66ea279291716f30e


[ROCm/clr commit: 589988ee47]
2023-02-16 15:07:23 -05:00
jatang 589988ee47 SWDEV-372613 - No need to link GLEW/GL for oclperf and oclruntime tests
Change-Id: I0b9fe78f3fb6d93a4e7d0fe66ea279291716f30e
2023-02-16 15:07:23 -05:00
kjayapra-amd 9c479ada12 SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303


[ROCm/clr commit: 193c5e387e]
2023-02-16 14:05:54 -05:00
kjayapra-amd 193c5e387e SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303
2023-02-16 14:05:54 -05:00
kjayapra-amd 53073c4657 SWDEV-376697 - Use PCIE fine grain memory pool when hipDeviceMallocUncached flag is used.
Change-Id: I7234d456ef2df42b0b9b9e0d2647ee9bded565f9


[ROCm/clr commit: 6b873b8a86]
2023-02-16 14:05:50 -05:00
kjayapra-amd 6b873b8a86 SWDEV-376697 - Use PCIE fine grain memory pool when hipDeviceMallocUncached flag is used.
Change-Id: I7234d456ef2df42b0b9b9e0d2647ee9bded565f9
2023-02-16 14:05:50 -05:00
Nirmal Unnikrishnan e058c227fc SWDEV-383541 : Updating the HIP_PATH in env
Change-Id: I8a58fe684ce1a6f076d41faf0365d19f11862623


[ROCm/rocm-core commit: c9f1935325]
2023-02-16 12:42:35 -06:00
Nirmal Unnikrishnan c9f1935325 SWDEV-383541 : Updating the HIP_PATH in env
Change-Id: I8a58fe684ce1a6f076d41faf0365d19f11862623
2023-02-16 12:42:35 -06:00
Yifan Zhang d0330d7958 Fix MemoryConcurrentTest failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I85b8f9f1ff0fbb5a063b310aa6f72b9b5cdc13b4
2023-02-16 20:23:38 +08:00
Yifan Zhang 90e271e19b Fix MemoryConcurrentTest failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I85b8f9f1ff0fbb5a063b310aa6f72b9b5cdc13b4


[ROCm/ROCR-Runtime commit: d0330d7958]
2023-02-16 20:23:38 +08:00
Yifan Zhang 83cb79510e Fix rocrtstPerf.Memory_Async_Copy failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: Ieec5b76f0e058d5655145b51fdea48e3d87560b4
2023-02-16 20:18:04 +08:00
Yifan Zhang 565665f141 Fix rocrtstPerf.Memory_Async_Copy failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: Ieec5b76f0e058d5655145b51fdea48e3d87560b4


[ROCm/ROCR-Runtime commit: 83cb79510e]
2023-02-16 20:18:04 +08:00
Yifan Zhang 9bab46130a Fix rocrtstFunc.Memory_Available failure for APUs w/ small VRAM.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I0e9d5f1880c0e484e88ed424888d94d1bcac4d53
2023-02-16 20:16:28 +08:00
Yifan Zhang e93868b503 Fix rocrtstFunc.Memory_Available failure for APUs w/ small VRAM.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I0e9d5f1880c0e484e88ed424888d94d1bcac4d53


[ROCm/ROCR-Runtime commit: 9bab46130a]
2023-02-16 20:16:28 +08:00
Yifan Zhang afae35b0fd Avoid memory leak when rocrtstFunc.Memory_Available fails
Assert abort the test thread w/ memPtr1 allocated. Free memPtr1
to avoid memory leak.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I4e1a202c1acb9ba71a23e112254f875bf5a0abcf
2023-02-16 20:13:15 +08:00
Yifan Zhang 94d5ab8c9e Avoid memory leak when rocrtstFunc.Memory_Available fails
Assert abort the test thread w/ memPtr1 allocated. Free memPtr1
to avoid memory leak.

Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I4e1a202c1acb9ba71a23e112254f875bf5a0abcf


[ROCm/ROCR-Runtime commit: afae35b0fd]
2023-02-16 20:13:15 +08:00
Yifan Zhang 4ebb9857ee Fix rocrtstFunc.Memory_Max_Mem failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I1c0f481af8b1d2a0939d28fb184ff6887747ab03
2023-02-16 20:12:19 +08:00
Yifan Zhang 04ea6db7e6 Fix rocrtstFunc.Memory_Max_Mem failure for APUs w/ small VRAM
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
Change-Id: I1c0f481af8b1d2a0939d28fb184ff6887747ab03


[ROCm/ROCR-Runtime commit: 4ebb9857ee]
2023-02-16 20:12:19 +08:00
Jenkins 50420eaa38 Merge 'develop' into 'amd-staging'
Change-Id: I47c195e8ec8099eb87dca31c66c20b5ec79a7c7c


[ROCm/hip-tests commit: 8b1176eb11]
2023-02-16 12:11:17 +00:00
Jenkins 8b1176eb11 Merge 'develop' into 'amd-staging'
Change-Id: I47c195e8ec8099eb87dca31c66c20b5ec79a7c7c
2023-02-16 12:11:17 +00:00
Hao Zhou 923018a3a5 Merge amd-staging into amd-master 20230216
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I1a439acaf0208f9bc68ac19753c1df98ea5387ee


[ROCm/rocm_smi_lib commit: 405dff6b64]
2023-02-16 17:04:21 +08:00
Hao Zhou 405dff6b64 Merge amd-staging into amd-master 20230216
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I1a439acaf0208f9bc68ac19753c1df98ea5387ee
2023-02-16 17:04:21 +08:00
Lang Yu 8501c0bcb1 Fix memory async copy test performance issue
Copying memory from device to host with a CPU agent
would cause a poor performance due to the reading of
uncahced device memory by CPU.

Fix it by using a GPU agent.

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Change-Id: Ia3b562758fe73ef9efaa284f47e67bf569cc7b7b
2023-02-15 22:24:55 -05:00
Lang Yu d44cbfd4ad Fix memory async copy test performance issue
Copying memory from device to host with a CPU agent
would cause a poor performance due to the reading of
uncahced device memory by CPU.

Fix it by using a GPU agent.

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Change-Id: Ia3b562758fe73ef9efaa284f47e67bf569cc7b7b


[ROCm/ROCR-Runtime commit: 8501c0bcb1]
2023-02-15 22:24:55 -05:00
ROCm CI Service Account db3c379967 SWDEV-382266, SWDEV-379678 - hip samples package from hip-tests project (#168)
Use make package_samples to generate the packages

Change-Id: I30b382fed385f6daac026375537726622c05ca88

[ROCm/hip-tests commit: 6a5e95122b]
2023-02-15 17:47:59 -08:00
ROCm CI Service Account 6a5e95122b SWDEV-382266, SWDEV-379678 - hip samples package from hip-tests project (#168)
Use make package_samples to generate the packages

Change-Id: I30b382fed385f6daac026375537726622c05ca88
2023-02-15 17:47:59 -08:00
Jenkins bef8f52cb7 SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: Ibac1c8b8a6c9f99814baa660a5b3b88a803ccda8


[ROCm/hip commit: 1ddde25eef]
2023-02-16 00:10:59 +00:00
Jenkins 1ddde25eef SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: Ibac1c8b8a6c9f99814baa660a5b3b88a803ccda8
2023-02-16 00:10:59 +00:00
Cole Ramos ecedfba0f0 Custom metrics for mi100
Signed-off-by: Cole Ramos <colramos@TheraC02.thera.amd.com>


[ROCm/rocprofiler-compute commit: acfba464ed]
2023-02-15 14:44:29 -06:00
Cole Ramos acfba464ed Custom metrics for mi100
Signed-off-by: Cole Ramos <colramos@TheraC02.thera.amd.com>
2023-02-15 14:44:29 -06:00
Jonathan R. Madsen 7d0fb66465 Fix internal gcc compiler error for GCC 7 (#243)
- Error: internal compiler error: output_operand: '%&' used without any local dynamic TLS references
- location: kokkosp.cpp

[ROCm/rocprofiler-systems commit: 9a665b5684]
2023-02-15 12:37:53 -06:00
Jonathan R. Madsen 9a665b5684 Fix internal gcc compiler error for GCC 7 (#243)
- Error: internal compiler error: output_operand: '%&' used without any local dynamic TLS references
- location: kokkosp.cpp
2023-02-15 12:37:53 -06:00
kjayapra-amd b9f94c082b SWDEV-381898 - Move the lock after code object loading since COMGR is thread safe now and VDI also have locks.
Change-Id: I15547f3ae3711d12a1ddf5cb7e9abd40a95ded89


[ROCm/clr commit: 68139f9ddb]
2023-02-15 10:23:28 -05:00