76333 Коммитов
Автор SHA1 Сообщение Дата
ROCm CI Service Account c5d856348e SWDEV-344211 - Fix hipHostMalloc tests (#2823)
- Increase allocation size to 30MB to make sure new page table allocations happen
- Change validation criteria to check for increase in VRAM usage for visible HIP devices

Change-Id: Ie5bf1a89ceda0ff50140f426235047adcca0fdea
2022-07-26 11:46:32 +05:30
ROCm CI Service Accountиmbhiutra cb57c0b725 SWDEV-306122 - [catch2][dtest] hipGraphExecMemcpyNodeSetParamsToSymbol API (#2824)
Change-Id: I3f533b88f9fadcb17bde6577212cf1561fa49273

Co-authored-by: mbhiutra <meher.bhiutras@amd.com>

[ROCm/hip-tests commit: 4e1d167d53]
2022-07-26 10:47:49 +05:30
ROCm CI Service Accountиmbhiutra 4e1d167d53 SWDEV-306122 - [catch2][dtest] hipGraphExecMemcpyNodeSetParamsToSymbol API (#2824)
Change-Id: I3f533b88f9fadcb17bde6577212cf1561fa49273

Co-authored-by: mbhiutra <meher.bhiutras@amd.com>
2022-07-26 10:47:49 +05:30
ROCm CI Service Accountиmbhiutra 7af43266bf SWDEV-306122 - [catch2][dtest] hipGraphExecMemcpyNodeSetParamsToSymbol API (#2824)
Change-Id: I3f533b88f9fadcb17bde6577212cf1561fa49273

Co-authored-by: mbhiutra <meher.bhiutras@amd.com>

[ROCm/hip commit: e68136227a]
2022-07-26 10:47:49 +05:30
ROCm CI Service Accountиmbhiutra e68136227a SWDEV-306122 - [catch2][dtest] hipGraphExecMemcpyNodeSetParamsToSymbol API (#2824)
Change-Id: I3f533b88f9fadcb17bde6577212cf1561fa49273

Co-authored-by: mbhiutra <meher.bhiutras@amd.com>
2022-07-26 10:47:49 +05:30
searlmc1 02c0f2cd1d SWDEV-347383 - Remove code that sets -std and -fms-* flags (#2820)
[ROCm/hip commit: 15575466ac]
2022-07-26 10:47:06 +05:30
searlmc1 15575466ac SWDEV-347383 - Remove code that sets -std and -fms-* flags (#2820) 2022-07-26 10:47:06 +05:30
Jaydeep Patel f4642fc0d4 SWDEV-347592 - validate hipMemAllocationType & hipMemLocationType
Change-Id: Ia8c4d3edc7ad96efa429b3530a118199d4f92902


[ROCm/clr commit: 0fed29f77c]
2022-07-25 23:56:20 -04:00
Jaydeep Patel 0fed29f77c SWDEV-347592 - validate hipMemAllocationType & hipMemLocationType
Change-Id: Ia8c4d3edc7ad96efa429b3530a118199d4f92902
2022-07-25 23:56:20 -04:00
Jonathan R. Madsen d2a39b9066 User regions in Python (#57)
* User regions in Python

* User-region testing + common submodule

- Updated examples/python/source.py to use user-regions
- Python-level user submodule
- Python-level common submodule
- clean-up of profiler python code
- extended source.py testing to include the user-regions

[ROCm/rocprofiler-systems commit: 4dd144a32c]
2022-07-25 20:24:34 -05:00
Jonathan R. Madsen 4dd144a32c User regions in Python (#57)
* User regions in Python

* User-region testing + common submodule

- Updated examples/python/source.py to use user-regions
- Python-level user submodule
- Python-level common submodule
- clean-up of profiler python code
- extended source.py testing to include the user-regions
2022-07-25 20:24:34 -05:00
Felix Kuehling deb7a20c92 libhsakmt: Make CWSR area executable
The debugger depends on the CWSR area being executable. Set the right
flag when registering SVM memory.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Tested-by: Laurent Morichetti <Laurent.Morichetti@amd.com>
Change-Id: I7441e214d1a4da8324d775e777976fabd1c81a6f
2022-07-25 17:43:52 -04:00
Felix Kuehling cd04105656 libhsakmt: Make CWSR area executable
The debugger depends on the CWSR area being executable. Set the right
flag when registering SVM memory.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Tested-by: Laurent Morichetti <Laurent.Morichetti@amd.com>
Change-Id: I7441e214d1a4da8324d775e777976fabd1c81a6f


[ROCm/ROCR-Runtime commit: deb7a20c92]
2022-07-25 17:43:52 -04:00
sdashmiz ab694c23fb SWDEV-346456 - fix test for get/set attr
- test should allow first calling get function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19


[ROCm/clr commit: 66bde8f336]
2022-07-25 15:17:27 -04:00
sdashmiz 66bde8f336 SWDEV-346456 - fix test for get/set attr
- test should allow first calling get function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19
2022-07-25 15:17:27 -04:00
sdashmiz ed46e236d2 SWDEV-346423 - avoid race condition
- move removing the array from array set earlier to avoid race condition

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9003c991e3e0f47ed0509ddfdbeaa145b5a1e0f1


[ROCm/clr commit: d0b9e0a4ff]
2022-07-25 15:17:10 -04:00
sdashmiz d0b9e0a4ff SWDEV-346423 - avoid race condition
- move removing the array from array set earlier to avoid race condition

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9003c991e3e0f47ed0509ddfdbeaa145b5a1e0f1
2022-07-25 15:17:10 -04:00
Jonathan R. Madsen 10fbc81adc Fix dockerfile.opensuse (#115)
rccl-dev -> rccl-devel

[ROCm/rocprofiler-systems commit: 74fe68101b]
2022-07-25 14:09:02 -05:00
Jonathan R. Madsen 74fe68101b Fix dockerfile.opensuse (#115)
rccl-dev -> rccl-devel
2022-07-25 14:09:02 -05:00
Jonathan R. Madsen 93343034bc RCCL support (#93)
* Initial support for RCCL

* OMNITRACE_USE_RCCLP + sampling tweaks

- also OMNITRACE_SAMPLING_KEEP_INTERNAL option
- minor modifications to sampling to use keep internal option + discard funlockfile

* Update docker and workflows to download RCCL

* Update CPack DEB with rocprofiler dependency

* Rework rccl into library and library/components folder

- add tpls/rccl/rccl/rccl.h

* Fix timemory includes

* rcclp inline definitions when disabled

* Tweaks to ubuntu-focal-external-rocm

- disable ompt
- enable building testing

* Tweaks to ubuntu-focal-external-rocm

- ctest exclude

* Tweak ubuntu-focal.yml

- remove source /.../setup-env.sh, replace with $GITHUB_ENV

* Fix ubuntu-focal-rocm + OMPI + root

* Improved rocm-smi error handling

- Recover from rocm-smi errors
- Disabling rocm-smi after recovering from errors
- Werror in developer mode
- Remove State::DelayedInit
- Add State::Disabled

* formatting

* Fix merge of OMNITRACE_SAMPLING_KEEP_INTERNAL

* Update RCCL include directory

- based on ROCm version we need with <rccl/rccl.h> or <rccl.h>

* RCCL Testing

- updated tests to use configuration files
- many tests generate a configuration file
- tests how have GPU option
- enable ncclCommCount, disable ncclGetVersion
- add testing for RCCLP via rccl-tests
- working directory of tests is PROJECT_BINARY_DIR
- add nccl/rccl functions to get_whole_function_names
- some clang compiler fixes

* Handle RCCL include w/o HIP

* RCCL requires HIP

* Update OMNITRACE_SAMPLING_CPUS for testing

* Update tests/CMakeLists.txt

* Debug settings

* Install MPI even when USE_MPI=OFF

* exclude printf

* skip mpi tests w/o USE_MPI or USE_MPI_HEADERS

* update ubuntu rocm workflow

* Fix configure env step for ubuntu rocm

[ROCm/rocprofiler-systems commit: 45be03906a]
2022-07-25 12:16:11 -05:00
Jonathan R. Madsen 45be03906a RCCL support (#93)
* Initial support for RCCL

* OMNITRACE_USE_RCCLP + sampling tweaks

- also OMNITRACE_SAMPLING_KEEP_INTERNAL option
- minor modifications to sampling to use keep internal option + discard funlockfile

* Update docker and workflows to download RCCL

* Update CPack DEB with rocprofiler dependency

* Rework rccl into library and library/components folder

- add tpls/rccl/rccl/rccl.h

* Fix timemory includes

* rcclp inline definitions when disabled

* Tweaks to ubuntu-focal-external-rocm

- disable ompt
- enable building testing

* Tweaks to ubuntu-focal-external-rocm

- ctest exclude

* Tweak ubuntu-focal.yml

- remove source /.../setup-env.sh, replace with $GITHUB_ENV

* Fix ubuntu-focal-rocm + OMPI + root

* Improved rocm-smi error handling

- Recover from rocm-smi errors
- Disabling rocm-smi after recovering from errors
- Werror in developer mode
- Remove State::DelayedInit
- Add State::Disabled

* formatting

* Fix merge of OMNITRACE_SAMPLING_KEEP_INTERNAL

* Update RCCL include directory

- based on ROCm version we need with <rccl/rccl.h> or <rccl.h>

* RCCL Testing

- updated tests to use configuration files
- many tests generate a configuration file
- tests how have GPU option
- enable ncclCommCount, disable ncclGetVersion
- add testing for RCCLP via rccl-tests
- working directory of tests is PROJECT_BINARY_DIR
- add nccl/rccl functions to get_whole_function_names
- some clang compiler fixes

* Handle RCCL include w/o HIP

* RCCL requires HIP

* Update OMNITRACE_SAMPLING_CPUS for testing

* Update tests/CMakeLists.txt

* Debug settings

* Install MPI even when USE_MPI=OFF

* exclude printf

* skip mpi tests w/o USE_MPI or USE_MPI_HEADERS

* update ubuntu rocm workflow

* Fix configure env step for ubuntu rocm
2022-07-25 12:16:11 -05:00
Jonathan R. Madsen 8228dcef50 ubuntu cpack was building for rocm 5.2 twice (#114)
- fixes issue where ubuntu cpack workflows for ROCm 5.1 and 5.2 were both building ROCm 5.2

[ROCm/rocprofiler-systems commit: a539da1681]
2022-07-25 11:11:16 -05:00
Jonathan R. Madsen a539da1681 ubuntu cpack was building for rocm 5.2 twice (#114)
- fixes issue where ubuntu cpack workflows for ROCm 5.1 and 5.2 were both building ROCm 5.2
2022-07-25 11:11:16 -05:00
Jonathan R. Madsen ae7b931672 Minor fixes (#113)
- Improved error handling in getenv
- write_perfetto_counter_track

[ROCm/rocprofiler-systems commit: 80a9039239]
2022-07-25 07:25:43 -05:00
Jonathan R. Madsen 80a9039239 Minor fixes (#113)
- Improved error handling in getenv
- write_perfetto_counter_track
2022-07-25 07:25:43 -05:00
Jonathan R. Madsen 2123e661d5 Fix PAPI cpack packaging (#112)
* Fix PAPI cpack packaging

[ROCm/rocprofiler-systems commit: b054b1a0ec]
2022-07-25 05:03:51 -05:00
Jonathan R. Madsen b054b1a0ec Fix PAPI cpack packaging (#112)
* Fix PAPI cpack packaging
2022-07-25 05:03:51 -05:00
Maneesh Gupta 7cd1bc21b9 Update Jenkinsfile
Add backendLabel to stage name for better readability in pipeline views

[ROCm/hip commit: decab3841a]
2022-07-25 13:25:25 +05:30
Maneesh Gupta decab3841a Update Jenkinsfile
Add backendLabel to stage name for better readability in pipeline views
2022-07-25 13:25:25 +05:30
Jonathan R. Madsen c065874631 Docker + build-release.sh + PAPI.cmake (#111)
- Release Docker uses CMake 3.21.4
- Configurable PAPI_C_COMPILER
- build-release.sh builds install

[ROCm/rocprofiler-systems commit: 015fdfac6a]
2022-07-25 02:36:28 -05:00
Jonathan R. Madsen 015fdfac6a Docker + build-release.sh + PAPI.cmake (#111)
- Release Docker uses CMake 3.21.4
- Configurable PAPI_C_COMPILER
- build-release.sh builds install
2022-07-25 02:36:28 -05:00
Jonathan R. Madsen 07bda896e2 exit gotcha + remove DelayedInit state + rocm-smi + cleanup (#110)
* exit gotcha + remove DelayedInit state + cleanup

- exit gotcha which wraps exit, quick_exit, abort
- minor refactor of mpi gotchas
- removed some redundant code in omnitrace_finalized_hidden
- exclude instrumenting functions starting with dlopen and dlsym
- exclude instrumenting exit, quick_exit, and abort functions
- update timemory submodule with support for new gotcha_invoker with (gotcha_data, <function pointer>, args...)

* Improved rocm_smi error handling

[ROCm/rocprofiler-systems commit: 99da25ea80]
2022-07-24 22:09:32 -05:00
Jonathan R. Madsen 99da25ea80 exit gotcha + remove DelayedInit state + rocm-smi + cleanup (#110)
* exit gotcha + remove DelayedInit state + cleanup

- exit gotcha which wraps exit, quick_exit, abort
- minor refactor of mpi gotchas
- removed some redundant code in omnitrace_finalized_hidden
- exclude instrumenting functions starting with dlopen and dlsym
- exclude instrumenting exit, quick_exit, and abort functions
- update timemory submodule with support for new gotcha_invoker with (gotcha_data, <function pointer>, args...)

* Improved rocm_smi error handling
2022-07-24 22:09:32 -05:00
Jonathan R. Madsen ee788c4178 Fix reliability when KOKKOS_PROFILE_LIBRARY is set in env (#103)
* Fix reliability when KOKKOS_PROFILE_LIBRARY is set in env

- in certain situations, an exe using kokkos may be instrumented
- this will cause libomnitrace to be dlopened via libomnitrace-dl
- if KOKKOS_PROFILE_LIBRARY is set to libomnitrace and not libomnitrace-dl, you will end up with different instances of libomnitrace trying to collect data

* Set OMNITRACE_MAX_THREADS=32 in CI

[ROCm/rocprofiler-systems commit: bcdec188eb]
2022-07-24 22:01:53 -05:00
Jonathan R. Madsen bcdec188eb Fix reliability when KOKKOS_PROFILE_LIBRARY is set in env (#103)
* Fix reliability when KOKKOS_PROFILE_LIBRARY is set in env

- in certain situations, an exe using kokkos may be instrumented
- this will cause libomnitrace to be dlopened via libomnitrace-dl
- if KOKKOS_PROFILE_LIBRARY is set to libomnitrace and not libomnitrace-dl, you will end up with different instances of libomnitrace trying to collect data

* Set OMNITRACE_MAX_THREADS=32 in CI
2022-07-24 22:01:53 -05:00
sdashmiz 942141e39a SWDEV-347345 - add missing func for nvdia
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie2a70778d01948083d724a9d20e1f17541178ec5


[ROCm/hipother commit: bd1ffabfc1]
2022-07-24 21:38:14 -04:00
sdashmiz bd1ffabfc1 SWDEV-347345 - add missing func for nvdia
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie2a70778d01948083d724a9d20e1f17541178ec5
2022-07-24 21:38:14 -04:00
sdashmiz fc0d9521f2 SWDEV-347345 - add missing func for nvdia
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie2a70778d01948083d724a9d20e1f17541178ec5


[ROCm/clr commit: fefb9ae466]
2022-07-24 21:38:14 -04:00
sdashmiz fefb9ae466 SWDEV-347345 - add missing func for nvdia
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie2a70778d01948083d724a9d20e1f17541178ec5
2022-07-24 21:38:14 -04:00
Jaydeep Patel a1a75f02f0 SWDEV-345020 - The bit channel description should not allow any channels after a zero channel
Change-Id: I66e6d25c032d22f9616dc59730f1f094d30c01cf


[ROCm/clr commit: 5b4e0321d4]
2022-07-24 21:35:26 -04:00
Jaydeep Patel 5b4e0321d4 SWDEV-345020 - The bit channel description should not allow any channels after a zero channel
Change-Id: I66e6d25c032d22f9616dc59730f1f094d30c01cf
2022-07-24 21:35:26 -04:00
Jonathan R. Madsen 3229ba1aba Added new tests validating gotcha wrappers (#105)
* Added new tests validating gotcha wrappers

* Update MPI example to use thread

* Tweaks to mpi-flat test and mpi_gotcha

- enabled MPI_Comm_size and MPI_Comm_rank in mpip so disabled them at runtime
- set test to collapse threads and processes

* Tweak to test and example

- mpi test sets GOTCHA_DEBUG=1 in env
- removed checking for MPI_{Comm_dup,Comm_group,Group_incl}
- tweaked tests so pthread_join is where it is expected

[ROCm/rocprofiler-systems commit: b1191b2831]
2022-07-24 20:33:52 -05:00
Jonathan R. Madsen b1191b2831 Added new tests validating gotcha wrappers (#105)
* Added new tests validating gotcha wrappers

* Update MPI example to use thread

* Tweaks to mpi-flat test and mpi_gotcha

- enabled MPI_Comm_size and MPI_Comm_rank in mpip so disabled them at runtime
- set test to collapse threads and processes

* Tweak to test and example

- mpi test sets GOTCHA_DEBUG=1 in env
- removed checking for MPI_{Comm_dup,Comm_group,Group_incl}
- tweaked tests so pthread_join is where it is expected
2022-07-24 20:33:52 -05:00
Sarbojit Sarkar 57473658dd SWDEV-343380 - Added hipDrvGetErrorName/String
Change-Id: If22d87b64f8ffc870c05482d28c7c91fb2b7d041


[ROCm/clr commit: 53be27a84f]
2022-07-24 21:32:48 -04:00
Sarbojit Sarkar 53be27a84f SWDEV-343380 - Added hipDrvGetErrorName/String
Change-Id: If22d87b64f8ffc870c05482d28c7c91fb2b7d041
2022-07-24 21:32:48 -04:00
Jenkins 5c19694589 SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: I37a15920fd97c85b2c090af8da96d178ee264afc


[ROCm/hip commit: 3aa38b08b4]
2022-07-24 19:10:20 -04:00
Jenkins 3aa38b08b4 SWDEV-299127 - Merge 'develop' into 'amd-staging'
Change-Id: I37a15920fd97c85b2c090af8da96d178ee264afc
2022-07-24 19:10:20 -04:00
Jonathan R. Madsen d4c8101a23 Release 1.3.0 preparations (#109)
* v1.3.0

* ROCm 5.2 and extensions tweaks

* Container workflow + miscellaneous updates

* Misc fixes + timemory submodule update

- timemory submodule update for multiple definitions of variant_apply

* Increase timeouts

* Remove obsolete Julia docs and script

- support for rocprofiler makes rocprof merging obsolete

* Fix cpack testing and combine cpack workflows into single script

* Install components + omnitrace tpl exes

- Improved COMPONENT specification for installs
- Install PAPI executables with omnitrace- prefix and hyphens
- Install Perfetto executables with omnitrace- prefix and hyphens

* Update docs on perfetto and papi command-line tools

* remove ubuntu 22.04 from containers workflow

* remove containers workflow running on all pushes

* Fix CI_SCRIPT_ARGS

* Fix PAPI utils install

* Fixed traced test in workflow + removed return char

- validate-perfetto-proto.py had return character

* Fix test-docker-release.sh script to use correct container

* Release build bc RelWtihDebInfo using too much memory

[ROCm/rocprofiler-systems commit: ea282d9301]
2022-07-23 03:02:31 -05:00
Jonathan R. Madsen ea282d9301 Release 1.3.0 preparations (#109)
* v1.3.0

* ROCm 5.2 and extensions tweaks

* Container workflow + miscellaneous updates

* Misc fixes + timemory submodule update

- timemory submodule update for multiple definitions of variant_apply

* Increase timeouts

* Remove obsolete Julia docs and script

- support for rocprofiler makes rocprof merging obsolete

* Fix cpack testing and combine cpack workflows into single script

* Install components + omnitrace tpl exes

- Improved COMPONENT specification for installs
- Install PAPI executables with omnitrace- prefix and hyphens
- Install Perfetto executables with omnitrace- prefix and hyphens

* Update docs on perfetto and papi command-line tools

* remove ubuntu 22.04 from containers workflow

* remove containers workflow running on all pushes

* Fix CI_SCRIPT_ARGS

* Fix PAPI utils install

* Fixed traced test in workflow + removed return char

- validate-perfetto-proto.py had return character

* Fix test-docker-release.sh script to use correct container

* Release build bc RelWtihDebInfo using too much memory
2022-07-23 03:02:31 -05:00
Jonathan R. Madsen 21b45e35f3 Pthread category region (#102)
* Perfetto args support for pthread functions

* Add pthread category

[ROCm/rocprofiler-systems commit: 0729e1737b]
2022-07-22 16:45:35 -05:00