This isn't the ideal solution, but a lot more cleanups are needed for
how install is used.
Change-Id: I63a9c1a46d0da13ee4373038ece228005207271a
[ROCm/clr commit: 80bc98afee]
This isn't the ideal solution, but a lot more cleanups are needed for
how install is used.
Change-Id: I63a9c1a46d0da13ee4373038ece228005207271a
[ROCm/hip commit: 9b39b95417]
On newer kernels, it seems the group was changed from "video" to
"render". The check for video group misled me for quite some time, so
relax this check. Rather than specifically checking for video group
ownership, first see if /dev/kfd can be open as read-write. Then
diagnose whether the user belongs to the group that owns it, rather
than hardcoding the video group.
Change-Id: I9e65427363e9a5cdba802e09cee2f40fb80520ed
[ROCm/rocminfo commit: cd4b7cea85]
On newer kernels, it seems the group was changed from "video" to
"render". The check for video group misled me for quite some time, so
relax this check. Rather than specifically checking for video group
ownership, first see if /dev/kfd can be open as read-write. Then
diagnose whether the user belongs to the group that owns it, rather
than hardcoding the video group.
Change-Id: I9e65427363e9a5cdba802e09cee2f40fb80520ed
This was already searching for the right threads library, but ignoring
the result.
Change-Id: I10d898245696135c1ef928c7715efce8ec6b939f
[ROCm/clr commit: 36432be962]
This was already searching for the right threads library, but ignoring
the result.
Change-Id: I10d898245696135c1ef928c7715efce8ec6b939f
[ROCm/hip commit: 253962c9c4]
The build should never touch the source directory, and only write
generated files to the output directory.
Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.
Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
[ROCm/clr commit: b618939e2e]
The build should never touch the source directory, and only write
generated files to the output directory.
Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.
Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
The build should never touch the source directory, and only write
generated files to the output directory.
Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.
Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
[ROCm/hip commit: b69e33038b]
The build should never touch the source directory, and only write
generated files to the output directory.
Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.
Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.
The top level CMakeLists also repeats exactly this, which should be
fixed.
Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
[ROCm/clr commit: bd4ec781f2]
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.
The top level CMakeLists also repeats exactly this, which should be
fixed.
Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.
The top level CMakeLists also repeats exactly this, which should be
fixed.
Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
[ROCm/hip commit: 1f5cc41d64]
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.
The top level CMakeLists also repeats exactly this, which should be
fixed.
Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
This will update the hipcc script so that it will use HIP_PLATFORM, HIP_COMPILER, and HIP_RUNTIME variables correctly based on updated hipconfig file.
Removing HIP_PLATFORM=clang, only use hcc and nvcc for now. HIP_PLATFORM should eventually switch to amd or nvcc.
Change-Id: Ie527d07a1add974cc3aab8e9f61b0518147d7602
[ROCm/clr commit: c729d52681]
This will update the hipcc script so that it will use HIP_PLATFORM, HIP_COMPILER, and HIP_RUNTIME variables correctly based on updated hipconfig file.
Removing HIP_PLATFORM=clang, only use hcc and nvcc for now. HIP_PLATFORM should eventually switch to amd or nvcc.
Change-Id: Ie527d07a1add974cc3aab8e9f61b0518147d7602
This will update the hipcc script so that it will use HIP_PLATFORM, HIP_COMPILER, and HIP_RUNTIME variables correctly based on updated hipconfig file.
Removing HIP_PLATFORM=clang, only use hcc and nvcc for now. HIP_PLATFORM should eventually switch to amd or nvcc.
Change-Id: Ie527d07a1add974cc3aab8e9f61b0518147d7602
[ROCm/hip commit: 2de1129510]
This will update the hipcc script so that it will use HIP_PLATFORM, HIP_COMPILER, and HIP_RUNTIME variables correctly based on updated hipconfig file.
Removing HIP_PLATFORM=clang, only use hcc and nvcc for now. HIP_PLATFORM should eventually switch to amd or nvcc.
Change-Id: Ie527d07a1add974cc3aab8e9f61b0518147d7602
Rachida Kebichi
Chris Freehill
Matt Arsenault
Michael LIAO
Chauncey Hui
Sean Keely
Ramesh Errabolu
Payam
Aaron En Ye Shi
Aaron Enye Shi
German Andryeyev