76333 کامیت‌ها
مولف SHA1 پیام تاریخ
Sarbojit2019 b5ff9e71ed Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 73e5c52d0d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/hip commit: 0722704f35]
2019-08-29 01:02:59 +00:00
Sarbojit2019 0722704f35 Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
2019-08-29 01:02:41 +00:00
Sarbojit2019 1ae43cbeba [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
Sarbojit2019 74a3171c6b [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/hip commit: 5c4f78bac3]
2019-08-29 01:02:41 +00:00
Sarbojit2019 5c4f78bac3 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
satyanveshd 63025d487f [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/hip-tests commit: 39de5ed699]
2019-08-29 01:01:49 +00:00
satyanveshd 39de5ed699 [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
2019-08-29 01:01:49 +00:00
satyanveshd 0e4701d59f [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/clr commit: d2df21e58c]
2019-08-29 01:01:49 +00:00
satyanveshd d2df21e58c [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
2019-08-29 01:01:49 +00:00
satyanveshd f378b67565 [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/hip commit: f807cc1a7b]
2019-08-29 01:01:49 +00:00
satyanveshd f807cc1a7b [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
2019-08-29 01:01:49 +00:00
mshivama 757aa67a43 Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/clr commit: f74903851e]
2019-08-29 01:01:25 +00:00
mshivama f74903851e Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support
2019-08-29 01:01:25 +00:00
mshivama 37779f5bef Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/hip commit: d75dc4eb29]
2019-08-29 01:01:25 +00:00
mshivama d75dc4eb29 Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support
2019-08-29 01:01:25 +00:00
Yong Zhao dbe9af7777 libhsakmt: Improve the confusing code
The code tends to confuse readers. Improve it.

Change-Id: I5c6cbf7a114b6e7d26ce3b9f54350a153032267d
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
2019-08-28 18:43:24 -04:00
Yong Zhao b4fa91b983 libhsakmt: Improve the confusing code
The code tends to confuse readers. Improve it.

Change-Id: I5c6cbf7a114b6e7d26ce3b9f54350a153032267d
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>


[ROCm/ROCR-Runtime commit: dbe9af7777]
2019-08-28 18:43:24 -04:00
foreman 21f12be15a P4 to Git Change 1990620 by gandryey@gera-win10 on 2019/08/28 18:04:54
SWDEV-200422 - Teamcity built OpenCL ignores all options from LC backend
	- Disable default arguments for ParseAllOptions() to avoid incorrect values

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#609 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#104 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#48 edit


[ROCm/clr commit: cb4e7b6be6]
2019-08-28 18:09:33 -04:00
foreman cb4e7b6be6 P4 to Git Change 1990620 by gandryey@gera-win10 on 2019/08/28 18:04:54
SWDEV-200422 - Teamcity built OpenCL ignores all options from LC backend
	- Disable default arguments for ParseAllOptions() to avoid incorrect values

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#609 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#104 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#48 edit
2019-08-28 18:09:33 -04:00
Evgeny Mankov 65ba03dd4c [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly


[ROCm/clr commit: 32f22a0117]
2019-08-28 21:17:35 +03:00
Evgeny Mankov 32f22a0117 [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly
2019-08-28 21:17:35 +03:00
Evgeny Mankov e78eb9bb47 [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly


[ROCm/hip commit: 24be21495d]
2019-08-28 21:17:35 +03:00
Evgeny Mankov 24be21495d [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly
2019-08-28 21:17:35 +03:00
Evgeny Mankov bd631e815b Merge pull request #1371 from emankov/master
[HIPIFY][cmake] Minor refactoring

[ROCm/clr commit: 7b9f2a8471]
2019-08-28 20:42:41 +03:00
Evgeny Mankov 7b9f2a8471 Merge pull request #1371 from emankov/master
[HIPIFY][cmake] Minor refactoring
2019-08-28 20:42:41 +03:00
Evgeny Mankov d81b612791 Merge pull request #1371 from emankov/master
[HIPIFY][cmake] Minor refactoring

[ROCm/hip commit: 1ab81d9ce6]
2019-08-28 20:42:41 +03:00
Evgeny Mankov 1ab81d9ce6 Merge pull request #1371 from emankov/master
[HIPIFY][cmake] Minor refactoring
2019-08-28 20:42:41 +03:00
Evgeny Mankov 676c4b5bd4 [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions


[ROCm/clr commit: e3eb62ac4b]
2019-08-28 20:40:10 +03:00
Evgeny Mankov e3eb62ac4b [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions
2019-08-28 20:40:10 +03:00
Evgeny Mankov 4cf4ca2e4f [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions


[ROCm/hip commit: eeb4452b23]
2019-08-28 20:40:10 +03:00
Evgeny Mankov eeb4452b23 [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions
2019-08-28 20:40:10 +03:00
foreman e383596776 P4 to Git Change 1990159 by chui@ocl-promo-incrementor on 2019/08/28 03:00:28
SWDEV-2 - Change OpenCL version number from 2983 to 2984.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2731 edit


[ROCm/clr commit: c875e5bbf2]
2019-08-28 03:07:50 -04:00
foreman c875e5bbf2 P4 to Git Change 1990159 by chui@ocl-promo-incrementor on 2019/08/28 03:00:28
SWDEV-2 - Change OpenCL version number from 2983 to 2984.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2731 edit
2019-08-28 03:07:50 -04:00
foreman 649d08488c P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit


[ROCm/clr commit: 534727cd01]
2019-08-27 20:26:25 -04:00
foreman 534727cd01 P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit
2019-08-27 20:26:25 -04:00
foreman d93d935ac7 P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit


[ROCm/hip commit: dd07e24c2b]
2019-08-27 20:26:25 -04:00
foreman dd07e24c2b P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit
2019-08-27 20:26:25 -04:00
amdkila ea0ce5c064 Merge pull request #128 from amdkila/hip-clang
Added hip-clang options to install script, and openmp/pthread flags

[ROCm/rccl commit: 259583cde6]
2019-08-27 16:23:40 -06:00
amdkila 259583cde6 Merge pull request #128 from amdkila/hip-clang
Added hip-clang options to install script, and openmp/pthread flags
2019-08-27 16:23:40 -06:00
foreman 829683906f P4 to Git Change 1989702 by gandryey@gera-win10 on 2019/08/27 11:49:38
SWDEV-200489 - [CQE OCL][QR][Windows][Vega20][19H1] Performance drop is observed while running Blender on Vega20 due to faulty CL#1981122
	- Switch scratch buffer allocation algorithm back to the optimal size calculation with sync mode. Some kernels will run slower if max scratch per queue is programmed unconditionally due to possible lower memory efficiency with fetches

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#160 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#45 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#149 edit


[ROCm/clr commit: 07aff986ce]
2019-08-27 11:55:54 -04:00
foreman 07aff986ce P4 to Git Change 1989702 by gandryey@gera-win10 on 2019/08/27 11:49:38
SWDEV-200489 - [CQE OCL][QR][Windows][Vega20][19H1] Performance drop is observed while running Blender on Vega20 due to faulty CL#1981122
	- Switch scratch buffer allocation algorithm back to the optimal size calculation with sync mode. Some kernels will run slower if max scratch per queue is programmed unconditionally due to possible lower memory efficiency with fetches

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#160 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#45 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#149 edit
2019-08-27 11:55:54 -04:00
foreman 03a3c1738c P4 to Git Change 1989679 by gandryey@gera-win10 on 2019/08/27 11:34:19
SWDEV-200422 - Teamcity built OpenCL ignores all options from LC backend
	- Pass LC argument into parseAllOptions()

	http://ocltc.amd.com/reviews/r/17884/

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/options.cpp#46 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/options.hpp#22 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#103 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#47 edit


[ROCm/clr commit: 6547f9e31b]
2019-08-27 11:42:23 -04:00
foreman 6547f9e31b P4 to Git Change 1989679 by gandryey@gera-win10 on 2019/08/27 11:34:19
SWDEV-200422 - Teamcity built OpenCL ignores all options from LC backend
	- Pass LC argument into parseAllOptions()

	http://ocltc.amd.com/reviews/r/17884/

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/options.cpp#46 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/options.hpp#22 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#103 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.hpp#47 edit
2019-08-27 11:42:23 -04:00
Kent Russell ccac07cb14 topology: Fix compile warnings regarding snprintf and path
snprintf throws a warning from -Wformat-truncation where the string
could be truncated. We address this by referencing the maximum size that
can be returned from a file according to MAXNAMLEN . This should safely
guard us from truncating the path value.

Change-Id: If1d208990d8775e9494835b0deb890d2616fd15b
Signed-off-by: Kent Russell <kent.russell@amd.com>
2019-08-27 11:06:06 -04:00
Kent Russell 2fc7cb6a62 topology: Fix compile warnings regarding snprintf and path
snprintf throws a warning from -Wformat-truncation where the string
could be truncated. We address this by referencing the maximum size that
can be returned from a file according to MAXNAMLEN . This should safely
guard us from truncating the path value.

Change-Id: If1d208990d8775e9494835b0deb890d2616fd15b
Signed-off-by: Kent Russell <kent.russell@amd.com>


[ROCm/ROCR-Runtime commit: ccac07cb14]
2019-08-27 11:06:06 -04:00
Chris Freehill 0bcdfe553d Make bdfid use 32 bit domain if possible
If the 32-bit domain is found in the kfd node properties for
a device, then it will be used when constructing the bdfid.
If it's not present, it will continue to use the 16 bit version.

Also, whether or not 32b or 16b are used for the domain, the
domain will now be placed in the upper 32b of the 64b bdfid.

* Fixed some unrelated doxygen issues

Change-Id: Icb5116daa1ab45ee305bdbe6cd5df5736dd3ffa3


[ROCm/rocm_smi_lib commit: 469af303d6]
2019-08-27 11:05:58 -04:00
Chris Freehill 469af303d6 Make bdfid use 32 bit domain if possible
If the 32-bit domain is found in the kfd node properties for
a device, then it will be used when constructing the bdfid.
If it's not present, it will continue to use the 16 bit version.

Also, whether or not 32b or 16b are used for the domain, the
domain will now be placed in the upper 32b of the 64b bdfid.

* Fixed some unrelated doxygen issues

Change-Id: Icb5116daa1ab45ee305bdbe6cd5df5736dd3ffa3
2019-08-27 11:05:58 -04:00
Chris Freehill b51bf32bd4 Make bdfid use 32 bit domain if possible
If the 32-bit domain is found in the kfd node properties for
a device, then it will be used when constructing the bdfid.
If it's not present, it will continue to use the 16 bit version.

Also, whether or not 32b or 16b are used for the domain, the
domain will now be placed in the upper 32b of the 64b bdfid.

* Fixed some unrelated doxygen issues

Change-Id: Icb5116daa1ab45ee305bdbe6cd5df5736dd3ffa3


[ROCm/amdsmi commit: 469af303d6]
2019-08-27 11:05:58 -04:00