Madsen, Jonathan
e743bf5a93
Undefined behavior warnings caught by ROCPROFILER_DEFAULT_FAIL_REGEX ( #23 )
...
* Add regex for undefined behavior to ROCPROFILER_DEFAULT_FAIL_REGEX
- add UBSAN_OPTIONS to setup-sanitizer-env.sh
* Improve ROCPROFILER_DEFAULT_FAIL_REGEX
* Use -fno-sanitize-recover=undefined flag
- this compiler flag causes all undefined behavior errors to exit
* Revert ROCPROFILER_DEFAULT_FAIL_REGEX
* fix for shift overflow
---------
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
Co-authored-by: Manjunath-Jakaraddi <manjunath.jakaraddi@amd.com >
2025-02-06 08:55:57 -06:00
Rawat, Swati
97b7a6315d
update copyright date to 2025 ( #102 )
...
* Update LICENSE
* Update conf.py
* Update copyright year
* [fix] Update copyright year
* Update copyright year "ROCm Developer Tools"
* Add license headers to c++ files
* Add license to *.py
* Update licenses in rocdecode sources
---------
Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com >
Co-authored-by: Mythreya <mythreya.kuricheti@amd.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
2025-01-22 19:11:20 -06:00
Baraldi, Giovanni
2c8e88a76b
SWDEV-492607: Adding ATT wrapper ( #40 )
...
* Adding att parser wrapper
* Adding ATT tests as optional
* Adding decoder API for query capability
* Removed samples
* Formatting
* adding new line
* Removed perfetto and moved to static library
* using default search for lib
* Updated to SDK
* Namespace changes
* Added tests
* Small refactor
* Updated API to receive agent_id
* Fixing tests
* Tidy fixes
* Not write to file
* Switch to filesystem.hpp
* Compilation fixes
* Formatting
* Tidy fix
* Removed likely
* Adding tests
* Added gfx9 test
* Adding gfx12 tests
* Formatting
* Enable tidy
* Fix tests
* Fix deadlock on agent test
* Workaround ASAN
* Moving query outside class.
* Fix standalone tool
* Addressing comments
* Formatting
* Change query name
* Fixed some tests. Updated PR comments.
* Formatting
* Improved coverage
* Formatting
* Fix for comments
* Formatting
* Adding some description. Fix error type.
---------
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com >
2024-12-18 18:53:32 -08:00
Jonathan R. Madsen
74facf87a6
CMake: Consistently name CMake Targets ( #1082 )
...
* Change all rocprofiler-X target names to rocprofiler-sdk-X
* Update rocprofiler-sdk-config.cmake
- fix install tree target names
- simplify logic for using find w/ components and find w/o components
* Update rocprofiler-sdk-roctx-config.cmake
- simplify logic for using find w/ components and find w/o components
* Update samples/intercept_table/CMakeLists.txt
- demonstrate/test use of `find_package(rocprofiler-sdk ... COMPONENTS ...)`
2024-10-25 11:17:34 -05:00
venkat1361
3f91d90bbc
Check to force tools to initialize the ctx id to zero. ( #1135 )
...
* Check to force tool to initialize the ctx id to zero.
* initialize rocprofiler_context_id_t with 0 in units tests
* changelog
---------
Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com >
2024-10-22 18:09:25 +05:30
Giovanni Lenzi Baraldi
fa1b9e67ab
ATT Agent fixes and improvements ( #1011 )
...
* Tidying ATT dispatch API. ATT Agent to be initialized with rest of profiler. Removing read_index-based wait.
* Formatting
* Adding some input validation
* Add perf test for agent
* Removing async
2024-08-15 13:57:13 -03:00
Giovanni Lenzi Baraldi
04a38ce034
Adding barrier bit on packets after dispatch ( #981 )
...
Co-authored-by: Gopesh Bhardwaj <gopesh.bhardwaj@amd.com >
2024-07-22 22:39:56 +05:30
Jonathan R. Madsen
1e49b43738
Miscellaneous updates ( #959 )
...
- missing-new-line CI job: ensures all source files end with new line
- logging updates
- add new line to the end of many files
- fix header include ordering is misc places
- transition to use hsa::get_core_table() and hsa::get_amd_ext_table() in various places instead of making copies
2024-07-08 16:50:32 -05:00
Giovanni Lenzi Baraldi
4e2144dbfa
General fixes to ATT, packets and event ID retrieval ( #960 )
...
* General fixes to ATT, packets and event ID retrieval
* Update source/lib/rocprofiler-sdk/hsa/aql_packet.hpp
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-04 03:58:45 -03:00
Giovanni Lenzi Baraldi
a78753d392
Accumulation metrics support and update counter collection API to aqlprofile_v2 ( #915 )
...
* Updating to v3 API
* General fixes
* Extending dimension bits to 54
* Disabling agent profiling tests
* Fixed unit test
* Adding accumulate metric support for parsing counters (#609 )
* Adding accumulate metric support for parsing counters
* Adding metric flag
* Updating tests
* source formatting (clang-format v11) (#610 )
Co-authored-by: Manjunath-Jakaraddi <21177428+Manjunath-Jakaraddi@users.noreply.github.com >
* source formatting (clang-format v11) (#614 )
Co-authored-by: jrmadsen <6001865+jrmadsen@users.noreply.github.com >
* Adding evaluate ast test
* source formatting (clang-format v11) (#633 )
Co-authored-by: Manjunath-Jakaraddi <21177428+Manjunath-Jakaraddi@users.noreply.github.com >
* Update scanner generated file
* Adding flags to events for aqlprofile
* Fix Mi200 failing test
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Manjunath-Jakaraddi <21177428+Manjunath-Jakaraddi@users.noreply.github.com >
Co-authored-by: jrmadsen <6001865+jrmadsen@users.noreply.github.com >
* Revert "Extending dimension bits to 54"
This reverts commit 3cd6628452484044a93e129f27974f996a0e4c08.
* Removing CU dimension
* Fixing merge conflicts
* Revert "Disabling agent profiling tests"
This reverts commit 7e01518ed8c51fbb0c3b2575e1e0b8f9ddfa8237.
* Fixing merge conflicts
* Fix parser tests
* Adding accumulate metric documentation
* Update counter_collection_services.md
* Update index.md
* fix nested expression use
* Update source/lib/rocprofiler-sdk/counters/evaluate_ast.cpp
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Doc update
---------
Co-authored-by: Benjamin Welton <ben@amd.com >
Co-authored-by: Manjunath P Jakaraddi <manjunath180397@gmail.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Manjunath-Jakaraddi <21177428+Manjunath-Jakaraddi@users.noreply.github.com >
Co-authored-by: jrmadsen <6001865+jrmadsen@users.noreply.github.com >
Co-authored-by: Manjunath-Jakaraddi <manjunath.jakaraddi@amd.com >
2024-07-01 21:56:41 -03:00
Giovanni Lenzi Baraldi
9676295d3d
ATT API changes - add user_data field and separation of dispatch vs agent profiling ( #893 )
...
* DRM Issue Fix for SLES 15 (#897 )
* DRM Issue Fix
* Formatting Fix
* PC sampling: CID manager unit test (#898 )
* Adding per-dispatch userdata field to ATT
* Clang tidy
* Formatting
* Update source/lib/rocprofiler-sdk/hsa/aql_packet.hpp
Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com >
* Adding dispatch_id, fixing user_data and update aql_profile_v2
* Formatting
* Tidy fixes
* Second fix for userdata
* removing assert for union
* Adding serialization. Created agent profiling-like thread trace
* Implemented agent thread trace
* Update source/lib/rocprofiler-sdk/hsa/aql_packet.hpp
Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com >
* Restructured thread trace packets
* Added agent API tests
* Fixing multigpu for agent test
* Formatting
* Formatting
* Improving header locations
* Fixing merge conflicts
* Tidy
* Tidy
* Tidy
---------
Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com >
Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com >
2024-06-13 15:29:29 -03:00
Benjamin Welton
99340964a6
Fix for SLES/RHEL compilers ( #925 )
...
* Fix for SLES/RHEL compilers
---------
Co-authored-by: Benjamin Welton <ben@amd.com >
2024-06-12 20:38:35 -07:00
Manjunath P Jakaraddi
c49719649b
SWDEV-465322: Adding support for Perfcounter SIMD Mask in ATT ( #910 )
...
* SWDEV-465322: Adding support for r Perfcounter SIMD Mask in ATT
* Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com >
* Adding unit tests
* Adding counters check for gfx9 and SQ block only
* Addressing review comments
* changing the struct size
* fixing header includes
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com >
2024-06-12 16:25:06 -07:00
Benjamin Welton
cfe3af9d7e
Remove duplicate table code from tests ( #922 )
...
* Remove duplicate table code from tests
Remove duplicate HSA table code from tests. Cleanup
includes (and remove unnecessary ones).
2024-06-12 13:21:42 -07:00
Jonathan R. Madsen
a76f61a0a3
Migrate to rocprofiler-sdk:: namespace in CMake everywhere ( #892 )
...
- remove all usage/support for rocprofiler:: namespace
2024-05-29 22:28:43 -05:00
Giovanni Lenzi Baraldi
1b95089c28
Enable ATT continuous mode and code object tracing registration ( #850 )
...
* Adding ATT continuous mode and ATT code object tracking
* Fixing aql_packet.cpp
* Updating to aqlprofile codeobj changes
* Removing kernel packet from ATT dispatch callback
* Changing getSymbolMap() to return relative vaddr
* Tidy fixes
* Formatting
* Fix shadowing
* Fixing packet test
* Updating tests
* Simplifying multi-agent traces
* Adding dynamic codeobj tracking
* leftover book-keeping for codeobj markers
* Formatting
* Formatting
* Temporary removing codeobj marker
* Formatting
* Re-enabling codeobj tracking
* Making copy of coreapi table
* Fixing issues with toolData lifetile
* Formatting
* Fixing issues with ASAN
* Improving memory profile
* Removing misplaced annotation
* Fixing queue type and allowing shared_locks in globalThreadTracer
* Update logging
* Changing ATT formats to be more in line with the SDk (#883 )
* Fixing some merge conflicts
* Fixing cmakelists
* Fixing merge conflicts
* Formatting
2024-05-29 11:09:28 -05:00
Giovanni Lenzi Baraldi
099ac7c72d
Gbaraldi/att tool ( #766 )
...
* Enabling codeobj and thread trace samples
* Updating aqlprofile_v2 header
* Codeobj and thread trace samples with output log files
* Fixing clang format
* Cmake formatting
* Adding coverage to codeobj
* Comment trace sample
* Adding ATT Parser API
* Fixing forwarding to aqlprofile
* Clang formatting
* Clang tidy
* Adding option to print memory kernels
* Clang format
* Remove default from switch case
* Separating client/main on codeobj sample for ASAn
* Formatting
* Gbaraldi/att tool rebase (#801 )
* Enabling codeobj and thread trace samples
* Updating aqlprofile_v2 header
* Codeobj and thread trace samples with output log files
* Fixing clang format
* Cmake formatting
* Adding coverage to codeobj
* Comment trace sample
* Removing python from workflow
* Adding ATT Parser API
* Fixing forwarding to aqlprofile
* Clang formatting
* Clang tidy
* Adding option to print memory kernels
* Clang format
* Remove default from switch case
* Separating client/main on codeobj sample for ASAn
* Formatting
* Enabling codeobj and thread trace samples
* Updating aqlprofile_v2 header
* Codeobj and thread trace samples with output log files
* Fixing clang format
* Cmake formatting
* Adding coverage to codeobj
* Comment trace sample
* Adding ATT Parser API
* Fixing forwarding to aqlprofile
* Clang formatting
* Clang tidy
* Adding option to print memory kernels
* Clang format
* Remove default from switch case
* Separating client/main on codeobj sample for ASAn
* Formatting
* Fix codeobj library
* Allow thread trace in parallel with other service
* Zeroing the HSA signals
* Adding exception wrappers in ATT sample
* Removed force configure
* Remove force configure from ISA decode
* Removing codecov flag
* Gbaraldi/att tool tests (#828 )
* Adding tests for codeobj ISA decode
* Adding ATT tests
* Adding ATT integration tests
* Formatting
* Changing codeobj binary extension
* Renaming codeobj library spaces
* Fixing samples
* Formatting
* Formatting
* Fixing int test
* Fixing linker error
* Fixing memory fault
* Moving kernel ot inside namespace
* ASAN linking fix
* Removing unecessary headers
* Formatting
* Fixing target_cu
* Remove codeobj binary
* Revert "Remove codeobj binary"
This reverts commit 7d286f89d8096bc36925cd79cd742a5e6d10d179.
* Enable memory snapshot
* adding comgr
---------
Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com >
2024-05-03 18:45:47 -03:00