Commit Graph

10773 Commits

Author SHA1 Message Date
Elwazir, Ammar 6f21d49129 Update sync-staging.yaml 2025-06-24 15:16:07 -05:00
Ken O'Brien 7b8a6f8ca2 rocr: Fixes memory allocation issue
Fixes a bug in memory allocation in which dmabuf export only works on
GPU 0 in a multi-GPU environment.
2025-06-24 14:53:14 -04:00
dependabot[bot] 3a0985c68a Bump rocm-docs-core[api_reference] from 1.20.1 to 1.21.0 in /docs/sphinx (#262)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.20.1 to 1.21.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.20.1...v1.21.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-24 12:33:13 -04:00
David Galiffi 3668e603cc Update CHANGELOGS (#248)
* Update CHANGELOGS

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CHANGELOG.md

Clarify Fortran support on CHANGELOGS

* Update CHANGELOG.md

Fixed typo

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-06-24 11:10:26 -04:00
Sunday Clement d2b35dfee6 rocrtst: Add new test for querying Clock Counters
added new subtest to Agent Properties test, to check functionality of
query.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-23 18:45:09 -04:00
Sunday Clement e97d06530e rocr: Add hsa-agent Queries for Clock Counters
Support has been added to query the following
HSA_AMD_INFO_GET_CLOCK_COUNTERS agent info exposed through the hsa api
in rocr, rather than the user having to make a direct IOCTL call
through the kernel driver.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-23 18:45:09 -04:00
Elwazir, Ammar 524d1c64e5 Update sync-staging.yaml 2025-06-23 17:21:40 -05:00
Elwazir, Ammar ba162dd76a Update sync-staging.yaml 2025-06-23 17:20:32 -05:00
Elwazir, Ammar 0578cc6dd7 Update sync-mainline.yaml 2025-06-23 17:20:19 -05:00
Elwazir, Ammar 9ac4373f1b Fixing v2 header location (#127)
Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-06-23 17:17:35 -05:00
Elwazir, Ammar e4bb0df9d5 Adding Integration tests for later building option (#126)
* Adding Integeration tests for later building option

* Update CMakeLists.txt

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-06-23 16:53:17 -05:00
Tony Gutierrez e03d44d742 rocr: Update Driver queue-related APIs
Update the user-mode driver queue APIs to leverage KMT types.

Move queue-related calls to the core::Driver API.
2025-06-23 12:21:01 -07:00
Kian Cossettini 8457cb11be Added docker usage steps for rocprofiler systems (#251)
---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: Pratik Basyal <pratik.basyal@amd.com>
2025-06-23 15:19:47 -04:00
Elwazir, Ammar af750616db Posting fixes for tests link library (#125)
Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-06-23 12:30:29 -05:00
Baraldi, Giovanni f3b2d498b8 Remove default dependency of rocm-llvm-dev (#124)
* Remove default dependency of rocm-llvm-dev

* Update build.sh

* Update build.sh

* Update CMakeLists.txt

* Fixing core tests

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>
Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-06-23 12:13:27 -05:00
David Galiffi 122623a929 Use gersemi for CMake formatting (#257)
* Replace `cmake-format` with `gersemi`

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Remove .cmake-format.yaml

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update workflow to use gersemi

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CONTRIBUTING.md

* Update helper scripts

* Don't include `*/external/*` in workflows

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-22 10:44:33 -04:00
David Galiffi 1e13b590e7 Use clang-format-18 for source formatting (#256)
* Updating clang-format to v18

- Updates the pre-commit-config
- Formats source files according to the utility

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update format source workflow

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Update CONTRIBUTING

* Update comment in .clang-format

* Update CONTRIBUTING.md

* Update helper script

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-22 08:48:08 -04:00
vedithal-amd 5950a02ff6 Fix counter collection for MI 350 (#764)
* Fix TCC counter collection bug
* Fix accumulate counter collection
* Fix formatting
2025-06-21 08:48:25 -04:00
Vaddireddy, Sushma 8b956a1f39 Added install target for simple-hip executable (#10)
* Added install target for simple-hip executable

* Updating destination path

* Update CMakeLists.txt

* Update CMakeLists.txt

* Test Installed Packages

* Updating Destination path

* Update continuous-integration.yml

* Update continuous-integration.yml

* Adding env

* Adding PACKAGING_INSTALL_PREFIX

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Add libasan.so path for AddressSanitizer preloadiing

* Add libasan.so path for AddressSanitizer preloadiing

* Add libasan.so path for test test-simple-hip-normal

* Added sanitizer runtime library for tests

* Added LD_PRELOAD to simple-hip-normal-env test

* Added LD_PRELOAD to simple-hip-normal-env test

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Formatting

* Updated path for simple-hip-preload-env

* Updated path for simple-hip-preload-env

* Update continuous-integration.yml

* Updated preload path for  simple-hip-preload-env

* Updated preload path for  simple-hip-preload-env

---------

Co-authored-by: Sushma Vaddireddy <svaddire@amd.com>
Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>

[ROCm/rocprofiler-register commit: 03d58213b9]
2025-06-20 13:54:40 -05:00
Vaddireddy, Sushma 03d58213b9 Added install target for simple-hip executable (#10)
* Added install target for simple-hip executable

* Updating destination path

* Update CMakeLists.txt

* Update CMakeLists.txt

* Test Installed Packages

* Updating Destination path

* Update continuous-integration.yml

* Update continuous-integration.yml

* Adding env

* Adding PACKAGING_INSTALL_PREFIX

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Update continuous-integration.yml

* Add libasan.so path for AddressSanitizer preloadiing

* Add libasan.so path for AddressSanitizer preloadiing

* Add libasan.so path for test test-simple-hip-normal

* Added sanitizer runtime library for tests

* Added LD_PRELOAD to simple-hip-normal-env test

* Added LD_PRELOAD to simple-hip-normal-env test

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Formatting

* Updated path for simple-hip-preload-env

* Updated path for simple-hip-preload-env

* Update continuous-integration.yml

* Updated preload path for  simple-hip-preload-env

* Updated preload path for  simple-hip-preload-env

---------

Co-authored-by: Sushma Vaddireddy <svaddire@amd.com>
Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>
2025-06-20 13:54:40 -05:00
Jason Bonnell 44c3516b8b Ignore certain workflows when changes are only for .md, docs, and docker (#754)
* add paths-ignore for both push and PR to rhel-8.yml and ubuntu-jammy.yml

* add paths-ignore for PR only in tarball.yml

* add rocm-docs-core linting.yml workflow to formatting.yml

* fix small mistake in github directory path

* remove rocm-docs-core linting
2025-06-20 09:26:28 -04:00
Sajina PK e3741f678b Show VCN and JPEG busy values where VCN/JPEG activity is not supported. (#232)
On AMD-SMI, in rocm 7.0, vcn_activity and jpeg_activity will not be reported when XCP (partition) stats, vcn_busy and jpeg_busy, are available. This causes the activity tracking to fail. The fix is to read the busy values when activity values are not supported.

For issue: SWDEV-536439

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-19 16:23:30 -04:00
Samuel Thibault 8ca4207d5c rsmi_init: Do not complain loudly when no driver is found
When librocm-smi is pulled through a dependency, we may end up on a system
without actual hardware supported by ROCM, and rsmi_init() failing is
actually expected, we do want to frighten the user in such a case.
2025-06-19 13:30:51 -05:00
David Galiffi 20efb9641f Update pull_request_template.md (#258)
Rewording the "related issues" comments
2025-06-19 11:06:13 -04:00
Yat Sin, David 16ae2e90c6 Remove unnecessary dependency on hsakmt (#57) 2025-06-18 21:01:23 -05:00
Yat Sin, David 1360fbfd64 Remove unnecessary dependency on hsakmt (#57)
[ROCm/rocprofiler commit: 16ae2e90c6]
2025-06-18 21:01:23 -05:00
ajanicijamd 4346c1c217 Modified nic-performance test to download a smaller file (#253) 2025-06-18 19:39:48 -04:00
David Yat Sin b3c48cc68c rocr: support reserving non-registered VA
Extend hsa_amd_vmem_address_reserve/hsa_amd_vmem_address_reserve_align
to support HSA_AMD_VMEM_ADDRESS_NO_REGISTER flag. This allocation can be
used to reserve virtual address ranges that can later be used by
hsa_amd_svm_attributes_set for SVM based memory allocations.
2025-06-18 18:21:11 -04:00
jamessiddeley-amd 036866fc12 added progress printout in rocprof-compute profile (#727)
* added progress printout for profiler

* added comments and fixed readability

* removed redundant newlines

* moved format_time helper function to utils

* removed tqdm and redundant time calc
2025-06-18 14:09:09 -04:00
xuchen-amd 5d8fd55e36 Integrate roofline in tui (#762)
* Update changelog, remove unused code.

* enable roofline in TUI.

* Remove roofline section when data not available.

* Fix workload dir path.
2025-06-18 13:58:42 -04:00
Luu, Jonathan 337cbeba6f SWDEV-531400 - Remove File reorganization backward computability (roctracer) (#40)
* SWDEV-531400 - Remove File reorganization backward computability (roctracer)

* removing no longer needed files

---------

Co-authored-by: Jonathan Luu <jonatluu@amd.com>

[ROCm/roctracer commit: 9a620d64d9]
2025-06-18 13:33:41 -04:00
Luu, Jonathan 9a620d64d9 SWDEV-531400 - Remove File reorganization backward computability (roctracer) (#40)
* SWDEV-531400 - Remove File reorganization backward computability (roctracer)

* removing no longer needed files

---------

Co-authored-by: Jonathan Luu <jonatluu@amd.com>
2025-06-18 13:33:41 -04:00
xuchen-amd 80159ee117 CLI: enable roofline plot (#760)
* enable roofline plot in cli.

* Add roofline to analysis config.

* Unify global variables.

* Disable roofline for baseline comparison and gfx908.

* Add check for roofline.csv
2025-06-18 13:19:58 -04:00
Pratik Basyal 66e71574ba Broken link to ROCprofiler-SDK updated (#254) 2025-06-18 13:15:18 -04:00
Daniel Su 475d6c0f1f Add thread header to videodecode example (#252) 2025-06-18 12:40:24 -04:00
Baraldi, Giovanni 9dadbbace5 Adding doc links for trace decoder, aqlprofile and viewer (#464)
Adding interlinks for trace decoder, aqlprofile and viewer

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-06-18 14:10:18 +02:00
Chris Freehill 24f36de037 rocr: Add missing close of dmabuf after import 2025-06-17 20:22:34 -04:00
vedithal-amd b16256fd07 Add docker files for testing (#761) 2025-06-17 16:18:35 -04:00
Elwazir, Ammar 2f771e6107 Create external PR Workflow (#118)
Create external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Separating Internal and External Workflows (#119)

* Separating Internal and External Workflows

* Update continuous_integration.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr.yml

Create external-pr-sync.yml (#121)

* Create external-pr-sync.yml

* Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr.yml

Update external-pr.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Update external-pr-sync.yml

Create external-pr-close.yml

 Fixing External PR Workflows

 Fixing External PR Workflows

 Fixing External PR Workflows
2025-06-17 14:55:35 -05:00
Trowbridge, Ian 883a57ece7 [SDK] [CI] Update HSA EXT Step Version (#460)
Update HSA EXT step version
2025-06-17 08:55:58 -07:00
Trowbridge, Ian 191778f071 Add copyright disclaimer for new files (#16)
[ROCm/rocprofiler-register commit: 19fe192e8f]
2025-06-17 10:34:21 -05:00
Trowbridge, Ian 19fe192e8f Add copyright disclaimer for new files (#16) 2025-06-17 10:34:21 -05:00
Elwazir, Ammar 8dad9518dc Add test target to the default build target (#117)
Signed-off-by: zichguan-amd <zichuan.guan@amd.com>
Co-authored-by: zichguan-amd <zichuan.guan@amd.com>
2025-06-17 10:13:37 -05:00
David Galiffi 244c193a57 Unhandled enum in switch statement (#247)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-17 09:57:27 -04:00
Elwazir, Ammar aeb1621c2b [SDK] Support CMake option for using internal RCCL tracing + (temporary) enable in CI (#457)
* Temp: disable RCCL tracing

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Adding option to disable rccl tracing from CMake

* Update codeql.yml

* Misc updates

- ROCPROFILER_BUILD_RCCL -> ROCPROFILER_INTERNAL_RCCL_API_TRACE
- env.EXTRA_TEMP_CMAKE_OPTIONS -> env.GLOBAL_CMAKE_OPTIONS
- add (advanced) option ROCPROFILER_INTERNAL_RCCL_API_TRACE

* Fix rocprofiler::sdk::get_enum_label

- missing enum labels for HIP_RUNTIME_API_TABLE_STEP_VERSION > 8

* Update tests/rocprofv3/advanced-thread-trace/CMakeLists.txt

- improve various aspect of cmake -- particularly echoing where attdecoder_LIBRARY was found

* Use CMAKE_MESSAGE_INDENT

- add prefix to cmake messages to help indicate where messages are coming from
- make find_package(Python3 ...) QUIET for bindings

* Fix rocprofiler::sdk::get_enum_label

- handle HSA_AMD_EXT_API_TABLE_MAJOR_VERSION

* Fix rocprofv3 message for att library path

* Fix tests/rocprofv3/advanced-thread-trace/att_input.yml config

* Fix rocprofv3 check_att_capability + soversion/version library resolution

- Account for ROCPROF_ATT_LIBRARY_PATH in env in check_att_capability
- Add resolve_library_path
  - supports resolution of library names to SOVERSION and VERSION paths

* Fix python linting error (unused import)

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-06-17 08:32:54 -05:00
Bhardwaj, Gopesh 3e43b1f019 Adding rocpd documenation (#449)
* Adding rocpd docuemenation

* rocpd format

* CHANGELOG update and indexing

* Fixing links

* format fixes

* fixing table

* major edits

* fixed logical error

* fixing rocprofv3 avail
2025-06-17 15:41:53 +05:30
David Yat Sin 649ec63a4f rocrtst: Reduce host memory limit to 90%
Further reduce upper bound for rocrtstFunc.Memory_Max_Mem
as previous limit of 95% can still trigger OOM killer.
2025-06-16 21:02:20 -04:00
David Yat Sin 488cfd467c rocr: Always send free scratch notifications
Always send notification to profiler tools when scratch memory is freed.
2025-06-16 17:39:33 -04:00
Vladimir Indic 451be8a600 [PC Sampling] Separate counts for issued and stalled samples (#756) 2025-06-16 15:09:21 -06:00
Kandula, Venkateshwar reddy 41cd5d6531 [BUG FIX] [Counter Collection] SWDEV-523582- Use a map to differenciate xcc_sample_count wrt event id. (#99)
* use a map to differenciate xcc_sample_count wrt event id.

Change-Id: Ie1f2e8466edb244574686d49008125dc9f4e7efd

* Format.

Change-Id: I668c6ed448d8610d9d66f9cf77d0d27d7cf4e8b6

* use blockinfo to get xcc_sample_count.

Change-Id: I066a10e3185df4c8767d4f8eae59aca1f78f5284

* use EventAttribDim for xcc_sample_count.

Change-Id: Ide3707934b5b42c0462ea332b27f6e2e4fc0449f

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-06-16 16:09:13 -05:00