6f439f0232
Fix ambiguity of fma for _Float16 for libc++ ( #1976 )
...
libc++ defines fma as template function for auto promotion of mixed-type
arguments. libc++ does not handle _Float16 as _Float16 is not a supported
type by C++ standard. As such, it is unlikely we can commit our fix for
_Float16 to libc++ trunk.
Therefore we handle _Float16 with a template specialization of
__numeric_type in HIP headers.
Change-Id: If01960a657ebf1a7a67463cdcf66fab7458dff3c
2020-04-06 15:35:18 +05:30
062938a14c
Remove address_space(1) typecast and use __ockl_atomic_add_noret_f32 ( #1956 )
...
* Remove address_space(1) typecast for ockl_global_atomic_add_f32
* use __ockl_atomic_add_noret_f32
2020-03-28 17:28:33 +05:30
6ab1e864b6
don't expose symbols from code_object_bundle ( #1971 )
...
Change-Id: I56479485aad42c3d517fe6d9055be1cd846eeb00
2020-03-27 14:09:07 +05:30
13b73692d8
Fix for __usad issue ( #1972 )
...
Fixes #1930
2020-03-26 17:09:44 +05:30
09ffe4365d
Add const qualifiers to HIP_vector_type unary arithmetic operators ( #1965 )
...
Resolves issue #1960
2020-03-26 17:09:00 +05:30
341ef7fdca
Fix cooperative launch APIs to set hipGetLastError ( #1935 )
...
* Fix cooperative launch APIs to set hipGetLastError
Previously, the cooperative launch APIs did not properly log their
errors in the global hipGetLastError variable before returning back
to the user. As such, the APIs would leave hipSuccess in the
last error, which would break some use cases.
This fixes that problem by making a trampoline function that does
the HIP_INIT_API and ihipLogStatus.
* Add missing flag to the log of multi-GPU launch
2020-03-25 14:39:24 -07:00
bf2fcce488
Update hip_runtime_api.h ( #1966 )
...
Correct URL for deprecated api list
2020-03-23 10:16:24 -07:00
0307ae4c9a
Workaround for libc++ include path for HIP-Clang ( #1917 )
...
HIP-Clang cuda_wrapper headers require clang include path before standard C++ include path.
However libc++ include path requires to be before clang include path.
To workaround this, we pass -isystem with the parent directory of clang include
path instead of the clang include path itself.
2020-03-18 11:20:21 +05:30
8a3ce17ba6
Adding Half Abs APIs ( #1902 )
2020-03-17 14:13:19 +05:30
446a9e82e2
enable HCC printf when using hip-clang ( #1947 )
...
This allows printf to work with hip-clang and HCC runtime. See comments under #1919 for a reported bug and feature request.
2020-03-17 14:03:27 +05:30
5ddb9e1eb7
Fix __sad signature match with Cuda ( #1936 )
...
Fix for issue #1930
2020-03-17 14:02:00 +05:30
e8bd9768d1
Annotate __constant__ ( #1901 )
2020-03-17 13:59:44 +05:30
fc223dc584
[hip] Improve the portability of the header for vector type support. ( #1873 )
...
- Need to check the availability of `__has_attribute` builtin macro
instead of compiler versions. That's more reliable and portable among
various compilers.
- Provides a very basic support of vectors for unknown compilers.
2020-03-17 13:59:24 +05:30
b9544eabe8
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_robust_constant
2020-03-12 14:20:26 +00:00
af933d0900
Expose support for non-returning atomic FADD ( #1909 )
...
Change-Id: If5359488324477315a9bd4f308a75f606c065b39
2020-03-11 14:33:15 +05:30
a9af4755cb
Fix incorrect shfl_xor for Windows
...
copy/paste error, need __shfl_xor w/ lane_mask
2020-03-10 12:04:05 -05:00
2c3dfdda41
separate printf declaration for vdi/clang
...
There are now two implementations of printf in HIP:
1. The implemenation for HCC is controlled by the HC_FEATURE_PRINTF
macro, and it works only with the HCC compiler used in combination
with the HCC runtime.
2. The implementation for hip-clang requires the VDI runtime, and is
always enabled with that combination.
2020-03-09 09:40:05 +05:30
48f5524fdc
Expose support for non-returning atomic FADD
...
Change-Id: If5359488324477315a9bd4f308a75f606c065b39
2020-03-05 10:30:52 +05:30
3441cd7f16
Annotate __constant__
2020-02-28 22:54:00 +02:00
40a28e767e
Fix HIPRTC headers to export C style symbols ( #1879 )
2020-02-28 16:47:29 +05:30
1c794045e0
Add hipDrvOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags] ( #1854 )
...
Equivalent to cuOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags].
2020-02-28 16:46:55 +05:30
a094c87038
fix long shuffle implementations for windows ( #1895 )
...
Fixes for SWDEV-223694
2020-02-26 15:53:56 +05:30
ec84c16d75
Fix hipMemcpy3D ( #1798 )
...
Fixes #1790 and #1791 . hipMemcpy3D still requires further refactoring for different input and output combinations.
2020-02-17 19:35:35 +05:30
5b0f34c59b
Implement long / long long shuffles ( #1829 )
...
Implement additional data-types for shuffles (long and long long).
Based upon the double implementation.
2020-02-15 09:51:09 +05:30
888a7f2a90
Reduce GPU copying based on arch it runs on ( #1751 )
...
Implements SWDEV-213230.
2020-02-13 14:21:51 +05:30
504412c1e4
Fix a typo causing a build error
2020-02-10 11:44:40 -05:00
dfa565d76f
resolve merge conflict
2020-02-10 10:30:55 -05:00
d032637934
Revert "Match Occupancy APIs syntax with CUDA ( #1625 )" ( #1857 )
...
Reverting this for now till we figure out how to avoid the build
breakage.
This reverts commit 262ad13dd5
2020-02-10 10:45:28 +05:30
8f96152d3a
(Maybe) Match alignment between Clang and GCC. ( #1789 )
...
Should fix #1740 and the related internal bug.
2020-02-10 10:44:49 +05:30
fa363ae721
Device texture functions should not normalize the sampled pixel ( #1826 )
...
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's
Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com >
2020-02-05 20:56:17 +05:30
6db9b782be
[HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs
2020-01-30 15:05:53 -05:00
262ad13dd5
Match Occupancy APIs syntax with CUDA ( #1625 )
...
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs
2020-01-29 13:05:53 -08:00
e419a1609f
Update the HIP_TRSF_* flags to match their Cuda equivalents. ( #1801 )
2020-01-24 11:41:15 -08:00
0605426049
SWDEV-220503: this_grid().thread_rank() gives incorrect result ( #1808 )
...
* fix a minor bug while computing this.grid()::thread_rank()
2020-01-24 16:23:28 +05:30
1d6a2fb064
Don't use accelerated vector element access for hip-clang. ( #1796 )
2020-01-15 18:17:08 -08:00
0918614615
Add missing constructors for Scalar_accessor class. ( #1792 )
2020-01-14 11:30:21 -08:00
c091635f5a
Revert PRs that break ROCm builds ( #1781 )
...
Fixes SWDEV-218626 and SWDEV-218629
Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692 )"
This reverts commit cf526f5484#1777 )"
This reverts commit cbd8f604ec
2020-01-08 15:11:58 +05:30
cbd8f604ec
Fix rocFFT build failure ( #1777 )
...
Fixes SWDEV-217761
2020-01-07 08:12:37 +05:30
ed43699a3a
Merge pull request #1759 from emankov/master
...
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
857052be1e
[hip] refactoring cooperative kernel launch APIs ( #1737 )
...
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
2019-12-30 12:42:17 +05:30
4aaa2336a8
[HIP] Clean-up deprecated HIP error codes
...
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
35988729f3
Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ ( #1761 )
...
This is to allow force enable cuda wrapper for OpenMP for flexibility
2019-12-23 19:24:54 +05:30
1ca75e5f6d
Fix the return type of demangle function so that its compatible across ABIs ( #1744 )
2019-12-23 19:11:40 +05:30
150e690a3a
Fix late-coming issues. ( #1724 )
...
Implementation for hipMemcpyWithStream.
2019-12-23 19:11:24 +05:30
32625638da
replace array designator C99 ( #1694 )
...
* replace array designator C99
* Update texture_functions.h
Highlight valid and invalid values in texFormatToSize
Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com >
2019-12-23 19:10:24 +05:30
cf526f5484
static inline in a header, just like excess sugar in a diet, causes bloat (#1692 )
2019-12-23 19:09:38 +05:30
6c7ce07577
Update texture_functions.h
...
Highlight valid and invalid values in texFormatToSize
2019-12-21 12:25:36 +05:30
911d406bf1
Fix for windows dtest build failure ( #1742 )
2019-12-19 13:10:43 -08:00
a0a50ac601
[hip] Add macro guarding the enum conversion for scalar accessor. ( #1748 )
...
- That's a high overhead part, which needs enabling ONLY if necessary.
2019-12-19 10:08:37 -08:00
539370d308
Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. ( #1729 )
2019-12-10 10:32:25 -08:00
Yaxun (Sam) Liu
Maneesh Gupta
Siu Chi Chan
Sarbojit2019
Benjamin Sherman
Joseph Greathouse
Nick Curtis
Jatin Chaudhary
Sameer Sahasrabuddhe
mhbliao
Alex Voicu
Sameer Sahasrabuddhe
saleelk
Rahul Garg
ansurya
Aryan Salmanpour
vsytch
satyanveshd
mshivama
kpyzhov
Evgeny Mankov